Skip to content

Drop BUCKET_TITLES once the legacy priority-bucket milestones are cleaned up #128

Description

@gaurav

generate_milestones.py carries a hardcoded set of titles:

BUCKET_TITLES = {"immediate", "needed soon", "needed later", "not urgent"}

It exists to recognise the legacy priority-bucket milestones — undated milestones used to rank work rather than to commit to a date. They never close, so sorting them among real deadlines would either bury the deadlines or dress the buckets up as ones. The milestones page puts them in their own section below the release schedule instead, under "Priority buckets (not deadlines)".

It is a workaround for a data problem, not a feature: a milestone should mean a deadline, and these do not. Once the buckets are cleaned up, BUCKET_TITLES, is_bucket(), the bucket flag in milestones.json and the second section of the page all go away together.

Not yet. From a live run this morning, 11 of the 18 open milestones across the five repositories are buckets:

Repository Buckets
NCATSTranslator/Babel Immediate, Needed soon, Needed later, Not urgent
NCATSTranslator/NodeNormalization Needed soon, Needed later, Not urgent
NCATSTranslator/NameResolution Needed soon, Needed later, Not urgent
TranslatorSRI/babel-validation Needed soon, Needed later

So this is blocked on the cleanup, not on the code. The substitute for what the buckets express is Priority: labels, which already exist and are already in use — see #127.

Related: NCATSTranslator/Babel#1048 covers the ~253 open issues parked in closed buckets, which is the same problem one step further along.

Follow-up to #112.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions