Skip to content

Commit 903acbc

Browse files
committed
feat(release): release asset upload method now returns response from upload put request
1 parent 13b0236 commit 903acbc

3 files changed

Lines changed: 12 additions & 8 deletions

File tree

‎examples/sync_github_release_to_gitcode.py‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,10 @@ def _sort_semantic_version(version: str) -> int:
133133
else:
134134
break
135135
try:
136-
future.result()
136+
response: httpx.Response = future.result()
137+
response.raise_for_status()
137138
print(f"{CGRN}\t> uploaded: {file_name} ({file_size} {unit}, {minutes:5g} min){CEND}", flush=True)
138-
except (httpx.TimeoutException, GitCodeError) as e:
139+
except (httpx.TimeoutException, GitCodeError, httpx.HTTPStatusError) as e:
139140
print(
140141
f"{CRED}\tx fail to upload {file_name} ({file_size} {unit}, {minutes:5g} min):{CEND} {e}",
141142
flush=True,

‎gitcode_api/resources/collaboration/issues_resource_group.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ def create(
513513
"security_hole": security_hole,
514514
"template_path": template_path,
515515
**kwargs,
516-
}
516+
},
517517
)
518518

519519
def update(

‎gitcode_api/resources/misc/releases_resource_group.py‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
from pathlib import Path
55
from typing import List, Optional, Union
66

7+
import httpx
8+
79
from ..._models import Release, ReleaseUploadURL
810
from .._shared import AsyncResource, SyncResource
911

@@ -83,7 +85,7 @@ def upload(
8385
owner: Optional[str] = None,
8486
repo: Optional[str] = None,
8587
upload_timeout: Optional[float] = 300.0,
86-
) -> None:
88+
) -> httpx.Response:
8789
"""Upload a release attachment through the pre-signed upload URL.
8890
8991
:param tag: Tag name in the release URL path.
@@ -92,6 +94,7 @@ def upload(
9294
:param owner: Repository owner path. Uses the client default when omitted.
9395
:param repo: Repository path. Uses the client default when omitted.
9496
:param upload_timeout: Timeout for upload operation. Default to 300 (5 minutes).
97+
:returns: Response for upload put request (httpx.Response).
9598
"""
9699

97100
@abstractmethod
@@ -231,7 +234,7 @@ def upload(
231234
owner: Optional[str] = None,
232235
repo: Optional[str] = None,
233236
upload_timeout: Optional[float] = 300.0,
234-
) -> None:
237+
) -> httpx.Response:
235238
upload_content = Path(content).read_bytes() if isinstance(content, str) else content
236239
if not isinstance(upload_content, bytes):
237240
raise TypeError("content must be bytes or a file path string.")
@@ -240,7 +243,7 @@ def upload(
240243
if not upload_url.url:
241244
raise ValueError("Release upload URL response did not include a URL.")
242245

243-
self._client._client.request(
246+
return self._client._client.request(
244247
"PUT",
245248
upload_url.url,
246249
content=upload_content,
@@ -372,7 +375,7 @@ async def upload(
372375
owner: Optional[str] = None,
373376
repo: Optional[str] = None,
374377
upload_timeout: Optional[float] = 300.0,
375-
) -> None:
378+
) -> httpx.Response:
376379
upload_content = Path(content).read_bytes() if isinstance(content, str) else content
377380
if not isinstance(upload_content, bytes):
378381
raise TypeError("content must be bytes or a file path string.")
@@ -381,7 +384,7 @@ async def upload(
381384
if not upload_url.url:
382385
raise ValueError("Release upload URL response did not include a URL.")
383386

384-
await self._client._client.request(
387+
return await self._client._client.request(
385388
"PUT",
386389
upload_url.url,
387390
content=upload_content,

0 commit comments

Comments
 (0)