Fixed the Node test matrix running every leg on the same Node version (#30435)

no ref

pnpm installs the Node pinned by `devEngines.runtime` and links its bin ahead of the one setup-node installs, so both legs of the unit, legacy and acceptance matrices ran 22.23.1 and the Node 24 legs proved nothing. Passing `--no-runtime` to those installs skips the runtime dependency, so each leg runs the version its matrix entry asked for.

That makes two genuine Node 24 failures visible, fixed here so the matrix goes green on both legs:

- `res._headers` was removed in Node 24, so the mock-express helper handed every assertion an undefined headers object.
- Node 24 adds a literal `module.exports` key to a CJS module's namespace. The external-globals plugin re-exports every key, emitting `export const module.exports = React.module.exports;`, which rolldown rejects and which failed every admin build.

Author: acburdine

.github/workflows/ci.yml

@@ -554,8 +554,9 @@ jobs:
         with:
           node-version: ${{ env.NODE_VERSION }}
           trust-lockfile: 'true'
-          # --force for the same reason as job_unit-tests: better-sqlite3 is an
-          # optionalDependency and boot uses it for the development database.
+          # better-sqlite3 is an optionalDependency that pnpm may skip when
+          # restoring from a cached store, and boot needs it for the
+          # development database.
           install-args: --force
 
       - name: Install hyperfine
@@ -693,11 +694,9 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
           trust-lockfile: 'true'
-          # better-sqlite3 is an optionalDependency. Without --force, pnpm may skip
-          # installing/linking it when restoring from a cached store. --force
-          # ensures all optional deps are installed regardless.
-          # (ghost core's test:unit job requires better-sqlite3)
-          install-args: --force
+          # Without --no-runtime, pnpm links the devEngines Node and every
+          # leg of this matrix runs that same version.
+          install-args: --no-runtime
 
       - name: Set timezone (non-UTC)
         uses: szenius/set-timezone@1f9716b0f7120e344f0c62bb7b1ee98819aefd42 # v2.0
@@ -796,6 +795,9 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
           trust-lockfile: 'true'
+          # Without --no-runtime, pnpm links the devEngines Node and every
+          # leg of this matrix runs that same version.
+          install-args: --no-runtime
 
       - name: Set timezone (non-UTC)
         uses: szenius/set-timezone@1f9716b0f7120e344f0c62bb7b1ee98819aefd42 # v2.0
@@ -900,6 +902,9 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
           trust-lockfile: 'true'
+          # Without --no-runtime, pnpm links the devEngines Node and every
+          # leg of this matrix runs that same version.
+          install-args: --no-runtime
 
       - name: Set env vars (MySQL)
         run: |

apps/admin-x-framework/src/vite.ts

@@ -22,7 +22,10 @@ const externalPlugin = ({ externals }: { externals: Record<string, string> }): P
       if (originalId) {
         const module = await import(originalId);
 
+        // Node 24 adds a literal `module.exports` key to a CJS namespace, which
+        // is not a valid identifier to re-export.
         return Object.keys(module)
+          .filter((key) => /^[A-Za-z_$][\w$]*$/.test(key))
           .map((key) =>
             key === 'default'
               ? `export default ${externalName};`

ghost/core/test/legacy/mock-express-style/utils/mock-express.js

@@ -37,7 +37,7 @@ module.exports = {
           err: res.req.err,
           body: body,
           statusCode: res.statusCode,
-          headers: res._headers,
+          headers: res.getHeaders(),
           template: res._template,
           req: req,
           res: res,
@@ -49,7 +49,7 @@ module.exports = {
           err: res.req.err,
           body: body,
           statusCode: res.statusCode,
-          headers: res._headers,
+          headers: res.getHeaders(),
           template: res._template,
           req: req,
           res: res,