Skip to content

🎨 Updated default node version to 24 - #30434

Open
acburdine wants to merge 1 commit into
mainfrom
feat/node-24
Open

🎨 Updated default node version to 24#30434
acburdine wants to merge 1 commit into
mainfrom
feat/node-24

Conversation

@acburdine

Copy link
Copy Markdown
Member

no ref

  • bump default node version to 24
  • widen engines block to include node 24
  • bump node types to 24

@acburdine
acburdine requested a review from 9larsons as a code owner September 1, 2026 17:43
@nx-cloud

nx-cloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit f20d392

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 4m 35s View ↗
nx run @tryghost/admin:test:acceptance ✅ Succeeded 9m 34s View ↗
nx run-many -t test:unit -p @tryghost/adapter-b... ✅ Succeeded 8m 35s View ↗
nx run ghost:test:integration ✅ Succeeded 3m 46s View ↗
nx run ghost:test:ci:e2e ✅ Succeeded 4m 21s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 23s View ↗
nx run ghost:test:legacy ✅ Succeeded 3m 13s View ↗
nx run ghost:test:e2e ✅ Succeeded 3m 14s View ↗
Additional runs (11) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-01 19:59:05 UTC

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.16%. Comparing base (fd8026e) to head (d7e50d2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #30434      +/-   ##
==========================================
- Coverage   67.39%   67.16%   -0.24%     
==========================================
  Files        1656     1656              
  Lines       59939    59939              
  Branches    10365    10365              
==========================================
- Hits        40394    40256     -138     
- Misses      17267    17442     +175     
+ Partials     2278     2241      -37     
Flag Coverage Δ
admin-tests 57.50% <ø> (+0.03%) ⬆️
e2e-tests 69.85% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 33545101115 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Team

Run ID: 4f79e318-524d-468f-ad07-2791e6a5ec28

📥 Commits

Reviewing files that changed from the base of the PR and between ace4ae7 and d7e50d2.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • ghost/core/package.json
  • pnpm-workspace.yaml

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (12)
  • GitHub Check: Unit tests (Node 22.23.1)
  • GitHub Check: App Playwright Acceptance Tests (@tryghost/koenig-lexical)
  • GitHub Check: Legacy tests (Node 22.23.1, mysql8)
  • GitHub Check: App Playwright Acceptance Tests (@tryghost/admin)
  • GitHub Check: Build Docker Images
  • GitHub Check: Acceptance tests (Node 24.20.0, mysql8)
  • GitHub Check: Build Admin
  • GitHub Check: Acceptance tests (Node 22.23.1, mysql8)
  • GitHub Check: Admin tests - Chrome
  • GitHub Check: Unit tests (Node 24.20.0)
  • GitHub Check: Legacy tests (Node 24.20.0, mysql8)
  • GitHub Check: Lint
🧰 Additional context used
📓 Path-based instructions (2)
Prioritise concrete correctness, security, data-integrity, compatibility,

⚙️ CodeRabbit configuration file

Files:

  • ghost/core/package.json
  • pnpm-workspace.yaml
Always use `pnpm`, never npm or Yarn.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • ghost/core/package.json
  • pnpm-workspace.yaml
🔇 Additional comments (2)
ghost/core/package.json (1)

66-67: LGTM!

Also applies to: 95-105, 127-144, 255-256, 317-317

pnpm-workspace.yaml (1)

82-100: LGTM!

Also applies to: 107-107, 226-226


Walkthrough

The repository now supports Node.js 24.20.0 while retaining Node.js 22.23.1 support. Runtime pins, package engine ranges, Docker images, CI workflows, publishing workflows, documentation, and version checks were updated. CI tests Node.js 24.20.0 first and Node.js 22.23.1 second. Node type definitions and related package dependencies were updated.

Suggested reviewers: 9larsons, evanhahn

Merge Risk: ⚪ Minimal · up to d7e50

The Node.js version and compatibility updates are merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating the default Node.js version to 24. The emoji does not prevent understanding.
Description check ✅ Passed The description is directly related to the changeset. It identifies the Node.js version update, the expanded engines range, and the Node type update.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries ✅ Passed PASS. The committed diff adds no new TypeScript or runtime source. The only changed source file is the pre-existing apps/ember-admin/lib/check-node-version.js, and the PR changes only two Node.js me…
New Files Are Typescript ✅ Passed PASS: The exact PR diff adds no .js, .jsx, .cjs, or .mjs files. It only modifies the pre-existing apps/ember-admin/lib/check-node-version.js, which is also an explicitly exempt path. All oth…
Full details: Type-Safe Boundaries

Explanation

PASS. The committed diff adds no new TypeScript or runtime source. The only changed source file is the pre-existing apps/ember-admin/lib/check-node-version.js, and the PR changes only two Node.js message strings. The remaining changes are manifests, lockfile data, workflows, Docker/config files, docs, and a changeset. No boundary validation bypass, new any, unchecked as, @ts-nocheck, @ts-ignore, or duplicated Zod shape was introduced.

Full details: New Files Are Typescript

Explanation

PASS: The exact PR diff adds no .js, .jsx, .cjs, or .mjs files. It only modifies the pre-existing apps/ember-admin/lib/check-node-version.js, which is also an explicitly exempt path. All other added content is a changeset file.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/node-24

Comment @coderabbitai help to get the list of available commands.

@acburdine
acburdine force-pushed the feat/node-24 branch 2 times, most recently from 47c5f0b to f20d392 Compare September 1, 2026 19:42
no ref
- bump default node version to 24
- widen engines block to include node 24
- bump node types to 24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant