🎨 Updated default node version to 24 - #30434
Conversation
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 4m 35s | View ↗ |
nx run @tryghost/admin:test:acceptance |
✅ Succeeded | 9m 34s | View ↗ |
nx run-many -t test:unit -p @tryghost/adapter-b... |
✅ Succeeded | 8m 35s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 3m 46s | View ↗ |
nx run ghost:test:ci:e2e |
✅ Succeeded | 4m 21s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 23s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 3m 13s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 3m 14s | View ↗ |
Additional runs (11) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-09-01 19:59:05 UTC
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30434 +/- ##
==========================================
- Coverage 67.39% 67.16% -0.24%
==========================================
Files 1656 1656
Lines 59939 59939
Branches 10365 10365
==========================================
- Hits 40394 40256 -138
- Misses 17267 17442 +175
+ Partials 2278 2241 -37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2aba111 to
ace4ae7
Compare
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 33545101115 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (12)
🧰 Additional context used📓 Path-based instructions (2)Prioritise concrete correctness, security, data-integrity, compatibility,⚙️ CodeRabbit configuration file Files:
Always use `pnpm`, never npm or Yarn.📄 CodeRabbit inference engine (AGENTS.md) Files:
🔇 Additional comments (2)
WalkthroughThe repository now supports Node.js 24.20.0 while retaining Node.js 22.23.1 support. Runtime pins, package engine ranges, Docker images, CI workflows, publishing workflows, documentation, and version checks were updated. CI tests Node.js 24.20.0 first and Node.js 22.23.1 second. Node type definitions and related package dependencies were updated. Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Node.js version and compatibility updates are merge-ready after normal checks and review; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Full details: Type-Safe BoundariesExplanation PASS. The committed diff adds no new TypeScript or runtime source. The only changed source file is the pre-existing Full details: New Files Are TypescriptExplanation PASS: The exact PR diff adds no ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
47c5f0b to
f20d392
Compare
no ref - bump default node version to 24 - widen engines block to include node 24 - bump node types to 24
f20d392 to
d7e50d2
Compare

no ref