test(device): submit the link popover by pressing the real Enter key

Two review questions shaped this. First: the old dispatched KeyboardEvent
could never submit once the popovers moved to the form's submit event —
synthetic events trigger no default action. Second: 'why not hit the
Enter key?' — no reason not to, and the rig already knew how: on iOS,
pressSoftKeyboardEnter taps the on-screen keyboard's actual return key
(the RETURN_KEY_RATIOS offset ladder) — the real user gesture. On
Android, where BrowserStack blocks native taps, a W3C protocol Enter is
used instead: trusted input, so the browser runs its default action and
the real path is exercised (key press -> implicit form submission -> the
popover's submit handling). Only Gboard's own choice of *which* action
its key performs stays out of reach, on the manual release checklist.
Callers supply the verify script the iOS tap ladder needs.

Author: YousefED

tests/device/formattingToolbar.device.test.ts

@@ -139,10 +139,10 @@ for (const device of activeDevices()) {
           toolbar: true,
         });
 
-        await typeAndSubmit(session, `${LINK_POPOVER} input`, "example.com");
-
-        await session.waitFor(
-          "link created and popover closed",
+        await typeAndSubmit(
+          session,
+          `${LINK_POPOVER} input`,
+          "example.com",
           `return {
             ok: !!document.querySelector('.bn-editor a[href="https://example.com"]')
               && !document.querySelector(${JSON.stringify(LINK_POPOVER)}),

tests/device/linkPopover.ts

@@ -3,7 +3,7 @@
  * use them, since only the link tests speak these concepts.
  */
 import { MOBILE_TOOLBAR, PARAGRAPH, startEditing } from "./lib/editorPage.js";
-import { tapElement } from "./lib/gestures.js";
+import { pressSoftKeyboardEnter, tapElement } from "./lib/gestures.js";
 import type { DeviceSession } from "./lib/webdriver.js";
 
 export const LINK_BUTTON = `${MOBILE_TOOLBAR} [data-test="createLink"]`;
@@ -71,26 +71,25 @@ export async function openLinkPopover(session: DeviceSession): Promise<void> {
 }
 
 /**
- * Types into a popover field and submits it the way the browser does:
- * `requestSubmit()` on the enclosing form, which runs the popover's real
- * `onSubmit` wiring. A dispatched Enter keydown cannot do this — synthetic
- * events trigger no default action, and the popovers commit through the
- * form's `submit` event rather than key handlers. Tapping the on-screen
- * keyboard's action key isn't an option either: no automation channel
- * reaches it (see the README) — which also means the IME's own choice of
- * action stays a manual release check.
+ * Types into a popover field and submits it by pressing the Enter key.
+ *
+ * On iOS that is a native tap on the on-screen keyboard's actual return key
+ * (the real user gesture — see `pressSoftKeyboardEnter`'s offset ladder). On
+ * Android, where BrowserStack blocks native taps, it is a W3C protocol Enter:
+ * trusted input, so the browser still runs its default action and the real
+ * submission path is exercised (key press -> implicit form submission -> the
+ * popover's `submit` handling). Only Gboard's own choice of *which* action
+ * its key performs stays out of reach, and on the manual release checklist.
+ *
+ * `verify` is a page script returning `{ ok: boolean }` observing the
+ * submission's effect — the iOS tap ladder needs it to know a tap landed.
  */
 export async function typeAndSubmit(
   session: DeviceSession,
   css: string,
   text: string,
+  verify: string,
 ): Promise<void> {
   await session.elementValue(css, text);
-  await session.exec(
-    `const el = document.querySelector(arguments[0]);
-     if (el && el.form) {
-       el.form.requestSubmit();
-     }`,
-    [css],
-  );
+  await pressSoftKeyboardEnter(session, verify);
 }