test(device): discover the booted simulator race-free

The setup's env-var handoff never reached vitest's workers in CI (global
setup and workers don't share an environment), and the discovery regex
missed the UDID's closing paren, so sessions saw no booted simulator.
Sessions now discover the booted device themselves with a short retry;
the setup boots via 'bootstatus -b' — boots if needed, returns promptly
when already up — with no simulator state strings to pattern-match.

Author: YousefED

tests/device/lib/localIos.ts

@@ -50,12 +50,28 @@ export class LocalIosSession implements DeviceSession {
   ) {}
 
   static async create(): Promise<LocalIosSession> {
-    const udid = process.env.BN_IOS_SIMULATOR_UDID;
-    if (!udid) {
-      throw new Error(
-        "BN_IOS_SIMULATOR_UDID is not set — the device-suite setup boots the " +
-          "simulator and exports it (see lib/tunnel.ts).",
-      );
+    // The suite's setup (lib/tunnel.ts) boots a simulator; discover it here
+    // rather than passing state across processes — vitest's global setup and
+    // its workers don't share an environment.
+    let udid: string | undefined;
+    const deadline = Date.now() + 30_000;
+    while (!udid) {
+      const { stdout } = await execFileAsync("xcrun", [
+        "simctl",
+        "list",
+        "devices",
+        "available",
+      ]);
+      udid = stdout.match(/([0-9A-F-]{36})\) \(Booted\)/)?.[1];
+      if (!udid && Date.now() > deadline) {
+        throw new Error(
+          "No booted iOS simulator found — the device-suite setup should " +
+            "have booted one (see lib/tunnel.ts).",
+        );
+      }
+      if (!udid) {
+        await new Promise((resolve) => setTimeout(resolve, 2_000));
+      }
     }
     const driver = await new Builder()
       .usingServer(`http://127.0.0.1:${APPIUM_PORT}`)

tests/device/lib/tunnel.ts

@@ -60,32 +60,30 @@ async function startBrowserStackTunnel(
 }
 
 async function startLocalIos(): Promise<() => Promise<void>> {
-  // Pick (and if needed boot) an iPhone simulator; sessions attach to it via
-  // BN_IOS_SIMULATOR_UDID. Headless is fine: XCUITest owns the HID stack, so
+  // Pick (and if needed boot) an iPhone simulator; sessions discover the
+  // booted device themselves (vitest's global setup and its workers don't
+  // share an environment). Headless is fine: XCUITest owns the HID stack, so
   // the software keyboard appears without the Simulator GUI.
   const { stdout } = await execFileAsync("xcrun", [
     "simctl",
     "list",
     "devices",
     "available",
   ]);
-  let udid = stdout.match(/([0-9A-F-]{36}) \(Booted\)/)?.[1];
-  let bootedByUs: string | undefined;
+  // Prefer a device that is already up; otherwise take the first iPhone.
+  // `bootstatus -b` boots if needed and returns promptly when already booted,
+  // so there are no state-string races ("Booted", "Shutting Down", ...) to
+  // pattern-match.
+  const already = stdout.match(/iPhone [^(]+\(([0-9A-F-]{36})\) \(Booted\)/);
+  const any = stdout.match(/iPhone [^(]+\(([0-9A-F-]{36})\)/);
+  const udid = already?.[1] ?? any?.[1];
   if (!udid) {
-    const device = stdout.match(/iPhone [^(]+\(([0-9A-F-]{36})\) \(Shutdown\)/);
-    if (!device) {
-      throw new Error(
-        "No available iPhone simulator found (xcrun simctl list).",
-      );
-    }
-    bootedByUs = device[1];
-    udid = bootedByUs;
-    await execFileAsync("xcrun", ["simctl", "boot", bootedByUs]);
-    await execFileAsync("xcrun", ["simctl", "bootstatus", bootedByUs], {
-      timeout: 180_000,
-    });
+    throw new Error("No available iPhone simulator found (xcrun simctl list).");
   }
-  process.env.BN_IOS_SIMULATOR_UDID = udid;
+  await execFileAsync("xcrun", ["simctl", "bootstatus", udid, "-b"], {
+    timeout: 240_000,
+  });
+  const bootedByUs = already ? undefined : udid;
 
   // Appium with the XCUITest driver (an npm devDependency, which Appium
   // discovers). Note Appium requires an even-numbered Node (see