Commit d10475e
committed
test(device): submit the link popover with a real Enter key press
Review question: why not hit the Enter key instead of requestSubmit()?
No good reason — a W3C protocol Enter is trusted input, so the browser
runs its default action and the whole real path is exercised: key press,
implicit form submission, the popover's submit handling. requestSubmit()
skipped the key half. (The old dispatched KeyboardEvent was the thing
that couldn't work: synthetic events trigger no default action.) The
on-screen keyboard's own action button remains unreachable and stays on
the manual release checklist.1 parent f3e0db3 commit d10475e
1 file changed
Lines changed: 11 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
82 | 84 | | |
83 | 85 | | |
84 | 86 | | |
85 | 87 | | |
86 | 88 | | |
87 | 89 | | |
88 | 90 | | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
| 91 | + | |
96 | 92 | | |
0 commit comments