Move pytest validations to its own directory - #3639
Conversation
8061515 to
070e2f8
Compare
a60328b to
1bae6e2
Compare
sauravbanna
left a comment
There was a problem hiding this comment.
looks great, some good refactors ! i suggested a few more to reduce repetitive validations
320e9b7 to
ced6821
Compare
59e3fc7 to
4daf7af
Compare
5b327bc to
b976287
Compare
| ball_moves_at_rest_validation = BallAlwaysMovesFromRest( | ||
| position=tbots_cpp.Point(0, 0), threshold=0.05 | ||
| ball_moves_at_rest_validation = BallNeverEntersRegion( | ||
| regions=[tbots_cpp.Circle(tbots_cpp.Point(0, 0), 0.05)] | ||
| ) |
There was a problem hiding this comment.
NOTE: If you look at the old validation logic for BallMovesFromRest, it does the same thing of checking if ball is within a radius to an initial position. That specific validation is not used anywhere else, so it has been removed in this PR
There was a problem hiding this comment.
This validation has been modified to include a robot_id parameter so that it can be a parent class for FriendlyReceivesBallSlow since they have lots of overlapped code
|
@sauravbanna @Andrewyx @adrianchan787 I've reverted many changes in this PR so that only the changes relevant to moving the pytest validations are included which should make it much easier to review (pretty much just 1-5 line changes on each file). The one large change to refactor the Would appreciate a review on this one whenever you have time |
(PART 1)
Description
Testing Done
Resolved Issues
part of #2558
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue