Skip to content

m_noJVTVeto and m_dofJVTVeto are not implemented consistently and can easily lead to confusion #1684

Description

@tofitsch

In JetSelector both for JVT and fJVT there is the option only to decorate the (f)JVT decision to the jet rather than actually rejecting jets failing this criterion.

The options for this are called m_noJVTVeto and m_dofJVTVeto. Note the do rather than no in fJVT. Therefore these options work in opposite ways. This can easily lead to confusions and should be made consistent (both no or both do).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions