Add timer to tests - #376
Merged
Merged
Conversation
samcunliffe
reviewed
Sep 17, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds execution timing functionality to the system tests by tracking how long each test command takes to run and displaying the elapsed time to the user.
- Replaces
printstatements withsys.stdout.writefor output formatting - Implements timer logic using
time.time()to measure test execution duration - Displays elapsed time in seconds after each test completes
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
samcunliffe
added
testing
Collaborator
Author
|
Output is now visible in the logs: https://github.com/UCL/TDMS/actions/runs/17826245607/job/50680792730#step:9:17 |
willGraham01
enabled auto-merge (squash)
September 18, 2025 11:05
samcunliffe
approved these changes
Sep 18, 2025
samcunliffe
left a comment
samcunliffe
left a comment
Member
There was a problem hiding this comment.
You've still got too many sig. fig.s to my taste. And elapsed not ellapsed (annoyingly elipse ellipse is the other way around).
But now working 👍
Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a timer to the system tests