Merge pull request #8 from UnleashMystCode/be/lint-typescript-actions

fix(actions): remove explicit any type annotations, fix type safety i…

Author: AlrafuruNotFound

.docs/CHANGELOG.md

@@ -4,6 +4,13 @@
 **Rule:** Semua perubahan struktur, penambahan file, atau pergantian status fitur WAJIB dicatat di sini terlebih dahulu sebelum memperbarui dokumen spesifik di `.docs/`.
 ---
 ---
+## [v3.9.2] - 2026-05-28
+### Fixed (TypeScript & Linting)
+- **Strict Actions Type-Safety:** Refactoring type-safe catch blocks in all server actions to remove any explicit `any` types. Checked for `instanceof Error` dynamically when returning or logging errors.
+- **Prisma Actions Typing:** Strongly typed `updateData` variables using `Prisma.BannerHomepageUpdateInput` and `Prisma.KegiatanUpdateInput` instead of `any`.
+- **ZodError Bugfix:** Fixed a TypeScript check error in `potensi.action.ts` where `error.errors` was used instead of the correct `error.issues` for `ZodError` properties.
+- **Linter Warnings Cleanup:** Removed unused variable `searchParam` in `search.action.ts` to clear linter warnings.
+
 ## [v3.9.1] - 2026-05-28
 ### Changed (DevOps & Workflow)
 - **Branch Rename (pr -> dev):** Mengubah nama cabang integrasi/staging dari `pr` menjadi `dev` di seluruh berkas konfigurasi workflow GitHub Actions (`ci.yml`, `docs-sync.yml`), template PR (`PULL_REQUEST_TEMPLATE.md`), berkas kontribusi (`CONTRIBUTING.md`), blueprint arsitektur (`architecture.md`), serta berkas panduan AI (`.cursorrules`, `.agentrules`, dll.) demi memperjelas alur branching dan menghindari kebingungan.

actions/auth.action.ts

@@ -59,8 +59,9 @@ export async function loginAction(formData: FormData) {
     });
 
     return { success: true, message: "Login berhasil" };
-  } catch (error: any) {
-    return { success: false, message: error.message };
+  } catch (error) {
+    const errorMessage = error instanceof Error ? error.message : "Terjadi kesalahan";
+    return { success: false, message: errorMessage };
   }
 }
 

actions/banner.action.ts

@@ -6,6 +6,7 @@ import { writeFile, unlink, mkdir } from "fs/promises";
 import path from "path";
 import { z } from "zod";
 import { verifySession } from "@/lib/safe-action";
+import { Prisma } from "@prisma/client";
 
 // --- SKEMA VALIDASI ---
 const BannerSchema = z.object({
@@ -53,7 +54,7 @@ export async function saveBanner(formData: FormData) {
     const id = validData.data.id ? parseInt(validData.data.id) : null;
 
     if (id) {
-      const updateData: any = {
+      const updateData: Prisma.BannerHomepageUpdateInput = {
         halaman: validData.data.halaman,
         tagline: validData.data.tagline,
         judul: validData.data.judul,
@@ -84,8 +85,9 @@ export async function saveBanner(formData: FormData) {
     revalidatePath("/");
 
     return { success: true, message: "Banner berhasil disimpan!" };
-  } catch (error: any) {
-    return { success: false, message: error.message };
+  } catch (error) {
+    const errorMessage = error instanceof Error ? error.message : "Terjadi kesalahan";
+    return { success: false, message: errorMessage };
   }
 }
 
@@ -115,7 +117,8 @@ export async function hapusBanner(id: number) {
     revalidatePath("/");
 
     return { success: true, message: "Banner berhasil dihapus!" };
-  } catch (error: any) {
-    return { success: false, message: error.message };
+  } catch (error) {
+    const errorMessage = error instanceof Error ? error.message : "Terjadi kesalahan";
+    return { success: false, message: errorMessage };
   }
 }

actions/berita.action.ts

@@ -4,6 +4,7 @@ import { revalidatePath } from "next/cache";
 import prisma from "@/lib/db";
 import { z } from "zod";
 import { verifySession } from "@/lib/safe-action";
+import { Prisma } from "@prisma/client";
 
 // --- SKEMA VALIDASI ---
 const KegiatanSchema = z.object({
@@ -44,8 +45,9 @@ export async function simpanBerita(rawFormData: FormData) {
     revalidatePath("/admin/halaman/berita");
     revalidatePath("/home");
     return { success: true, message: "Berita berhasil ditambahkan!" };
-  } catch (error: any) {
-    return { success: false, message: error.message };
+  } catch (error) {
+    const errorMessage = error instanceof Error ? error.message : "Terjadi kesalahan";
+    return { success: false, message: errorMessage };
   }
 }
 
@@ -61,8 +63,9 @@ export async function hapusBerita(id: number) {
     revalidatePath("/admin/halaman/berita");
     revalidatePath("/home");
     return { success: true, message: "Berita berhasil dihapus!" };
-  } catch (error: any) {
-    return { success: false, message: error.message };
+  } catch (error) {
+    const errorMessage = error instanceof Error ? error.message : "Terjadi kesalahan";
+    return { success: false, message: errorMessage };
   }
 }
 
@@ -78,7 +81,7 @@ export async function editBerita(id: number, rawFormData: FormData) {
     const penulis = rawFormData.get("penulis") as string;
     const status = rawFormData.get("status") as string;
 
-    const dataToUpdate: any = { judul, isi };
+    const dataToUpdate: Prisma.KegiatanUpdateInput = { judul, isi };
     if (gambar) dataToUpdate.gambar = gambar;
     if (kategori) dataToUpdate.kategori = kategori;
     if (penulis) dataToUpdate.penulis = penulis;
@@ -91,7 +94,8 @@ export async function editBerita(id: number, rawFormData: FormData) {
 
     revalidatePath("/admin/halaman/berita");
     revalidatePath("/berita");
-  } catch (error: any) {
-    console.error("Gagal ubah berita:", error.message);
+  } catch (error) {
+    const errorMessage = error instanceof Error ? error.message : "Terjadi kesalahan";
+    console.error("Gagal ubah berita:", errorMessage);
   }
 }

actions/kontak.action.ts

@@ -26,7 +26,7 @@ export async function simpanSiteConfig(formData: FormData) {
     );
     revalidatePath("/admin/halaman/kontak");
     revalidatePath("/kontak");
-  } catch (error: any) {
+  } catch (error) {
     console.error("Failed to save site config:", error);
   }
 }
@@ -49,9 +49,10 @@ export async function ubahStatusPesan(id: number, status: string) {
     await prisma.pesanMasuk.update({ where: { id }, data: { status } });
     revalidatePath("/admin/halaman/kontak");
     return { success: true };
-  } catch (error: any) {
+  } catch (error) {
+    const errorMessage = error instanceof Error ? error.message : "Terjadi kesalahan";
     console.error("Failed to change message status:", error);
-    return { success: false, error: error.message };
+    return { success: false, error: errorMessage };
   }
 }
 
@@ -61,8 +62,9 @@ export async function hapusPesan(id: number) {
     await prisma.pesanMasuk.delete({ where: { id } });
     revalidatePath("/admin/halaman/kontak");
     return { success: true };
-  } catch (error: any) {
+  } catch (error) {
+    const errorMessage = error instanceof Error ? error.message : "Terjadi kesalahan";
     console.error("Failed to delete message:", error);
-    return { success: false, error: error.message };
+    return { success: false, error: errorMessage };
   }
 }

actions/potensi.action.ts

@@ -96,10 +96,10 @@ export async function simpanPotensi(formData: FormData) {
     revalidatePath("/admin/halaman/potensi-desa");
     revalidatePath("/potensi-desa");
     return { success: true };
-  } catch (error: any) {
+  } catch (error) {
     console.error("Error simpan potensi:", error);
-    if (error.name === "ZodError") {
-      return { success: false, error: error.errors[0].message };
+    if (error instanceof z.ZodError) {
+      return { success: false, error: error.issues[0].message };
     }
     return { success: false, error: "Gagal menyimpan data potensi." };
   }

actions/search.action.ts

@@ -14,8 +14,6 @@ export type SearchResult = {
 export async function globalSearch(query: string): Promise<SearchResult[]> {
   if (!query || query.trim() === "") return [];
 
-  const searchParam = `%${query.trim()}%`;
-
   try {
     // Cari di tabel Kegiatan (Berita)
     const berita = await prisma.kegiatan.findMany({
@@ -46,7 +44,7 @@ export async function globalSearch(query: string): Promise<SearchResult[]> {
     });
 
     // Format dan gabungkan hasil
-    const formattedBerita: SearchResult[] = berita.map((b: any) => ({
+    const formattedBerita: SearchResult[] = berita.map((b) => ({
       id: `berita-${b.id}`,
       judul: b.judul,
       slug: b.slug,
@@ -55,7 +53,7 @@ export async function globalSearch(query: string): Promise<SearchResult[]> {
       tanggal: b.tanggal,
     }));
 
-    const formattedPotensi: SearchResult[] = potensi.map((p: any) => ({
+    const formattedPotensi: SearchResult[] = potensi.map((p) => ({
       id: `potensi-${p.id}`,
       judul: p.judul,
       slug: p.slug,

actions/tentang-kami.action.ts

@@ -21,9 +21,10 @@ export async function tambahPerangkat(formData: FormData) {
     revalidatePath("/admin/halaman/tentang-kami/struktur");
     revalidatePath("/tentang-kami");
     return { success: true };
-  } catch (error: any) {
+  } catch (error) {
+    const errorMessage = error instanceof Error ? error.message : "Terjadi kesalahan";
     console.error("Failed to add perangkat:", error);
-    return { success: false, error: error.message };
+    return { success: false, error: errorMessage };
   }
 }
 
@@ -43,9 +44,10 @@ export async function ubahPerangkat(id: number, formData: FormData) {
     revalidatePath("/admin/halaman/tentang-kami/struktur");
     revalidatePath("/tentang-kami");
     return { success: true };
-  } catch (error: any) {
+  } catch (error) {
+    const errorMessage = error instanceof Error ? error.message : "Terjadi kesalahan";
     console.error("Failed to update perangkat:", error);
-    return { success: false, error: error.message };
+    return { success: false, error: errorMessage };
   }
 }
 
@@ -56,9 +58,10 @@ export async function hapusPerangkat(id: number) {
     revalidatePath("/admin/halaman/tentang-kami/struktur");
     revalidatePath("/tentang-kami");
     return { success: true };
-  } catch (error: any) {
+  } catch (error) {
+    const errorMessage = error instanceof Error ? error.message : "Terjadi kesalahan";
     console.error("Failed to delete perangkat:", error);
-    return { success: false, error: error.message };
+    return { success: false, error: errorMessage };
   }
 }
 
@@ -78,7 +81,7 @@ export async function simpanProfilKonten(formData: FormData) {
     });
     revalidatePath("/admin/halaman/tentang-kami/teks");
     revalidatePath("/tentang-kami");
-  } catch (error: any) {
+  } catch (error) {
     console.error("Failed to save profile content:", error);
   }
 }

actions/ulasan.action.ts

@@ -45,7 +45,7 @@ export async function tambahUlasan(formData: FormData) {
       message: "Terima kasih! Ulasan Anda berhasil dikirim.",
       data: ulasan 
     };
-  } catch (error: any) {
+  } catch (error) {
     console.error("Gagal tambah ulasan:", error);
     return { success: false, message: "Terjadi kesalahan sistem saat mengirim ulasan." };
   }
@@ -59,7 +59,7 @@ export async function getSemuaUlasan() {
       orderBy: { createdAt: "desc" },
     });
     return { success: true, data: ulasan };
-  } catch (error: any) {
+  } catch (error) {
     return { success: false, message: "Gagal mengambil data ulasan." };
   }
 }