fix(PLU-543): update Milvus precheck test to expect UserError - #798
Draft
potter-potter wants to merge 1 commit into
Draft
fix(PLU-543): update Milvus precheck test to expect UserError#798potter-potter wants to merge 1 commit into
potter-potter wants to merge 1 commit into
Conversation
PLU-543 reclassified a missing Milvus collection from DestinationConnectionError to UserError, but the test still asserted the old exception type and message text, causing test_precheck_fails_on_nonexistent_collection to fail even though the error is correctly raised.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 3 files
Shadow auto-approve: would not auto-approve. This PR does not meet the repository auto-approval settings.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DestinationConnectionErrortoUserError(correctly — it's a customer config issue, not a connection fault), buttest_precheck_fails_on_nonexistent_collectionstill asserted the old exception type and message text, so it fails even thoughprecheck()correctly raises an error.UserErrorand match the actual message ("Milvus collection '{name}' does not exist").Test plan
test_precheck_fails_on_nonexistent_collectiontest_precheck_succeeds,test_precheck_fails_on_nonexisting_db) remain green — unaffected by this change🤖 Generated with Claude Code