Commit 09bca9c
fix(etl-uvicorn): preserve a None file_data instead of dumping it
Review found that `run_job_with_body` converted `file_data` from its dict
form unconditionally, so a plugin declaring `file_data` optional raised
AttributeError: 'NoneType' object has no attribute 'model_dump'
before `wrap_fn` could run -- surfacing as a 500 rather than the normal
response the signature promises.
This predates the optional-body change: it was already reachable on main
via `POST {}`, since an omitted field is None whether the body is absent
or merely partial. Defaulting the body widens the same hole to bodyless
requests, so fix it here rather than leaving a 500 behind the contract
this branch is establishing.
Pass None through untouched and convert only a real value. A plugin with a
required `file_data` is unaffected: validation rejects the request before
this line, so the conversion still always runs when the field is declared
mandatory.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 78a3211 commit 09bca9c
3 files changed
Lines changed: 47 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
11 | 16 | | |
12 | 17 | | |
13 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
539 | 539 | | |
540 | 540 | | |
541 | 541 | | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
542 | 577 | | |
543 | 578 | | |
544 | 579 | | |
| |||
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
258 | 258 | | |
259 | 259 | | |
260 | 260 | | |
261 | | - | |
262 | | - | |
263 | | - | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
264 | 268 | | |
265 | 269 | | |
266 | 270 | | |
| |||
0 commit comments