Skip to content

Commit b3f4623

Browse files
committed
test(transport): assert every keepalive option on direct connections
1 parent 473b437 commit b3f4623

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

‎_test_unstructured_client/unit/test_tcp_keepalive.py‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,8 @@ def test_unit_environment_proxy_routes(monkeypatch, asynchronous, missing_proxy_
152152
assert isinstance(proxied._pool, httpcore.AsyncHTTPProxy if asynchronous else httpcore.HTTPProxy)
153153
assert proxied._pool._proxy_url.host == b"127.0.0.1"
154154
assert proxied._pool._socket_options is None
155-
if missing_proxy_helper:
156-
assert client._transport._pool._socket_options is None
155+
expected = None if missing_proxy_helper else transport.resolve_tcp_keepalive().socket_options()
156+
assert client._transport._pool._socket_options == expected
157157
assert client._transport_for_url(httpx.URL("https://excluded.example")) is client._transport
158158
_close(client)
159159

@@ -172,7 +172,11 @@ def do_GET(self):
172172
def check(response):
173173
stream = response.extensions["network_stream"]
174174
sock = stream.get_extra_info("socket")
175-
assert sock.getsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE)
175+
for level, option, value in transport.resolve_tcp_keepalive().socket_options():
176+
if (level, option) == (socket.SOL_SOCKET, socket.SO_KEEPALIVE):
177+
assert sock.getsockopt(level, option)
178+
else:
179+
assert sock.getsockopt(level, option) == value
176180

177181
async def request():
178182
async with transport.create_async_http_client() as client:

0 commit comments

Comments
 (0)