fix: normalize None text to empty string in Text elements - #4463
Open
TrueFurina wants to merge 2 commits into
Open
fix: normalize None text to empty string in Text elements#4463TrueFurina wants to merge 2 commits into
None text to empty string in Text elements#4463TrueFurina wants to merge 2 commits into
Conversation
…red/documents/elements.py
…ructured/documents/test_elements.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4084: when an
Imageelement is created withtext=None(e.g. yolox hi-res model detects a bbox with missing text),str(element)returned a non-string, breaking printing/accessing the element.Changes
unstructured/documents/elements.py:Text.__init__: normalizeNonetext to""soself.textis always astrText.__str__: fall back to""whenself.textisNone(defensive, e.g. deserialized elements)test_unstructured/documents/test_elements.py: addtest_Image_text_none_str_returns_empty_stringcovering bothimage.text == ""andstr(image) == ""Verification
ast.parsepasses on both filesImage(text=None)→text=''andstr='';Image(text='hello')unchanged →text='hello',str='hello'Image(Text), no other behavior changed