Skip to content

Commit 6bc7cf1

Browse files
committed
test: expand native parser hardening coverage
1 parent 032601d commit 6bc7cf1

12 files changed

Lines changed: 520 additions & 0 deletions

File tree

‎.gitignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ project.nuget.cache
9898

9999
# === Build outputs (CMake / native) ===
100100
**/build/
101+
**/build-*/
101102
**/build-debug/
102103
**/build_test/
103104
**/CMakeFiles/

‎CHANGELOG.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ All notable changes to this project are documented in this file.
66

77
- Ongoing performance tuning and benchmark drift stabilization
88
- Repository governance and CI hardening
9+
- Native C parser hardening added broader negative-path tests for `ICFG`/`ILOG`
10+
- Native CMake now exposes opt-in strict warning and sanitizer builds for first-party targets
911

1012
## [0.1.0] - 2026-03-25
1113

‎CONTRIBUTING.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,17 @@ cmake --build native/build --config Release
2828
ctest --test-dir native/build -C Release --output-on-failure
2929
```
3030

31+
Use the opt-in hardening builds when touching parser, bounds, or security-sensitive native code:
32+
33+
```powershell
34+
cmake -S native -B native/build-strict -DIRONFAMILY_STRICT_WARNINGS=ON
35+
cmake --build native/build-strict --config Release
36+
37+
cmake -S native -B native/build-asan -DIRONFAMILY_ENABLE_SANITIZERS=ON
38+
cmake --build native/build-asan --config Release
39+
ctest --test-dir native/build-asan -C Release --output-on-failure
40+
```
41+
3142
If documentation is affected:
3243

3344
```powershell

‎README.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,16 @@ cmake --build native/build --config Release
3535
ctest --test-dir native/build -C Release --output-on-failure
3636
```
3737

38+
Optional native hardening configs:
39+
40+
```powershell
41+
cmake -S native -B native/build-strict -DIRONFAMILY_STRICT_WARNINGS=ON
42+
cmake --build native/build-strict --config Release
43+
44+
cmake -S native -B native/build-asan -DIRONFAMILY_ENABLE_SANITIZERS=ON
45+
cmake --build native/build-asan --config Release
46+
```
47+
3848
## Current dependency limits
3949

4050
- The native build currently pulls in `libs/ironcfg-c`, whose CMake configuration requires `OpenSSL`.

‎cmake/IronFamilyDevOptions.cmake‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
option(IRONFAMILY_STRICT_WARNINGS "Enable strict warnings for first-party targets" OFF)
2+
option(IRONFAMILY_ENABLE_SANITIZERS "Enable sanitizer instrumentation for supported compilers" OFF)
3+
4+
function(ironfamily_apply_dev_options target_name)
5+
if(NOT TARGET "${target_name}")
6+
message(FATAL_ERROR "ironfamily_apply_dev_options: unknown target '${target_name}'")
7+
endif()
8+
9+
get_target_property(target_type "${target_name}" TYPE)
10+
if(target_type STREQUAL "INTERFACE_LIBRARY")
11+
return()
12+
endif()
13+
14+
if(IRONFAMILY_STRICT_WARNINGS)
15+
if(MSVC)
16+
target_compile_options("${target_name}" PRIVATE /W4 /WX)
17+
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang|GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
18+
target_compile_options("${target_name}" PRIVATE -Wall -Wextra -Wpedantic -Werror)
19+
endif()
20+
endif()
21+
22+
if(IRONFAMILY_ENABLE_SANITIZERS)
23+
if(MSVC)
24+
target_compile_options("${target_name}" PRIVATE /fsanitize=address /Zi)
25+
target_link_options("${target_name}" PRIVATE /DEBUG /INFERASANLIBS)
26+
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang|GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
27+
target_compile_options("${target_name}" PRIVATE -fsanitize=address -fsanitize=undefined -fno-omit-frame-pointer)
28+
target_link_options("${target_name}" PRIVATE -fsanitize=address -fsanitize=undefined)
29+
else()
30+
message(STATUS "Sanitizers requested for ${target_name}, but compiler support is unknown; leaving target unchanged.")
31+
endif()
32+
endif()
33+
endfunction()

‎docs/BUILD_AND_INSTALL.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,17 @@ cmake --build native/build --config Release
2929
ctest --test-dir native/build -C Release --output-on-failure
3030
```
3131

32+
Optional first-party hardening builds:
33+
34+
```powershell
35+
cmake -S native -B native/build-strict -DIRONFAMILY_STRICT_WARNINGS=ON
36+
cmake --build native/build-strict --config Release
37+
38+
cmake -S native -B native/build-asan -DIRONFAMILY_ENABLE_SANITIZERS=ON
39+
cmake --build native/build-asan --config Release
40+
ctest --test-dir native/build-asan -C Release --output-on-failure
41+
```
42+
3243
## Consumer notes
3344

3445
- The canonical native direction is portable `C99`.

‎libs/ironcfg-c/CMakeLists.txt‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ set(CMAKE_C_STANDARD 99)
55
set(CMAKE_C_STANDARD_REQUIRED ON)
66
set(CMAKE_C_EXTENSIONS OFF)
77

8+
include("${CMAKE_CURRENT_LIST_DIR}/../../cmake/IronFamilyDevOptions.cmake")
9+
810
option(IRONFAMILY_BUILD_LEGACY_CODECS "Build historical codecs and tests" OFF)
911
option(IRONFAMILY_BUILD_LEGACY_IUPD_COMPAT "Build legacy libs/ironcfg-c IUPD compatibility surface" OFF)
1012

@@ -19,6 +21,7 @@ target_include_directories(ironfamily_icfg
1921
PUBLIC
2022
${CMAKE_CURRENT_SOURCE_DIR}/include
2123
)
24+
ironfamily_apply_dev_options(ironfamily_icfg)
2225
add_library(IronFamily::ICFG ALIAS ironfamily_icfg)
2326

2427
add_library(ironfamily_ilog STATIC
@@ -28,6 +31,7 @@ target_include_directories(ironfamily_ilog
2831
PUBLIC
2932
${CMAKE_CURRENT_SOURCE_DIR}/include
3033
)
34+
ironfamily_apply_dev_options(ironfamily_ilog)
3135
add_library(IronFamily::ILOG ALIAS ironfamily_ilog)
3236

3337
add_library(ironcfg-c INTERFACE)
@@ -45,6 +49,7 @@ if(IRONFAMILY_BUILD_LEGACY_IUPD_COMPAT)
4549
PUBLIC
4650
${CMAKE_CURRENT_SOURCE_DIR}/include
4751
)
52+
ironfamily_apply_dev_options(ironfamily_iupd_compat)
4853
endif()
4954

5055
if(IRONFAMILY_BUILD_LEGACY_CODECS)
@@ -57,6 +62,7 @@ if(IRONFAMILY_BUILD_LEGACY_CODECS)
5762
PUBLIC
5863
${CMAKE_CURRENT_SOURCE_DIR}/include
5964
)
65+
ironfamily_apply_dev_options(ironfamily_legacy_codecs)
6066

6167
find_package(OpenSSL REQUIRED)
6268
add_library(ironfamily_legacy_bjx STATIC
@@ -70,41 +76,51 @@ if(IRONFAMILY_BUILD_LEGACY_CODECS)
7076
PUBLIC
7177
OpenSSL::Crypto
7278
)
79+
ironfamily_apply_dev_options(ironfamily_legacy_bjx)
7380

7481
add_subdirectory(legacy/bjv-c)
7582
endif()
7683

7784
add_executable(crc_diagnostic tools/crc_diagnostic.c)
7885
target_link_libraries(crc_diagnostic PRIVATE IronFamily::ICFG)
86+
ironfamily_apply_dev_options(crc_diagnostic)
7987

8088
add_executable(test_crc tools/test_crc.c)
8189
target_link_libraries(test_crc PRIVATE IronFamily::ICFG)
90+
ironfamily_apply_dev_options(test_crc)
8291

8392
if(IRONFAMILY_BUILD_LEGACY_CODECS)
8493
add_executable(sanity_check tools/sanity_check.c)
8594
target_link_libraries(sanity_check PRIVATE ironfamily_legacy_codecs)
95+
ironfamily_apply_dev_options(sanity_check)
8696

8797
add_executable(icxs_diagnostic tools/icxs_diagnostic.c)
8898
target_link_libraries(icxs_diagnostic PRIVATE ironfamily_legacy_codecs)
99+
ironfamily_apply_dev_options(icxs_diagnostic)
89100

90101
add_executable(parity_icf2 tools/parity_icf2.c)
91102
target_link_libraries(parity_icf2 PRIVATE ironfamily_legacy_codecs)
103+
ironfamily_apply_dev_options(parity_icf2)
92104
endif()
93105

94106
if(NOT SKIP_TESTS)
95107
enable_testing()
96108

97109
add_executable(test_ironcfg tests/test_ironcfg.c)
98110
target_link_libraries(test_ironcfg PRIVATE IronFamily::ICFG)
111+
ironfamily_apply_dev_options(test_ironcfg)
99112

100113
add_executable(test_ironcfg_determinism tests/test_ironcfg_determinism.c)
101114
target_link_libraries(test_ironcfg_determinism PRIVATE IronFamily::ICFG)
115+
ironfamily_apply_dev_options(test_ironcfg_determinism)
102116

103117
add_executable(test_ilog_basic tests/test_ilog_basic.c)
104118
target_link_libraries(test_ilog_basic PRIVATE IronFamily::ILOG)
119+
ironfamily_apply_dev_options(test_ilog_basic)
105120

106121
add_executable(test_ilog_validation tests/test_ilog_validation.c)
107122
target_link_libraries(test_ilog_validation PRIVATE IronFamily::ILOG)
123+
ironfamily_apply_dev_options(test_ilog_validation)
108124

109125
add_test(NAME test_ironcfg COMMAND test_ironcfg)
110126
add_test(NAME test_ironcfg_determinism COMMAND test_ironcfg_determinism)
@@ -114,12 +130,15 @@ if(NOT SKIP_TESTS)
114130
if(IRONFAMILY_BUILD_LEGACY_IUPD_COMPAT)
115131
add_executable(test_iupd_basic tests/test_iupd_basic.c)
116132
target_link_libraries(test_iupd_basic PRIVATE ironfamily_iupd_compat)
133+
ironfamily_apply_dev_options(test_iupd_basic)
117134

118135
add_executable(test_iupd_validation tests/test_iupd_validation.c)
119136
target_link_libraries(test_iupd_validation PRIVATE ironfamily_iupd_compat)
137+
ironfamily_apply_dev_options(test_iupd_validation)
120138

121139
add_executable(test_iupd_apply tests/test_iupd_apply.c)
122140
target_link_libraries(test_iupd_apply PRIVATE ironfamily_iupd_compat)
141+
ironfamily_apply_dev_options(test_iupd_apply)
123142

124143
add_test(NAME test_iupd_basic COMMAND test_iupd_basic)
125144
add_test(NAME test_iupd_validation COMMAND test_iupd_validation)
@@ -129,24 +148,31 @@ if(NOT SKIP_TESTS)
129148
if(IRONFAMILY_BUILD_LEGACY_CODECS)
130149
add_executable(test_icxs_basic tests/test_icxs_basic.c)
131150
target_link_libraries(test_icxs_basic PRIVATE ironfamily_legacy_codecs)
151+
ironfamily_apply_dev_options(test_icxs_basic)
132152

133153
add_executable(test_icxs_golden tests/test_icxs_golden.c)
134154
target_link_libraries(test_icxs_golden PRIVATE ironfamily_legacy_codecs)
155+
ironfamily_apply_dev_options(test_icxs_golden)
135156

136157
add_executable(test_icfx_golden tests/test_icfx_golden.c)
137158
target_link_libraries(test_icfx_golden PRIVATE ironfamily_legacy_codecs)
159+
ironfamily_apply_dev_options(test_icfx_golden)
138160

139161
add_executable(test_icfx_vsp_indexed tests/test_icfx_vsp_indexed.c)
140162
target_link_libraries(test_icfx_vsp_indexed PRIVATE ironfamily_legacy_codecs)
163+
ironfamily_apply_dev_options(test_icfx_vsp_indexed)
141164

142165
add_executable(test_icf2_golden tests/test_icf2_golden.c)
143166
target_link_libraries(test_icf2_golden PRIVATE ironfamily_legacy_codecs)
167+
ironfamily_apply_dev_options(test_icf2_golden)
144168

145169
add_executable(test_bjx_basic tests/test_bjx_basic.c)
146170
target_link_libraries(test_bjx_basic PRIVATE ironfamily_legacy_bjx)
171+
ironfamily_apply_dev_options(test_bjx_basic)
147172

148173
add_executable(test_bjx_validation tests/test_bjx_validation.c)
149174
target_link_libraries(test_bjx_validation PRIVATE ironfamily_legacy_bjx)
175+
ironfamily_apply_dev_options(test_bjx_validation)
150176

151177
add_test(NAME test_icxs_basic COMMAND test_icxs_basic)
152178
add_test(NAME test_icxs_golden COMMAND test_icxs_golden WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/../..)

0 commit comments

Comments
 (0)