Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, interactions were mapped to invisible marker armor stands, which would also not let older clients interact.
This works best with cube-sized interactions, but is still compatible with other shapes for the most part as only the smallest dimension is considered. Potentially another entity could be used for vertical/biped-like hitboxes, but that would involve more tracking to respawn the entity.
Example:
26.3 3x3 interaction hitbox
1.19.2 slime (glowing for the demo)
Note that due to #1361, interactions of width and height both equal to 1.0 and response set to false will appear as a visible small slime because their data isn't sent by the server. Previously, they would appear as a visible big armor stand. Still, I included default size data for the invisible slime in case the issue is fixed in the future.