Merge pull request #24 from VictoriaMetrics/quotation-bug

fixed quotation bug for filters

Author: Amper

lib/logsql/select.go

@@ -3550,7 +3550,7 @@ func formatWildcard(val string) string {
 
 func needsQuoteForPattern(val string) bool {
 	for _, r := range val {
-		if r != '*' && r != '_' && r != '-' && r != ':' && r != '/' && r != '.' && (r < '0' || r > '9') && (r < 'A' || r > 'Z') && (r < 'a' || r > 'z') {
+		if r != '*' && r != '_' && r != '-' && r != ':' && (r < '0' || r > '9') && (r < 'A' || r > 'Z') && (r < 'a' || r > 'z') {
 			return true
 		}
 	}

lib/logsql/select_test.go

@@ -246,6 +246,11 @@ func TestToLogsQLSuccess(t *testing.T) {
 			sql:      "SELECT * FROM logs WHERE message LIKE '_foo'",
 			expected: "message:~\"^.foo$\"",
 		},
+		{
+			name:     "like suffix paths with dots",
+			sql:      "SELECT * FROM logs WHERE RequestPath LIKE '%/favicon.ico' OR RequestPath LIKE '%index.html'",
+			expected: "(RequestPath:\"*/favicon.ico\" OR RequestPath:\"*index.html\")",
+		},
 		{
 			name:     "compare fields equality",
 			sql:      "SELECT * FROM logs WHERE user_id = customer_id",
@@ -352,6 +357,11 @@ END AS severity FROM logs`,
 			sql:      "SELECT CASE level WHEN 'error' THEN 'critical' WHEN 'warn' THEN 'warning' ELSE 'info' END AS sev FROM logs",
 			expected: "* | format \"info\" as sev | format if (level:warn) \"warning\" as sev | format if (level:error) \"critical\" as sev | fields sev",
 		},
+		{
+			name:     "case expression with like wildcard",
+			sql:      "SELECT ResponseStatus, CASE WHEN RequestPath LIKE ('%/foo') THEN 'foo' ELSE 'unknown' END AS MyType FROM logs",
+			expected: "* | format \"unknown\" as MyType | format if (RequestPath:\"*/foo\") \"foo\" as MyType | fields ResponseStatus, MyType",
+		},
 		{
 			name:     "json value simple path with alias",
 			sql:      "SELECT JSON_VALUE(payload, '$.ip') AS ip FROM logs",