Repository navigation
Expand file tree
/
Copy pathMethodCallCheck.php
More file actions
183 lines (165 loc) · 5.27 KB
/
Copy pathMethodCallCheck.php
File metadata and controls
183 lines (165 loc) · 5.27 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
<?php declare(strict_types = 1);
namespace PHPStan\Rules\Methods;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr;
use PhpParser\Node\Identifier;
use PhpParser\Node\Name\FullyQualified;
use PHPStan\Analyser\NullsafeOperatorHelper;
use PHPStan\Analyser\Scope;
use PHPStan\DependencyInjection\AutowiredParameter;
use PHPStan\DependencyInjection\AutowiredService;
use PHPStan\Internal\SprintfHelper;
use PHPStan\Reflection\ExtendedMethodReflection;
use PHPStan\Reflection\ReflectionProvider;
use PHPStan\Rules\IdentifierRuleError;
use PHPStan\Rules\RuleErrorBuilder;
use PHPStan\Rules\RuleLevelHelper;
use PHPStan\Type\ErrorType;
use PHPStan\Type\StaticType;
use PHPStan\Type\Type;
use PHPStan\Type\VerbosityLevel;
use function count;
use function sprintf;
use function strtolower;
#[AutowiredService]
final class MethodCallCheck
{
public function __construct(
private ReflectionProvider $reflectionProvider,
private RuleLevelHelper $ruleLevelHelper,
#[AutowiredParameter]
private bool $checkFunctionNameCase,
#[AutowiredParameter]
private bool $reportMagicMethods,
)
{
}
/**
* @return array{list<IdentifierRuleError>, ExtendedMethodReflection|null}
*/
public function check(
Scope $scope,
string $methodName,
Expr $var,
Identifier|Expr $astName,
): array
{
$typeResult = $this->ruleLevelHelper->findTypeToCheck(
$scope,
NullsafeOperatorHelper::getNullsafeShortcircuitedExprRespectingScope($scope, $var),
sprintf('Call to method %s() on an unknown class %%s.', SprintfHelper::escapeFormatString($methodName)),
static fn (Type $type): bool => $type->canCallMethods()->yes() && $type->hasMethod($methodName)->yes(),
);
$type = $typeResult->getType();
if ($type instanceof ErrorType) {
return [$typeResult->getUnknownClassErrors(), null];
}
$typeForDescribe = $type;
if ($type instanceof StaticType) {
$typeForDescribe = $type->getStaticObjectType();
}
if (!$type->canCallMethods()->yes() || $type->isClassString()->yes()) {
return [
[
RuleErrorBuilder::message(sprintf(
'Cannot call method %s() on %s.',
$methodName,
$typeForDescribe->describe(VerbosityLevel::typeOnly()),
))
->line($astName->getStartLine())
->identifier('method.nonObject')
->build(),
],
null,
];
}
if (!$type->hasMethod($methodName)->yes()) {
$directClassNames = $typeResult->getReferencedClasses();
if (!$this->reportMagicMethods) {
foreach ($directClassNames as $className) {
if (!$this->reflectionProvider->hasClass($className)) {
continue;
}
$classReflection = $this->reflectionProvider->getClass($className);
if ($classReflection->hasNativeMethod('__call')) {
return [[], null];
}
}
}
if (count($directClassNames) === 1) {
$referencedClass = $directClassNames[0];
$methodClassReflection = $this->reflectionProvider->getClass($referencedClass);
$parentClassReflection = $methodClassReflection->getParentClass();
while ($parentClassReflection !== null) {
if ($parentClassReflection->hasMethod($methodName)) {
$methodReflection = $parentClassReflection->getMethod($methodName, $scope);
return [
[
RuleErrorBuilder::message(sprintf(
'Call to private method %s() of parent class %s.',
$methodReflection->getName(),
$parentClassReflection->getDisplayName(),
))
->line($astName->getStartLine())
->identifier('method.private')
->build(),
],
$methodReflection,
];
}
$parentClassReflection = $parentClassReflection->getParentClass();
}
}
if ($astName instanceof Expr) {
$methodExistsExpr = new Expr\FuncCall(new FullyQualified('method_exists'), [
new Arg($var),
new Arg($astName),
]);
if ($scope->getType($methodExistsExpr)->isTrue()->yes()) {
return [[], null];
}
}
return [
[
RuleErrorBuilder::message(sprintf(
'Call to an undefined method %s::%s().',
$typeForDescribe->describe(VerbosityLevel::typeOnly()),
$methodName,
))
->line($astName->getStartLine())
->identifier('method.notFound')
->build(),
],
null,
];
}
$methodReflection = $type->getMethod($methodName, $scope);
$declaringClass = $methodReflection->getDeclaringClass();
$messagesMethodName = SprintfHelper::escapeFormatString($declaringClass->getDisplayName() . '::' . $methodReflection->getName() . '()');
$errors = [];
if (!$scope->canCallMethod($methodReflection)) {
$errors[] = RuleErrorBuilder::message(sprintf(
'Call to %s method %s() of class %s.',
$methodReflection->isPrivate() ? 'private' : 'protected',
$methodReflection->getName(),
$declaringClass->getDisplayName(),
))
->line($astName->getStartLine())
->identifier(sprintf('method.%s', $methodReflection->isPrivate() ? 'private' : 'protected'))
->build();
}
if (
$this->checkFunctionNameCase
&& strtolower($methodReflection->getName()) === strtolower($methodName)
&& $methodReflection->getName() !== $methodName
) {
$errors[] = RuleErrorBuilder::message(
sprintf('Call to method %s with incorrect case: %s', $messagesMethodName, $methodName),
)
->line($astName->getStartLine())
->identifier('method.nameCase')
->build();
}
return [$errors, $methodReflection];
}
}