CPluginWindow::configureForQuickView() added; quick viewing images defaults to pixel perfect upscaling

Author: VioletGiraffe

doc/plugins.md

@@ -28,6 +28,8 @@ Plugin destructors must not use their proxy.
 Plugin windows use `CFileCommanderViewerPlugin::WindowPtr`, a unique pointer whose deleter is instantiated in the
 plugin module. Keep that type across the boundary so allocation and deletion occur in the same dynamic library.
 Full viewer windows opt into deletion on close; quick view retains the `WindowPtr` in `CPanelDisplayController`.
+A window embedded as quick view is never shown, so its menus and shortcuts are unreachable; `configureForQuickView()`
+is the hook for adapting to that.
 
 ## Proxy and tab visibility
 

file-commander-core/src/plugininterface/cpluginwindow.h

@@ -14,4 +14,7 @@ class PLUGIN_EXPORT CPluginWindow : public QMainWindow
 
 	[[nodiscard]] bool autoDeleteOnClose() const;
 	void setAutoDeleteOnClose(bool autoDelete);
+
+	// Called before the central widget is embedded into a file panel; the window itself is never shown.
+	virtual void configureForQuickView() {}
 };

plugins/viewer/imageviewer/src/cimageviewerwindow.cpp

@@ -50,7 +50,8 @@ CImageViewerWindow::CImageViewerWindow(CPluginProxy& proxy, QWidget* parent) noe
 	// Only this action is connected: the group unchecks it whenever the smooth one is picked.
 	connect(ui->actionPixelPreservingUpscaling, &QAction::toggled, this, [this](bool enabled) {
 		ui->_imageViewerWidget->setNearestNeighborUpscaling(enabled);
-		QSettings{}.setValue(SETTINGS_PIXEL_PRESERVING_UPSCALING, enabled);
+		if (!_quickViewMode) // Quick view forces the mode, so it must not overwrite the stored preference.
+			QSettings{}.setValue(SETTINGS_PIXEL_PRESERVING_UPSCALING, enabled);
 	});
 
 	// Checking the other action is what switches modes: unchecking the current one would leave the group with no selection.
@@ -114,6 +115,12 @@ bool CImageViewerWindow::displayImage(const QString& imagePath)
 	return true;
 }
 
+void CImageViewerWindow::configureForQuickView()
+{
+	_quickViewMode = true; // Must precede the check: the toggle handler reads it to skip the settings write.
+	ui->actionPixelPreservingUpscaling->setChecked(true);
+}
+
 void CImageViewerWindow::saveImageAs()
 {
 	const QImage& image = ui->_imageViewerWidget->sourceImage();

plugins/viewer/imageviewer/src/cimageviewerwindow.h

@@ -16,10 +16,13 @@ class CImageViewerWindow final : public CPluginWindow
 
 	bool displayImage(const QString& imagePath);
 
+	void configureForQuickView() override;
+
 private:
 	void saveImageAs();
 
 private:
 	QString _currentImagePath;
+	bool _quickViewMode = false;
 	Ui::CImageViewerWindow *ui;
 };

qt-app/src/panel/cpaneldisplaycontroller.cpp

@@ -53,6 +53,7 @@ void CPanelDisplayController::startQuickView(CFileCommanderViewerPlugin::WindowP
 	// Sanity check
 	assert_and_return_r(_panelStackedWidget && _panelStackedWidget->count() == 1, );
 	_quickViewWindow->setSizePolicy(QSizePolicy::Ignored, QSizePolicy::Ignored);
+	_quickViewWindow->configureForQuickView();
 	_panelStackedWidget->addWidget(_quickViewWindow->centralWidget());
 	_panelStackedWidget->setCurrentIndex(1);
 }