fix: dead links breaking check-links CI on every push/PR - #15
Merged
Conversation
Diagnosed from the failing "Check Links" workflow on PR #14 (already merged, non-blocking, but failing on every push/PR/weekly-schedule run since the workflow scans the whole repo, not just changed files). - mlc_config.json: add 403 and 429 to aliveStatusCodes. Several legitimate sites (datacamp.com, udemy.com, deeplearning.ai, madewithml.com, snowflake.com, data.cityofnewyork.us) block automated link checkers with 403 even though they're live for real visitors -- the standard fix for this class of false positive. - 4 Hugging Face dataset links (SST-2, AG News, SQuAD 2.0, MultiNLI) used old un-namespaced URLs; HF now requires the owner-namespaced path. Verified each new URL resolves before changing it. - Think Bayes moved from greenteapress.com/thinkbayes2/ to greenteapress.com/wp/think-bayes/. - dbt certification page (getdbt.com/dbt-learn/dbt-certification/) 404s; pointed at the still-live getdbt.com/dbt-learn instead. - RI DLT's WARN Act page moved off the warn.dlt.ri.gov subdomain (DNS failure, status 0) to dlt.ri.gov/employers/... -- verified via search, the new page is real and indexed even though it also 403s automated fetchers (covered by the aliveStatusCodes fix above). - 3 internal links (README.md x2, PROGRESS.md) pointed to 08_Career_Guide/salary_guide.md, which doesn't exist -- the file lives at 00_Overview/salary_guide.md. Looks like a file move that never got its inbound links updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Check Links" workflow scans the whole repo (not just changed files) on every push/PR/weekly schedule, and has been failing on pre-existing dead links unrelated to any specific PR. Fixes:
403/429added toaliveStatusCodes— several legitimate sites (datacamp.com, udemy.com, deeplearning.ai, madewithml.com, snowflake.com, data.cityofnewyork.us, dlt.ri.gov) block automated link checkers even though they're live for real visitors.greenteapress.com/wp/think-bayes/).dbt-learnpage).README.mdx2,PROGRESS.md) pointed to08_Career_Guide/salary_guide.md, which doesn't exist. The file actually lives at00_Overview/salary_guide.md— looks like a past file move that never got its inbound links updated.Test plan
00_Overview/salary_guide.mdis the real file pathcheck-linksworkflow passes on this PR🤖 Generated with Claude Code