Tests: disambiguate vault password toggle, stabilize health ping

Author: Vito416

desktop/src/renderer/App.tsx

@@ -9844,12 +9844,13 @@ function App() {
                     placeholder={pipVaultSnapshot?.mode === "password" ? "Enter vault password" : "Set a vault password"}
                     aria-label="Vault password"
                     aria-describedby="vault-password-help"
+                    data-testid="vault-password-input"
                   />
                   <button
                     type="button"
                     className="ghost small password-visibility-toggle"
                     onClick={() => setPipVaultPasswordVisible((visible) => !visible)}
-                    aria-label={`${pipVaultPasswordVisible ? "Hide" : "Show"} vault password`}
+                    aria-label="Toggle password visibility"
                   >
                     {pipVaultPasswordVisible ? "Hide" : "Show"}
                   </button>
@@ -9948,7 +9949,7 @@ function App() {
                           type="button"
                           className="ghost small password-visibility-toggle"
                           onClick={() => setVaultResetCurrentVisible((visible) => !visible)}
-                          aria-label={`${vaultResetCurrentVisible ? "Hide" : "Show"} current password`}
+                          aria-label="Toggle current password visibility"
                         >
                           {vaultResetCurrentVisible ? "Hide" : "Show"}
                         </button>
@@ -9971,7 +9972,7 @@ function App() {
                           type="button"
                           className="ghost small password-visibility-toggle"
                           onClick={() => setVaultResetNewVisible((visible) => !visible)}
-                          aria-label={`${vaultResetNewVisible ? "Hide" : "Show"} new password`}
+                          aria-label="Toggle new password visibility"
                         >
                           {vaultResetNewVisible ? "Hide" : "Show"}
                         </button>
@@ -9994,7 +9995,7 @@ function App() {
                           type="button"
                           className="ghost small password-visibility-toggle"
                           onClick={() => setVaultResetConfirmVisible((visible) => !visible)}
-                          aria-label={`${vaultResetConfirmVisible ? "Hide" : "Show"} confirmation`}
+                          aria-label="Toggle confirmation visibility"
                         >
                           {vaultResetConfirmVisible ? "Hide" : "Show"}
                         </button>
@@ -12454,7 +12455,7 @@ function App() {
                   type="button"
                   className="ghost small password-visibility-toggle"
                   onClick={() => setPipVaultPasswordVisible((visible) => !visible)}
-                  aria-label={`${pipVaultPasswordVisible ? "Hide" : "Show"} vault password`}
+                  aria-label="Toggle password visibility"
                 >
                   {pipVaultPasswordVisible ? "Hide" : "Show"}
                 </button>

desktop/tests/helpers.ts

@@ -327,7 +327,7 @@ export async function suppressPointerInterceptors(page: Page) {
   });
 }
 
-export async function goHome(page: Page, attempts = 3) {
+export async function goHome(page: Page, attempts = 6) {
   for (let i = 0; i < attempts; i += 1) {
     try {
       await page.goto("/");
@@ -339,7 +339,7 @@ export async function goHome(page: Page, attempts = 3) {
       return;
     } catch (err) {
       if (i === attempts - 1) throw err;
-      await page.waitForTimeout(500);
+      await page.waitForTimeout(1000);
     }
   }
 }

desktop/tests/smoke.spec.ts

@@ -218,7 +218,7 @@ test.describe("Desktop renderer smoke", () => {
     const treeFirst = page.locator(".tree-card").first();
     // Fallback for flaky drag: click the add button if nothing was dropped.
     if (!(await treeFirst.isVisible({ timeout: 2000 }).catch(() => false))) {
-      await gridCard.getByRole("button", { name: "Add" }).click();
+      await gridCard.getByRole("button", { name: "Add", exact: true }).click();
     }
 
     await expect(treeFirst).toBeVisible();
@@ -245,7 +245,7 @@ test.describe("Desktop renderer smoke", () => {
     const healthCard = page.locator(".health-card");
     await expect(healthCard).toBeVisible();
     await healthCard.getByRole("button", { name: "Expand" }).click();
-    await page.getByLabel("Health auto refresh cadence").selectOption("10");
+    await page.getByLabel("Health ping interval").selectOption("10");
     await healthCard.getByRole("button", { name: "Refresh" }).click();
 
     const schedulerRow = healthCard.locator(".health-row").filter({ hasText: "AO scheduler" });
@@ -260,7 +260,7 @@ test.describe("Desktop renderer smoke", () => {
     await page.waitForFunction(
       (target) => document.querySelectorAll(".health-events-list .health-event").length > target,
       initial,
-      { timeout: 5_000 },
+      { timeout: 15_000 },
     );
   });
 

desktop/tests/vault.spec.ts

@@ -13,7 +13,7 @@ const openVaultPanel = async (page: Page, options?: Parameters<typeof setupPage>
 };
 
 const unlockVault = async (page: Page) => {
-  await page.getByLabel("Vault password").fill(TEST_PASSWORD);
+  await page.getByTestId("vault-password-input").fill(TEST_PASSWORD);
   await page.getByTestId("vault-unlock-btn").click();
   await expect(page.locator(".pip-vault-header-actions")).toContainText("Unlocked");
 };
@@ -54,7 +54,7 @@ test.describe("Vault password and Argon2 UI", () => {
     );
 
     await openVaultPanel(page);
-    await page.getByLabel("Vault password").fill(TEST_PASSWORD);
+    await page.getByTestId("vault-password-input").fill(TEST_PASSWORD);
     await page.getByRole("button", { name: "Run breach check" }).click();
 
     const breachPill = page.locator(".pip-vault-breach .pill");