Conversation
- Add a centered overlaod for GetArrowShape - Add a before/after test for UI triangles - Move all drawn UI arrows/triangles to use GetArrowShape - Move bitmapped triangles to drawn scaled triangles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a bunch of UI elements that are basically "directional triangle in a BRect or centered on a BPoint with BSize" and every single one of them doesn't scale and uses its own math.
This unifies them so that they all use the same triangle math and the ones that are part of an element that scales now scale with it.
The test shows the original vs the unified version, so it can be tested at any scale. It's almost always < 1 pixel of difference, and even at larger scales it's only 1 or 2 and I can't see the difference in the actual UI, even when looking for it.