Skip to content

Commit 5d4076b

Browse files
author
settings-as-code-release
committed
docs(release): the publish lane serializes, it does not order
GitHub processes a lane's queued runs by the time each began waiting and promises no order, so the comment no longer claims arrival order; the verdict step's dist-tag compare under the lane is what keeps next and latest from moving backward. The actionlint ignore for the queue key names its retire condition.
1 parent 5c85623 commit 5d4076b

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

‎.github/actionlint.yaml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ paths:
1717
- 'file "lib/index\.js" does not exist'
1818
# The npm publish jobs in post-green.yml and update-release.yml share a
1919
# lane with `queue: max`, which keeps every queued publish instead of
20-
# the one pending job a lane holds by default; actionlint (1.7.12) does
21-
# not know the key yet. Drop this once it does.
20+
# the one pending job a lane holds by default; actionlint 1.7.12, the
21+
# newest release, does not know the key. Drop this once an actionlint
22+
# release lists `queue` under concurrency and the fleet step runs it.
2223
- 'unexpected key "queue" for "concurrency" section'

‎.github/workflows/post-green.yml‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,10 @@ jobs:
9999
# and update-release.yml's) take the same lane; no caller holds it. A lane
100100
# keeps ONE pending job by default and drops the rest, which would lose a
101101
# queued publish (a cancelled job here also fails the post-green call);
102-
# queue: max keeps every queued publish, in arrival order.
102+
# queue: max keeps every queued publish. The lane serializes, it does not
103+
# order: GitHub does not promise which queued run goes first, which is why
104+
# the verdict step reads the registry's dist-tags under the lane and skips
105+
# a version that is not newer than what next or latest already name.
103106
publish-next:
104107
if: github.repository == 'Vivswan/github-settings-as-code'
105108
concurrency:

0 commit comments

Comments
 (0)