Repository navigation
chore(deps): update the nine direct dependencies Dependabot cannot bump - #427
Merged
Merged
Conversation
…der lockfile v2
yaml 2.9.0 -> 2.9.1
@biomejs/biome 2.5.11 -> 2.5.15
@types/bun 1.4.0 -> 1.4.2
@types/node 26.4.1 -> 26.6.4
knip 6.34.0 -> 6.39.0
lefthook 2.1.12 -> 2.1.16
oxc-parser 0.147.0 -> 0.152.0
publint 0.3.24 -> 0.3.25
Dependabot's bun updater has rejected this repository's bun.lock since 2026-09-02 ("Unsupported bun.lock 'lockfileVersion' 2"), so none of these moved on their own. zod stays at 4.5.4: 4.6.x emits format: "includes" into the generated JSON Schema, which the published-schema tests refuse.
…oes not define zod 4.6.0 (#6554, "derive JSON Schema constraints by folding checks in the converter") copies every string_format check's name into the emitted format keyword, so z.string().includes() now publishes format: "includes", a name JSON Schema does not define and ajv ignores with a warning. The generator stripped two named formats (url, date/datetime) and let this third one through; it now deletes the keyword wherever zod emits it, which is the promise test/published-schema.test.ts already makes. Control: lib/settings.schema.json built under zod 4.5.4 and under 4.6.5 with this change are byte-identical (zero format keywords); under 4.6.5 without it the only difference is one added "format": "includes" line on AutolinkConfig.url_template. zod 4.5.4 -> 4.6.5 biome.json $schema 2.5.11 -> 2.5.15 (biome ci reported the mismatch as an info)
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The dependency, lockfile, configuration, and schema-generator changes are consistent and covered by existing schema tests.
Review effort: Balanced
Findings: None
What changed in this PR
Updates nine direct dependencies while preserving published settings-schema behavior after the Zod upgrade.
Changes:
- Updates runtime and development dependency pins.
- Regenerates the Bun lockfile.
- Removes all Zod-generated
formatkeywords from the published schema.
| File | Description |
|---|---|
package.json |
Updates nine dependency pins. |
bun.lock |
Locks updated direct and transitive dependencies. |
biome.json |
Aligns the schema URL with Biome 2.5.15. |
.github/scripts/gen-settings-schema.ts |
Generalizes removal of incompatible JSON Schema formats. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
File size check0 over a hard cap (fails), 33 warning(s).
Split the file, wrap the line, shorten or exempt the comment, or list the path in 5 managed file(s) skipped; repo-platform owns them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
How
formatkeyword, so.includes()emittedformat: "includes". The generator now drops everyformatkeyword with one rule, and the published schema stays byte-identical.Proof
Technical details
bun.lock(+100 -58) is generated and left out.test/published-schema.test.tspromises zeroformatkeywords, and thepatternzod emits beside each one is the real grammar.toJSONSchemaemitsformat: "includes", and by the same pathstarts_withandends_with, which JSON Schema does not define; no issue is filed yet.package.json,bun.lock,.github/scripts/gen-settings-schema.ts,biome.json.