Skip to content

test: house workflow and config tests beside the docs tests, and drop the root COVERAGE.md redirect - #485

Merged
Vivswan merged 1 commit into
mainfrom
test/docs-workflows-config
Oct 6, 2026
Merged

Vivswan merged 1 commit into
mainfrom
test/docs-workflows-config

Conversation

@Vivswan

@Vivswan Vivswan commented Oct 6, 2026

Copy link
Copy Markdown
Owner

What this changes

before                                   after
test/docs/checks-workflow.test.ts        test/workflows/checks-workflow.test.ts
test/docs/nightly-workflows.test.ts      test/workflows/nightly-workflows.test.ts
test/docs/npm-publish-workflows.test.ts  test/workflows/npm-publish-workflows.test.ts
test/docs/post-green-workflow.test.ts    test/workflows/post-green-workflow.test.ts
test/docs/repo-owned-workflows.test.ts   test/workflows/repo-owned-workflows.test.ts
test/docs/workflow-loader.ts             test/workflows/workflow-loader.ts
test/docs/head-ref.ts                    test/workflows/head-ref.ts
test/docs/biome-schema.test.ts           test/config/biome-schema.test.ts
test/docs/issue-templates.test.ts        test/config/issue-templates.test.ts
test/package-json.test.ts                test/config/package-json.test.ts
test/package-pins.test.ts                test/config/package-pins.test.ts
test/docs/<12 docs tests and helpers>    test/docs/<unchanged>
COVERAGE.md                              (deleted)

How

  • One git mv per file, so every move is a rename; inside a moved file only import specifiers changed.
  • Path comments repointed in release-pipeline.ts, test/e2e/constants.ts, and CONTRIBUTING.md.
  • Root COVERAGE.md deleted: a three-line redirect to docs/reference/coverage.md that nothing linked; its row left the guides link scan, and the mutation fixture that used it as an example link now uses a made-up name.

Proof

  • Tests: bun test test/docs test/workflows test/config 444 pass across 17 files, equal to main's bun test test/docs (432, 15 files) plus the two package tests (12, 2 files).
  • Gates: typecheck, biome, knip clean; git grep test/docs/ names only files that still exist; git grep COVERAGE.md prints nothing.
  • Review: codex rubber duck converged with no findings.
Technical details
  • Accounting: git diff --numstat -M origin/main...HEAD is 16 files, 18 insertions, 22 deletions, and 8 of the 11 renames carry a 0/0 diff.
  • Non-zero renames: test/config/package-json.test.ts (5/5, five import specifiers one level deeper), test/config/package-pins.test.ts (1/1, the same), test/workflows/workflow-loader.ts (1/1, its header names the workflow tests as its consumers).
  • test/docs/guides.test.ts (8/9): the COVERAGE.md scan row is deleted, the linksLeavingDocs comment and one test name now say CONTRIBUTING.md, and the mutation fixture's ../../COVERAGE.md links are ../../ROADMAP.md with its two expected lines updated.
  • Classification by what each file reads: test/workflows reads .github/workflows/*.yml, test/config reads biome.json, .github/ISSUE_TEMPLATE, and package.json, test/docs reads README.md, docs/, and the docs registry.
  • Files: test/workflows/{checks-workflow,nightly-workflows,npm-publish-workflows,post-green-workflow,repo-owned-workflows}.test.ts, test/workflows/{workflow-loader,head-ref}.ts, test/config/{biome-schema,issue-templates,package-json,package-pins}.test.ts, test/docs/guides.test.ts, test/e2e/constants.ts, .github/scripts/release-pipeline.ts, CONTRIBUTING.md, COVERAGE.md.

Copilot AI balanced review requested due to automatic review settings October 6, 2026 07:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The reorganized imports and references resolve correctly, with no stale coverage redirect references found.

Review effort: Balanced
Findings: None

What changed in this PR

This PR reorganizes workflow and configuration tests into dedicated directories and removes the obsolete root coverage redirect.

Changes:

  • Moves workflow tests and helpers into test/workflows.
  • Moves configuration tests into test/config, updating imports.
  • Deletes COVERAGE.md and updates related references and fixtures.
File Description
.github/​scripts/​release-pipeline.ts Updates the workflow-test path comment.
CONTRIBUTING.md Documents the new test directories.
COVERAGE.md Removes the unused redirect.
test/​config/​biome-schema.test.ts Moves the Biome configuration test.
test/​config/​issue-templates.test.ts Moves the issue-template test.
test/​config/​package-json.test.ts Moves the package test and updates imports.
test/​config/​package-pins.test.ts Moves the package-pin test and updates its import.
test/​docs/​guides.test.ts Removes coverage redirect scanning and updates fixtures.
test/​e2e/​constants.ts Updates the nightly-test path comment.
test/​workflows/​checks-workflow.test.ts Moves the checks workflow test.
test/​workflows/​head-ref.ts Moves the head-ref helper.
test/​workflows/​nightly-workflows.test.ts Moves nightly workflow tests.
test/​workflows/​npm-publish-workflows.test.ts Moves npm publishing workflow tests.
test/​workflows/​post-green-workflow.test.ts Moves post-green workflow tests.
test/​workflows/​repo-owned-workflows.test.ts Moves repository workflow tests.
test/​workflows/​workflow-loader.ts Moves the workflow loader and updates its description.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

File size check

0 over a hard cap (fails), 1 warning(s).

File Size Tier Cap
test/e2e/generators.ts 2641 lines warn 2560

Split the file, wrap the line, shorten or exempt the comment, or list the path in .file-size-allow.local with a # reason.

5 managed file(s) skipped; repo-platform owns them.

@Vivswan
Vivswan marked this pull request as ready for review October 6, 2026 07:47
@Vivswan
Vivswan merged commit f52055c into main Oct 6, 2026
28 checks passed
@Vivswan
Vivswan deleted the test/docs-workflows-config branch October 6, 2026 08:05
@Vivswan Vivswan added the merge-when-green Owner approved: merge once every gate is green label Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-green Owner approved: merge once every gate is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants