Repository navigation
test: house workflow and config tests beside the docs tests, and drop the root COVERAGE.md redirect - #485
Merged
Conversation
… the root COVERAGE.md redirect
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reorganized imports and references resolve correctly, with no stale coverage redirect references found.
Review effort: Balanced
Findings: None
What changed in this PR
This PR reorganizes workflow and configuration tests into dedicated directories and removes the obsolete root coverage redirect.
Changes:
- Moves workflow tests and helpers into
test/workflows. - Moves configuration tests into
test/config, updating imports. - Deletes
COVERAGE.mdand updates related references and fixtures.
| File | Description |
|---|---|
.github/scripts/release-pipeline.ts |
Updates the workflow-test path comment. |
CONTRIBUTING.md |
Documents the new test directories. |
COVERAGE.md |
Removes the unused redirect. |
test/config/biome-schema.test.ts |
Moves the Biome configuration test. |
test/config/issue-templates.test.ts |
Moves the issue-template test. |
test/config/package-json.test.ts |
Moves the package test and updates imports. |
test/config/package-pins.test.ts |
Moves the package-pin test and updates its import. |
test/docs/guides.test.ts |
Removes coverage redirect scanning and updates fixtures. |
test/e2e/constants.ts |
Updates the nightly-test path comment. |
test/workflows/checks-workflow.test.ts |
Moves the checks workflow test. |
test/workflows/head-ref.ts |
Moves the head-ref helper. |
test/workflows/nightly-workflows.test.ts |
Moves nightly workflow tests. |
test/workflows/npm-publish-workflows.test.ts |
Moves npm publishing workflow tests. |
test/workflows/post-green-workflow.test.ts |
Moves post-green workflow tests. |
test/workflows/repo-owned-workflows.test.ts |
Moves repository workflow tests. |
test/workflows/workflow-loader.ts |
Moves the workflow loader and updates its description. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
File size check0 over a hard cap (fails), 1 warning(s).
Split the file, wrap the line, shorten or exempt the comment, or list the path in 5 managed file(s) skipped; repo-platform owns them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
How
git mvper file, so every move is a rename; inside a moved file only import specifiers changed.release-pipeline.ts,test/e2e/constants.ts, andCONTRIBUTING.md.COVERAGE.mddeleted: a three-line redirect todocs/reference/coverage.mdthat nothing linked; its row left the guides link scan, and the mutation fixture that used it as an example link now uses a made-up name.Proof
bun test test/docs test/workflows test/config444 pass across 17 files, equal to main'sbun test test/docs(432, 15 files) plus the two package tests (12, 2 files).git grep test/docs/names only files that still exist;git grep COVERAGE.mdprints nothing.Technical details
git diff --numstat -M origin/main...HEADis 16 files, 18 insertions, 22 deletions, and 8 of the 11 renames carry a 0/0 diff.test/config/package-json.test.ts(5/5, five import specifiers one level deeper),test/config/package-pins.test.ts(1/1, the same),test/workflows/workflow-loader.ts(1/1, its header names the workflow tests as its consumers).test/docs/guides.test.ts(8/9): theCOVERAGE.mdscan row is deleted, thelinksLeavingDocscomment and one test name now sayCONTRIBUTING.md, and the mutation fixture's../../COVERAGE.mdlinks are../../ROADMAP.mdwith its two expected lines updated..github/workflows/*.yml, test/config readsbiome.json,.github/ISSUE_TEMPLATE, andpackage.json, test/docs readsREADME.md,docs/, and the docs registry.test/workflows/{checks-workflow,nightly-workflows,npm-publish-workflows,post-green-workflow,repo-owned-workflows}.test.ts,test/workflows/{workflow-loader,head-ref}.ts,test/config/{biome-schema,issue-templates,package-json,package-pins}.test.ts,test/docs/guides.test.ts,test/e2e/constants.ts,.github/scripts/release-pipeline.ts,CONTRIBUTING.md,COVERAGE.md.