Repository navigation
fix(inputs): refuse a bad repos list and misplaced filters when the inputs are parsed - #552
Merged
Merged
Conversation
…nputs are parsed A repos list mixing "*" with names, a bad entry in it, and discovery filters set where no "*" discovery runs were refused inside resolveTargets, after the repos directory was read, so an unreadable directory reported itself and hid the input error. parseConfig now refuses them in the multi and snapshot-dir arms, before any file is read; resolveTargets keeps the same refusals for a library caller that builds the config by hand.
There was a problem hiding this comment.
🟢 Approval recommended
The validation ordering is correct, existing error payloads are preserved, and both affected parsing paths are covered.
0 open findings
What changed in this PR
Moves target-input validation into config parsing so invalid repositories and misplaced filters fail before filesystem access.
Changes:
- Adds early validation for multi-repository and snapshot-directory inputs.
- Preserves runtime validation for manually constructed library configurations.
- Adds coverage for both parsing paths.
| File | Description |
|---|---|
src/flows/run-config.ts |
Validates target inputs during config parsing. |
src/flows/multi.ts |
Documents retained runtime validation. |
test/flows/inputs.test.ts |
Tests early refusal across both config arms. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
How
refuseTargetInputsparses the repos list and checks the discovery filters; the multi arm and the snapshot-dir arm ofparseConfigcall it after the input-conflict refusals and before the config is built.resolveTargetsproduced, so every rendered line is unchanged.resolveTargetsfor a library caller that buildsMultiConfigby hand, since the config types are public.Proof