chore(lint): adopt the fleet's TypeScript lint floor and sweep the tree to it by Vivswan · Pull Request #558 · Vivswan/github-settings-as-code

Vivswan · 2026-10-26T06:13:36Z

What this changes

$ bun run lint                      # biome 2.5.11: the fleet's floor over the repository's layer
before  Found 282 errors.           after  Checked 548 files in 259ms. No fixes applied.

$ check-member-shape                # the fleet's member-shape action
before  2120 finding(s).            after  Member shape check passed (0 file(s) not parsed, 0 managed and 4 generated file(s) skipped)

How

The floor is the fleet's managed biome.json, adopted byte for byte; the repository's layer and three reasoned per-path overrides live in biome.local.jsonc.
282 floor findings split or folded, none silenced: complexity, nested ternaries, negation-else, unused expressions, over-long functions, wide signatures.
2120 member-shape findings: one-line field comments, all-or-none per record, a blank line between commented members.
biome follows the fleet's pin (2.5.11), so lint, format, and the hook judge as the gate does.
zod 4.6.7 clears CVE-2023-54404, on which the fleet's trivy step fails every PR.
Library: Bun.JSONC.parse reads the JSONC layer; Bun.semver.order and isDeepStrictEqual replace two hand-rolled comparators.

Proof

Tests: 4583 unit tests pass, count unchanged; e2e 373/373.
Fleet gates, run locally with the platform's actions: biome 0, member-shape 0, line cap 0, typography 0.
Generated output: all 14 generated files match their generators.

Technical details

Overrides in biome.local.jsonc: src/index.ts and src/internal.ts (entry points exist to re-export), test/** (noExcessiveLinesPerFunction off: a test table is data), src/github/secret-scan.ts (complexity 30: normalizePlainData keeps one stack frame per nesting level on purpose).
Line accounting: source +6662 -4638, tests +8071 -5656, scripts +896 -563, 301 files. A floor sweep grows: each split adds a signature and a doc line, 748 blank lines separate commented members, and bare fields in half-commented records gained one-line comments. No test expectation changed; 202 test files before and after.
Behavior notes, each verified by differential runs against the pre-sweep sources: the list planner calls the lens hook once per entry (twice before, on the recreate path) and computes update bodies at plan time; orchestrate and snapshot derive their result from the outcome rows instead of three flags; injectMarkerLabel unwraps through listEntries; the schema URL's release-please marker is the block form x-release-please-start-major / x-release-please-end.
Warn-only: six record doc comments run 11 to 18 lines (the 10-line cap warns), having absorbed per-field notes under the one-line rule.
Recorded, not built: z.base64() for the deploy-key grammar (it feeds the published JSON Schema pattern, so likely no); library follow-ups on pre-existing code for estree-walker, unist-util-visit-parents, mdast-util-from-markdown, publint, Bun.Glob, and node:util.parseArgs.
The sync PR chore: sync repo-platform build 1416bea869dc #557 regenerates with no hold after this lands: biome.json then matches the platform's bytes and biome.local.jsonc exists.
Files: biome.{json,local.jsonc}, package.json, bun.lock, lint/{never-throw,rule-gate}.grit, test/config/biome-pin.test.ts, test/lint/fixture-lint.ts, and the swept files under src/, test/, and .github/scripts/.

BEGIN_COMMIT_OVERRIDE
chore(lint): adopt the fleet's TypeScript lint floor and sweep the tree to it

fix(deps): bump zod to 4.6.7, past CVE-2023-54404 that the fleet's trivy step fails on
END_COMMIT_OVERRIDE

… biome.local.jsonc The fleet now ships biome.json as a managed lint floor that extends the repo-owned biome.local.jsonc and applies last. This adopts that file ahead of the sync, byte for byte, so the floor gates this repository's own lint and the next sync records the file as its own write with no hold. The repository's layer moves into biome.local.jsonc unchanged: vcs, the excludes, the formatter, the recommended preset with the unused-import and import-restriction rules, the never-throw and rule-gate plugins, and their per-path overrides. Two overrides join it with their reasons beside them: the package entry points exist to re-export, and a test table is data, not a function body. @biomejs/biome follows the fleet's pin, the one biome the gate lints with, so lint, format, and the pre-commit hook judge the tree the same way. The schema test becomes a pin test: it refuses a devDependency the managed biome.json does not name, where it used to ask for a schema migration. The lint fixture copier walks `extends`, so the plugin tests still lint under the plugins, which now live in the local layer.

…ivy step fails on zod 4.6.5 carries the unbounded-array validation advisory, and the fleet's standard-checks job fails every pull request on it until a release at or past 4.6.6 is installed.

The fleet's TypeScript lint floor and the member-shape check now hold on test/e2e/mock. Behavior is unchanged: the mock's own tests and the section tests that drive it pass, and the e2e job proves the rest after merge. Splits, each pipeline stage now one named function above its caller: - routes.ts: runPipeline is admitRequest (wire checks, prefix strip), then serveCoreRoute (the four core paths, sharing contentsDenial), then the GraphQL leg, then serveSectionRequest (route match, check-mode barrier, resolveRestTarget, restFault, restDenial) and answerSectionRequest (body allowlist, handler, response guard, chaos hook). handleGraphqlRequest is parseGraphqlRequest, resolveGraphqlTarget, graphqlDenial, and graphqlResponse around the same barriers. Both exported signatures are unchanged. - server.ts: handleRequest is a module function over a ServerRun record holding the former closure state, split into parseIncoming, recordResult, writeResult, and isClientTeardown; the existing helpers moved above their callers unchanged. - core-paths.ts: handleIssueReport takes an IssueReportRequest and an IssueReportRun instead of nine parameters, and is serveMarkerLabelCreate and serveIssueRoute over one admitIssueRoute (target, fault hook, grade, in the section order) and the per-method listIssues, createIssue, patchIssue. - state.ts: buildState's clone-or-default ternaries are seededOr, keeping the truthiness test, and the nested labels ternary is seededLabels; applyRuleInputToLiteral's twin dispatch is applyTwinToLiteral and its two toggle cases are toggleNestedRule. Comments: every record field comment is one line directly above its field, members are blank-line separated, and the half-commented records (LoggedRequest, PipelineResult, MockResponse, HandlerContext, MockState, MultiRepoSpec, ServerOptions, MockHandle) are fully commented, while PipelineOptions and the handlerTestContext options are bare with their notes on the record or the function. Commented module constants stand alone with one-line comments; the longer notes moved into the doc comment of the function that acts on them. secrets.ts: the private half of the test keypair sits beside its one reader, because the secret scanner's allow directive must share the literal's line and the member-shape check refuses a trailing comment on a module constant.

…e member comments The fleet's biome floor (cognitive complexity 15, 80 lines per function, no nested ternary, no negation-else) and the platform's member-shape check both judge the 27 TypeScript files under .github/scripts. This brings every one of them to zero findings with no biome-ignore and no config override. Each function over the floor is split into named steps, with every early return, thrown message, and order of side effects kept: arch-lint's drawnEdges and requestExpression, endpoint-docs' resolveRest and resolveGraphql, gen-action-docs' gatedRead, yamlData and keyMapping, gen-docs' PageReader cursor, parseGaps, fenceFault and mapEntries, generated-regions' markerInside and a node-type table in scanMarkdown, schema-descriptions' sitesClaimedBy and describeSite, nightly-steps' noBumpReason, commitBump and openBumpPr, release-pipeline's publishOptions and reportConfirmed, anchor's readConfigText, parseConfigObject, commitAnchor, anchorAttempt, newestReleaseMerge and noMergeVerdict, npm's shownVerdict, and tags' alreadyPast. The nested ternaries in keyPath, literalModuleRequest and the config-kind message became if-chains, and npm's hand-written release comparator became Bun.semver.order. Field and constant comments are one line directly above their item, every field of a half-commented record is commented or the record's restating comments are gone, and commented members and constants stand alone with a blank line. A reason that needed more than a line moved into the enclosing doc comment: generated.ts's dependency order, gen-docs' sections page and mermaid node ids.

…int floor Brings src/sections/contract and src/sections/shared under the fleet's biome floor and the member-shape check with behavior unchanged: the covering unit tests, the typecheck, and both gates pass. Functions over the floor are split into named steps, each above its caller: - the list planner (shared/list/plan.ts): declaredWrites, indexedLive, liveConflictRefusal, undeclaredRemovals, undeclaredKeepNotes, matchedLive, bodyOf, facetDrift, createOp, compareWithLive, recreateOps, updateOps, entryGroup - failureFor: requestLines, denialAdvice, rejectionAdvice, and a FailureContext record for the optional context - plainData's walk: renderPath, rejectPayload, nonPlainAt, requirePlain - listGraphqlConnection: connectionOf, connectionPage, and the loop; listPages takes a PageWalk record in place of seven parameters - routedForms: formOf, neitherFormIssue - setupSection: setupEndpoints, setupPlan, setupSnapshot, declarableName - project's object case: projectObject - the nested ternaries in parseSealingKey's field defect and the setup language fold become early returns; the variable drift lines are pushed, not spliced Member comments become one line per field. A multi-sentence note moves into the record's own doc comment with its rows (EndpointDeclFields, SectionMeta, SectionModuleBase, SetupLanguages, ListSectionDeclFields), and a record whose comments only restated its names is left bare. ReadPhase and PermissionOverride name the read phase and the permission override once, so the EndpointDecl and GraphqlOpDecl arms carry no field comments. UpdateDecl is exported for the planner's shared record.

@ts-expect-error

…check The fleet's TypeScript lint floor and the member-shape check now gate every repository, and test/sections/ carried 44 floor findings and 153 member-shape findings. Its 49 files are at zero on both, with every test asserting what it asserted before. Member shape: a multi-line comment on a field or a module constant is one line; a half-commented record or const block is all-commented or bare; a blank line separates commented members and surrounds a commented module constant. A note too long for one line moved to where it still reads: a module header (teams, section-failure, the deploy_keys generators), the test body beside the assertion it explains (autolinks, milestones), the record's own doc comment (the branches schema cases), or trailing comments on the array entries it describes (raw-sibling's RAW_VALUES). Lint floor: - A compile-time-only expression statement carrying @ts-expect-error is prefixed with void, which keeps the directive anchored and drops no value silently. - Each nested ternary is a small function; the GraphQL status fold the fake and the branches test both spelled now lives once in fragment-fake.ts. - Each function over the cognitive-complexity cap is split into named steps above its caller: the fnmatch walk in the branches mock into a token reader and a bracket-class reader; the branches and environments fuzz generators per protection kind or per family, every RNG stream drawn in the same order; the fragment fake's REST and GraphQL routing and its denial; the refusal-message census's exclusion ladder, literal walk, and position walk; and the loop bodies of the registry, repository, docs-registry, and graphql-queries tests. The shared-route contract test compares the projected declarations with toEqual instead of serializing a hand-rolled key sort to a string; the assertion pins the same fact.

…nd the member-shape rules The 51 test files outside test/e2e and test/sections now clear the fleet's lint floor (36 findings) and the member-shape check (298 findings) with no suppressions and no behavior change: every assertion, every early return, and the order of every pushed problem line are as before. Functions too branched to read as a list of steps were split into named steps that sit above their callers: the claim reader in docs/claims.ts, the label and demonstration checks in docs/diagrams.test.ts, the refusal-table and link helpers in docs/guides.test.ts, the fenced-line generator in library/public-surface.test.ts, the schema verdict in schema-corpus.test.ts, the publisher, wiring, and push-boundary relations in the workflow tests, the repeated-flag and case-pair test bodies, and the Tree.mentions branches in engine/brand-mint.test.ts. Nested ternaries became if chains or a keyed table; a guard's else was unwrapped; the two test.each tables whose callbacks took more than six parameters now pass one object per row. Half-commented records and constant blocks are now commented throughout or bare; stacked and multi-line field comments became one line, the facts that needed more moving to the record's own doc comment or the file header; commented constants stand alone. Three route-factory arrow constants became function declarations, which is what ends a constant block for the check.

… the member comments The fleet's biome floor (cognitive complexity 15, 80 lines per function, no nested ternary, no negation before else) and the member-shape check now gate the repository, and the 45 section modules under src/sections/<key>/ carried 40 floor findings and 288 member-shape findings. Functions over the floor are split into named steps that sit above their callers, each one concept: the plan and snapshot handlers of branches, repository, collaborators, environments, teams, pages, interaction_limits, custom_properties, and secret_scanning_custom_patterns; the wildcard translation and actor lookups of the branches GraphQL writes; the branch-policy and pin planning of environments; and the PCRE tokenizer's walk. Nested ternaries became if chains or a keyed lookup, and negation-before-else branches were flipped. Behavior is unchanged: every early return, request order, op shape, and message is as before, and the covering unit tests pass untouched. Field and module-constant comments are one line directly above the item and carry only what the code cannot show; half-commented records and const blocks are completed or made bare, with a displaced fact moved to the record's doc, the function that uses it, or the module header. Separator comments that the checker read as a constant's stacked comment are gone. Line comments above exported declarations are one-line JSDoc so editor hovers keep them. Along the way the duplicated actor-name selection in branches reuses schema.ts's copiedActorName, and the actions claim-key comparator is node:util's isDeepStrictEqual.

…floor and the member-shape rules Every function over the complexity or line cap is split into named steps that sit above their caller, each one concept: the per-repository run (orchestrate.ts), the snapshot loop, the plan executor, the diff walk, the keyed union, the config parser, the fleet resolver, the command tree, the GraphQL call, the HTTP error classifier, the report-issue delivery, and the problem renderer, which now dispatches by code family. The nested ternaries became if chains or small helpers, the diff walk threads its position as one Site pair instead of two parameters, and the run and snapshot results are derived from the outcome rows instead of three mutable flags. Behavior is unchanged: the same outputs, side effects in the same order, the same early returns and BUG invariants. Every record's field comments are one line each with a blank line between members; a half-commented record is either commented in full or carries its notes in its own doc comment, and a run of constants is commented in full or split by a type. The schema URL's release-please marker takes the block form, since a trailing marker is a field comment the shape rules refuse. Left standing on purpose: normalizePlainData in src/github/secret-scan.ts stays over the complexity cap, because its own design keeps one frame per nesting level and a helper for the container body would halve the depth a payload may reach; a per-path override is proposed to the integrator instead.

…ts member comments The fleet's lint floor (cognitive complexity 15, no nested or negated ternaries) and the member-shape check flagged 56 and 205 findings across the e2e runner, generators, oracle, fuzz driver, and OpenAPI validator. Every split preserves behavior: runScenario into one function per assertion family and proof, with the artifact functions above it; childEnv into the mode wiring, a forwarded-inputs table, and the target wiring; genMultiScenario into per-target steps over a shared RunDraw, with a FORCED_ROLLS table for the battery forces; genMergeScenario's layer loop, feature walk, null and removal placements; the oracle's predictAtGrade, mergeTrees, unionKeyed, fold, boundary and discovery checks; the fuzz driver's main, flag parsing, and the multi, discovery, and merge verdicts; validateRequest and validateGraphql; the generator test bodies over the cap. Nested ternaries became if-chains or a keyed table, negated ternaries flipped. Member comments are one line each, every member of a half-commented record or constant block carries one, and commented constants stand alone. Rows that needed several lines moved onto the field or into the owning function's doc; the comments scenario.ts carried between its refine calls moved onto fields or were dropped where the message already said it. The generators and the oracle were byte-compared with the pre-split sources over 400 seeds under every force: 12,000 checks, no mismatch.

…raise one file's complexity bar with its reason Eleven one-line doc comments the sweep wrote ran past the fleet's 256 code-point line cap; each is cut to what the code cannot show. connectionPage keeps its path local, which the inlining had pushed over the cap with the message text unchanged. normalizePlainData in src/github/secret-scan.ts keeps one stack frame per nesting level on purpose, so biome.local.jsonc raises that file's complexity bar to 30 with the reason beside it, where a split would triplicate the scalar and container guards for no reading gain.

github-actions · 2026-10-26T06:14:09Z

File size check

0 over a hard cap (fails), 6 warning(s).

File	Size	Tier	Cap
`src/engine/diff.ts:56`	11 comment lines	warn	10
`src/github/api-error.ts:9`	11 comment lines	warn	10
`src/problem.ts:73`	18 comment lines	warn	10
`src/sections/contract/errors.ts:13`	11 comment lines	warn	10
`src/sections/contract/module.ts:55`	12 comment lines	warn	10
`src/sections/shared/list/decl.ts:265`	14 comment lines	warn	10

Split the file, wrap the line, shorten or exempt the comment, or list the path in .file-size-allow.local with a # reason.

5 managed file(s) skipped; repo-platform owns them.

Copilot

🔵 Needs a closer look

The supplied hunks cover only part of the described 301-file sweep, leaving broader behavioral and configuration changes requiring human review.

No open issues 🎉

What changed in this PR

This PR aligns GitHub Settings as Code with the fleet's TypeScript lint baseline, preparing it for the platform sync in #557. The supplied changes mostly standardize comments and member spacing, with focused helper extractions and tooling updates.

Changes:

Align Biome with the fleet's 2.5.11 pin and adapt lint fixtures to layered JSONC configuration.
Simplify conditionals and extract helpers across runtime code and tests; normalize documentation for member-shape checks.
Upgrade Zod to 4.6.7 and switch the snapshot schema URL to block-form release markers.

File	Description
`test/workflows/release-gate-workflow.test.ts`	Document workflow constants and helper.
`test/workflows/nightly-workflows.test.ts`	Normalize workflow-test helper comments.
`test/sections/webhooks/snapshot-row.ts`	Condense snapshot fixture documentation.
`test/sections/webhooks/mock.ts`	Normalize mock documentation.
`test/sections/webhooks/events.test.ts`	Standardize interface comments and spacing.
`test/sections/teams/teams.test.ts`	Move owner-gate explanation to module documentation.
`test/sections/teams/snapshot-row.ts`	Condense snapshot fixture documentation.
`test/sections/snapshot-roundtrip.ts`	Document and separate fixture fields.
`test/sections/snapshot-denial.test.ts`	Document denial-test constants.
`test/sections/shared/setup-section.test.ts`	Standardize field comments and mark type-check expressions with `void`.
`test/sections/shared/secrets-engine.test.ts`	Mark type-check expressions with `void`.
`test/sections/shared/secret-variable-schema.test.ts`	Document the variable-family selection.
`test/sections/shared/sealed-box.test.ts`	Document encoding helpers.
`test/sections/shared/list-section.test.ts`	Document fixtures and mark a type-check expression with `void`.
`test/sections/secret_scanning_custom_patterns/generators.ts`	Normalize generator-pool comments.
`test/sections/rulesets/snapshot-row.ts`	Condense snapshot fixture documentation.
`test/sections/rulesets/schema.test.ts`	Document the shared pattern fixture.
`test/sections/rulesets/mock.ts`	Condense mock-default documentation.
`test/sections/rulesets/generators.ts`	Condense parameter-fixture documentation.
`test/sections/repository/snapshot-row.ts`	Condense snapshot fixture documentation.
`test/sections/repository/repository.test.ts`	Extract toggle-response construction.
`test/sections/repository/mock.ts`	Reformat the REST projection comment.
`test/sections/raw-sibling.test.ts`	Move edge-case explanations beside fixture values.
`test/sections/plan-idempotence.test.ts`	Normalize synthetic-section documentation.
`test/sections/pages/mock.ts`	Separate create/update field-list comments.
`test/sections/milestones/mock.ts`	Document derived handlers.
`test/sections/milestones/milestones.test.ts`	Move pagination explanation beside its assertion.
`test/sections/milestones/generators.ts`	Document milestone generation.
`test/sections/graphql-queries.test.ts`	Extract rule-node field traversal.
`test/sections/environments/snapshot-row.ts`	Condense snapshot fixture documentation.
`test/sections/duplicate-live.test.ts`	Standardize fixture interface documentation.
`test/sections/docs-registry.test.ts`	Extract documentation-policy interpretation.
`test/sections/deploy_keys/schema.test.ts`	Document the valid-key fixture.
`test/sections/deploy_keys/mock.ts`	Normalize mock documentation.
`test/sections/deploy_keys/generators.ts`	Redistribute key-pool documentation.
`test/sections/deploy_keys/deploy_keys.test.ts`	Document key fixtures and planning helper.
`test/sections/contract/validate-hook.test.ts`	Normalize compile-time contract comments.
`test/sections/contract/section-failure.test.ts`	Move failure-order explanation to module documentation.
`test/sections/contract/owner-gate.test.ts`	Document gate-test constants and helpers.
`test/sections/contract/contract.test.ts`	Mark type checks with `void` and document case fields.
`test/sections/branches/snapshot-row.ts`	Condense snapshot fixture documentation.
`test/sections/branches/schema.test.ts`	Name the test-case interface and relocate its comment.
`test/sections/branches/branches.test.ts`	Reuse GraphQL status mapping and normalize type checks.
`test/sections/autolinks/generators.ts`	Normalize generator comments.
`test/sections/autolinks/autolinks.test.ts`	Move pagination explanation beside its assertion.
`test/scripts/step-fixture.ts`	Normalize step-result and environment documentation.
`test/scripts/relocated-region.ts`	Split a nested conditional.
`test/scripts/release-pipeline-build.test.ts`	Document the run URL fixture.
`test/scripts/nightly-steps.test.ts`	Standardize shim and fixture documentation.
`test/scripts/generated.test.ts`	Document generated-file discovery helpers.
`test/scripts/generated-regions.test.ts`	Document region fixtures.
`test/scripts/gen-inputs-table.test.ts`	Document page slices and regeneration helper.
`test/scripts/gen-docs.test.ts`	Invert a branch to avoid negated `else` logic.
`test/scripts/auto-format-steps.test.ts`	Document the origin-tip helper.
`test/scripts/auto-fix-steps.test.ts`	Document push fixtures and Git helpers.
`test/report/issue-report.test.ts`	Document report endpoint fixtures.
`test/published-schema.test.ts`	Extract recursive format-keyword collection.
`test/problem.test.ts`	Document message fixtures.
`test/private.test.ts`	Normalize privacy-boundary test documentation.
`test/mock-api.ts`	Document recorded-call fields and separate members.
`test/lint/rule-gate.test.ts`	Update configuration comments and document fixtures.
`test/lint/never-throw.test.ts`	Update configuration comments and document fixtures.
`test/lint/fixture-lint.ts`	Copy extended JSONC layers and their plugins into fixtures.
`test/io/capture.ts`	Document captured output channels.
`test/github/stub.ts`	Extract fetch URL normalization.
`test/github/list.test.ts`	Convert response helpers to function declarations.
`test/flows/merge-parity.test.ts`	Normalize merge-fixture documentation.
`test/fixtures/environment-parse-rules.ts`	Standardize fixture fields and comments.
`test/engine/layers.test.ts`	Redistribute shared-key fixture documentation.
`test/engine/check-purity.test.ts`	Condense fixture documentation.
`test/engine/canonical.test.ts`	Extract union-schema traversal.
`test/e2e/runner/apply-idempotence.ts`	Normalize recurring-write documentation.
`test/e2e/openapi/paths.ts`	Redistribute endpoint and staleness comments.
`test/e2e/mock/secrets.ts`	Move the test private key beside its reader.
`test/e2e/mock/request-body.ts`	Normalize undocumented-field comments and correct a comment path.
`test/e2e/mock/node-id.ts`	Condense global-node documentation.
`test/e2e/mock/list-fragment.ts`	Standardize list-mock interface comments.
`test/e2e/mock/handler-test-ctx.ts`	Move option explanations into parameter documentation.
`test/e2e/mock/graphql-pipeline.test.ts`	Reformat fixture documentation.
`test/e2e/mock/chaos.ts`	Condense fault-key documentation.
`test/e2e/generators/invalid-settings.ts`	Condense invalid-YAML fixture documentation.
`test/e2e/generators/gen-support.ts`	Standardize generator constants and interface comments.
`test/e2e/generators/fault-targets.ts`	Condense fault-target documentation.
`test/e2e/constants.ts`	Normalize harness constant documentation.
`test/docs/readme.test.ts`	Extract schema-modeline validation.
`test/docs/library-examples.test.ts`	Extract compiler-diagnostic collection.
`test/docs/coverage.test.ts`	Extract per-endpoint collision detection.
`test/discovery/exclude-pattern.test.ts`	Replace conditional dispatch with a fix table.
`test/count-nouns.test.ts`	Normalize scanner constant documentation.
`test/config/package-pins.test.ts`	Move pinning rationale to module documentation.
`test/config/biome-pin.test.ts`	Assert the dependency matches the fleet schema version.
`test/action/inputs.test.ts`	Document saved environment state.
`src/upstream-gaps/gap.ts`	Move gap-field explanation into interface documentation.
`src/types.ts`	Move layering-field explanation into interface documentation.
`src/sections/workflows/index.ts`	Share effective workflow-state normalization.
`src/sections/webhooks/schema.ts`	Normalize schema comments and spacing.
`src/sections/teams/schema.ts`	Condense slug-validation rationale.
`src/sections/shared/snapshot-helpers.ts`	Extract object-schema projection.
`src/sections/shared/setup-schema.ts`	Redistribute language-mapping documentation.
`src/sections/shared/secrets-and-variables/variables-engine.ts`	Simplify drift-line construction.
`src/sections/shared/secrets-and-variables/sealed-box.ts`	Normalize cryptographic constant comments.
`src/sections/shared/secrets-and-variables/repo-variables.ts`	Condense factory-map documentation.
`src/sections/shared/secrets-and-variables/repo-secrets.ts`	Redistribute factory and type-contract documentation.
`src/sections/shared/secrets-and-variables/named-scope.ts`	Standardize scope interface comments.
`src/sections/shared/secrets-and-variables/keyed-values.ts`	Document and separate family fields.
`src/sections/shared/schema-marks.ts`	Separate storage rationale from marking behavior.
`src/sections/shared/roles.ts`	Redistribute permission-validation documentation.
`src/sections/secret_scanning_custom_patterns/schema.ts`	Move delimiter rationale beside its error constant.
`src/sections/rulesets/rule-overrides.ts`	Remove a constant-level comment.
`src/sections/rulesets/index.ts`	Normalize live-shape and API-hint comments.
`src/sections/registry.ts`	Condense registry-boundary documentation.
`src/sections/pages/schema.ts`	Normalize nullable-schema documentation.
`src/sections/milestones/schema.ts`	Normalize due-date and identity comments.
`src/sections/milestones/index.ts`	Relocate branded-type documentation.
`src/sections/labels/schema.ts`	Consolidate comments and inline description-error text.
`src/sections/labels/index.ts`	Attach brand explanations to their types.
`src/sections/interaction_limits/schema.ts`	Redistribute validation documentation.
`src/sections/environments/schema.ts`	Normalize schema comments and spacing.
`src/sections/environments/protection-rules.ts`	Condense protection-rule documentation.
`src/sections/environments/nested.ts`	Standardize nested-resource interface comments.
`src/sections/deploy_keys/index.ts`	Relocate immutability and parsing comments.
`src/sections/contract/permissions.ts`	Normalize permission-map documentation.
`src/sections/contract/owner.ts`	Condense owner-probe cache documentation.
`src/sections/contract/live.ts`	Separate identity-brand and rendering documentation.
`src/sections/contract/keyed-list.ts`	Standardize keyed-list contract comments.
`src/sections/contract/drift.ts`	Separate documented option fields.
`src/sections/contract/docs.ts`	Normalize documentation-schema comments.
`src/sections/contract/declared.ts`	Remove a field-level comment.
`src/sections/code_scanning_default_setup/schema.ts`	Separate vocabulary declaration from its type check.
`src/sections/code_quality_setup/schema.ts`	Separate vocabulary declaration from its type check.
`src/sections/check_suite_preferences/schema.ts`	Remove redundant validation commentary.
`src/sections/branches/keys.ts`	Convert predicate helpers to function declarations.
`src/sections/branches/graphql-vocabulary.ts`	Normalize field-mapping documentation.
`src/sections/branches/endpoints.ts`	Relocate endpoint dictionary documentation.
`src/sections/autolinks/schema.ts`	Remove a constant-level comment.
`src/sections/actions/schema.ts`	Redistribute schema-validation documentation.
`src/schema.ts`	Normalize section-table and directive comments.
`src/report/delivery.ts`	Standardize channel and report-field documentation.
`src/report/composer.ts`	Move target-field explanation into interface documentation.
`src/private-open.ts`	Update the configuration path in a comment.
`src/io.ts`	Normalize masking comments and member spacing.
`src/github/trace-redaction.ts`	Condense regex documentation.
`src/github/slug.ts`	Normalize slug and brand comments.
`src/github/secret-scan.ts`	Replace a nested conditional in path rendering.
`src/github/scheduler.ts`	Document limiter groups and separate members.
`src/flows/summary.ts`	Extract snapshot-count summary wording.
`src/flows/snapshot.ts`	Use block release markers and normalize field comments.
`src/flows/library.ts`	Standardize public option documentation.
`src/flows/layers.ts`	Normalize folded-layer documentation.
`src/flows/input-readers.ts`	Document input-reader members.
`src/flows/execute.ts`	Document executor dependencies.
`src/flows/deliver.ts`	Standardize target-result and flow-option documentation.
`src/engine/secret-refs.ts`	Normalize secret-reference comments.
`src/engine/outcome.ts`	Condense outcome-order documentation.
`src/engine/directives.ts`	Normalize directive and wrapper documentation.
`src/discovery/targets.ts`	Redistribute target and slug comments.
`src/discovery/discover.ts`	Relocate filter and archived-reason documentation.
`src/cli/io.ts`	Standardize output-option comments and member spacing.
`src/cli/inputs.ts`	Normalize CLI input documentation.
`src/cli/init.ts`	Remove selected field-level comments.
`src/cli/actions.ts`	Separate documented runner fields.
`src/action/io.ts`	Condense annotation-map documentation.
`package.json`	Pin Biome to 2.5.11 and upgrade Zod to 4.6.7.
`lint/rule-gate.grit`	Update the configuration path in comments.
`lint/never-throw.grit`	Update the configuration path in comments.
`docs/reference/architecture.md`	Point lint exemption documentation to the local layer.
`.github/scripts/release-pipeline/git.ts`	Normalize identity and position comments.
`.github/scripts/release-pipeline/draft.ts`	Normalize release-output documentation.
`.github/scripts/post-green-steps.ts`	Condense output and push-probe comments.
`.github/scripts/package-smoke.ts`	Normalize consumer-fixture documentation.
`.github/scripts/lib/workflow-step.ts`	Document and separate execution options.
`.github/scripts/lib/schema-id.ts`	Condense schema-ID documentation.
`.github/scripts/lib/region-driver.ts`	Document generated regions and separate fields.
`.github/scripts/lib/count-word.ts`	Document the count-word table.
`.github/scripts/graduate-upstream-gaps.ts`	Separate documented graduation fields.
`.github/scripts/generated.ts`	Move dependency-order explanation to module documentation.
`.github/scripts/gen-settings-schema.ts`	Normalize schema-output comments.
`.github/scripts/gen-inputs-table.ts`	Document table-cell regex constants.
`.github/scripts/coverage-data.ts`	Normalize coverage-schema documentation.
`.github/scripts/check-compat-markers.ts`	Standardize scanner constants and option comments.
`.github/scripts/auto-fix-steps.ts`	Normalize generator-order and path comments.

_{Review effort: Balanced}

Vivswan added 11 commits October 26, 2026 00:41

fix(deps): bump zod to 4.6.7, past CVE-2023-54404 that the fleet's tr…

f66de39

…ivy step fails on zod 4.6.5 carries the unbounded-array validation advisory, and the fleet's standard-checks job fails every pull request on it until a release at or past 4.6.6 is installed.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 06:13

Vivswan mentioned this pull request Oct 26, 2026

chore: sync repo-platform build 1416bea869dc #557

Merged

github-actions Bot assigned Vivswan Oct 26, 2026

Copilot started reviewing on behalf of Vivswan October 26, 2026 06:14

View session

Copilot AI reviewed Oct 26, 2026

View reviewed changes

Vivswan marked this pull request as ready for review October 26, 2026 06:18

Vivswan merged commit c93494d into main Oct 26, 2026
31 checks passed

Vivswan deleted the chore/fleet-lint-floor branch October 26, 2026 06:40

Navigation Menu

Repository navigation

chore(lint): adopt the fleet's TypeScript lint floor and sweep the tree to it - #558

chore(lint): adopt the fleet's TypeScript lint floor and sweep the tree to it#558
Vivswan merged 11 commits into
mainfrom
chore/fleet-lint-floor

Vivswan commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Vivswan commented Oct 26, 2026

What this changes

How

Proof

Uh oh!

github-actions Bot commented Oct 26, 2026

File size check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants