Repository navigation
docs(comments): restore four facts the lint-floor sweep cut - #560
Merged
Merged
Conversation
An audit of the comment lines the sweep removed found four whose fact went with the wording: how the dry-run push judges the token (origin's receive-pack advertisement over the real push's channel), an example of an execution-phase read (the Codespaces sealing key), GitHub's 422 on both deployment-branch flags true and on both false, and the instruction that a fifth secret family breaking the <segment>_secrets naming must say so at the type that spells it. Each returns beside the thing it explains, one line where the member-shape rule wants one.
Contributor
File size check0 over a hard cap (fails), 6 warning(s).
Split the file, wrap the line, shorten or exempt the comment, or list the path in 5 managed file(s) skipped; repo-platform owns them. |
There was a problem hiding this comment.
🟢 Approval recommended
The changes only clarify existing behavior, and no unresolved defects were identified.
No open issues 🎉
What changed in this PR
Restores four explanatory facts removed during the lint-floor sweep, documenting existing behavior in the settings action and its workflow helpers. All changes are comment-only.
Changes:
- Clarifies how the dry-run push checks token access.
- Documents execution-only reads and valid deployment branch policy flags.
- Explains the naming constraint for repository secret families.
| File | Description |
|---|---|
src/sections/shared/secrets-and-variables/repo-secrets.ts |
Documents the secret-family naming constraint. |
src/sections/environments/schema.ts |
Explains rejected flag combinations and the unrestricted deployment setting. |
src/sections/contract/endpoints.ts |
Adds the Codespaces sealing key as an execution-only read example. |
.github/scripts/post-green-steps.ts |
Explains the dry-run push channel and probe ref. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this specifies
How
Proof
biome ciclean.