Skip to content

fix(settings): make API key and base URL actions discoverable - #276

Merged
Vizards merged 1 commit into
mainfrom
fix/270-settings-key-accessibility
Sep 14, 2026
Merged

Vizards merged 1 commit into
mainfrom
fix/270-settings-key-accessibility

Conversation

@Vizards

@Vizards Vizards commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Related issues

Closes #270

Problem

Users who find the Base URL setting still have to discover hidden reset controls or Command Palette commands to manage their API key. Missing-key chat errors also leave them without a direct configuration action.

Changes and scope

  • Add Reset to Default, Set / Update API Key, and Clear API Key links to the Base URL description in English and Chinese.
  • Always show a scope picker before resetting, including when only User Settings is available. Preview the current URL and reset result; remove only the selected override. Unset scopes are no-ops, and successful resets do not show notifications.
  • Confirm API key removal before invoking the existing SecretStorage deletion. Preserve the settings fallback and key lookup priority.
  • Add a Set API Key link to local missing-key chat errors through the existing URI action flow used by HTTP 401 errors.

Language model management and provider configuration migration remain out of scope. The commit and PR use fix(settings) for release-please; version files remain at 0.9.1.

Validation

  • Passed lint, formatting, TypeScript compilation, and VSIX packaging with Node 24.
  • Passed 37 local regression checks covering reset scopes, previews, cancellation, notifications, key-removal confirmation, and error links.
  • VS Code 1.137.0 extension-host checks covered empty windows (3), single-folder workspaces (13), and multi-root workspaces (14).
  • Chinese Settings flows were exercised during review. Signed-in Copilot Chat end-to-end behavior and a real Remote window were not exercised.

Final checks

  • I reviewed and can explain every change
  • I reviewed any user-facing text changes in both English and Chinese
  • This pull request contains no API keys, authorization headers, private prompts, private code, or unreviewed sensitive logs

Expose key management and scoped base URL reset from Settings, confirm key removal, and link missing-key chat errors to the existing configuration flow.

Closes #270
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T10:20:26.650921Z 7d58577 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved issues were identified in the reviewed changes.

Pull request overview

Improves discoverability of Base URL and API key actions in Settings and chat errors.

Changes:

  • Adds localized configuration links and scoped Base URL reset.
  • Confirms API key removal.
  • Adds actionable missing-key error links.
File summaries
File Summary
src/runtime/commands.ts Implements scoped Base URL reset.
src/provider/request.ts Uses actionable missing-key errors.
src/provider/index.ts Confirms API key removal.
src/i18n.ts Adds localized messages.
src/client/index.ts Exports the new error helper.
src/client/error/index.ts Adds missing-key action links.
package.nls.zh-cn.json Adds Chinese Settings links.
package.nls.json Adds English Settings links.
package.json Registers the command and Markdown description.
Review details
  • Files reviewed: 9/9 changed files
  • Comments generated: 0
  • Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Vizards
Vizards merged commit 0ccd91e into main Sep 14, 2026
2 checks passed
@Vizards
Vizards deleted the fix/270-settings-key-accessibility branch September 14, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Settings里设置项不足,比如更新API key

2 participants