Merge remote-tracking branch 'taranasus/feature/configurable-windowless-framerate'

Author: Voltstro

src/Packages/UnityWebBrowser/Runtime/Core/WebBrowserClient.cs

@@ -130,6 +130,15 @@ public Resolution Resolution
         /// </summary>
         [Tooltip("Proxy settings")] public ProxySettings proxySettings;
 
+        /// <summary>
+        ///     Target framerate for the browser rendering (1-60 FPS).
+        ///     Higher values provide smoother video playback but use more CPU.
+        /// </summary>
+        [Header("Performance")]
+        [Tooltip("Target framerate for browser rendering (1-60). Higher = smoother but more CPU.")]
+        [Range(1, 60)]
+        public int windowlessFrameRate = 30;
+
         /// <summary>
         ///     Enable or disable WebRTC
         /// </summary>
@@ -377,6 +386,9 @@ public void Init()
             argsBuilder.AppendArgument("width", resolution.Width);
             argsBuilder.AppendArgument("height", resolution.Height);
 
+            //Windowless frame rate
+            argsBuilder.AppendArgument("windowless-frame-rate", windowlessFrameRate);
+
             //Javascript
             argsBuilder.AppendArgument("javascript", javascript);
 

src/UnityWebBrowser.Engine.Cef/Main/Core/CefEngineControlsManager.cs

@@ -198,11 +198,16 @@ public void Init(ClientControlsActions clientControlsActions, EnginePopupManager
         //Create our CEF browser settings
         Color suppliedColor = launchArguments.BackgroundColor;
         CefColor backgroundColor = new(suppliedColor.A, suppliedColor.R, suppliedColor.G, suppliedColor.B);
+
+        //Clamp framerate to valid CEF range (1-60)
+        int frameRate = Math.Clamp(launchArguments.WindowlessFrameRate, 1, 60);
+
         CefBrowserSettings cefBrowserSettings = new()
         {
             BackgroundColor = backgroundColor,
             JavaScript = launchArguments.JavaScript ? CefState.Enabled : CefState.Disabled,
-            LocalStorage = launchArguments.LocalStorage ? CefState.Enabled : CefState.Disabled
+            LocalStorage = launchArguments.LocalStorage ? CefState.Enabled : CefState.Disabled,
+            WindowlessFrameRate = frameRate
         };
 
         mainLogger.LogDebug($"Starting CEF with these options:" +
@@ -212,6 +217,7 @@ public void Init(ClientControlsActions clientControlsActions, EnginePopupManager
                      $"\nBackgroundColor: {suppliedColor}" +
                      $"\nCache Path: {cachePath}" +
                      $"\nPopup Action: {launchArguments.PopupAction}" +
+                     $"\nWindowless Frame Rate: {frameRate}" +
                      $"\nLog Path: {launchArguments.LogPath.FullName}" +
                      $"\nLog Severity: {launchArguments.LogSeverity}");
         mainLogger.LogInformation($"Starting CEF client...");

src/VoltstroStudios.UnityWebBrowser.Engine.Shared/Core/LaunchArguments.cs

@@ -134,4 +134,10 @@ public class LaunchArguments
     ///     Start delay. Used for testing reasons.
     /// </summary>
     internal uint StartDelay { get; set; }
+
+    /// <summary>
+    ///     The target framerate for windowless rendering (1-60 FPS).
+    ///     Default is 30 FPS.
+    /// </summary>
+    public int WindowlessFrameRate { get; init; }
 }

src/VoltstroStudios.UnityWebBrowser.Engine.Shared/Core/LaunchArgumentsBinder.cs

@@ -24,6 +24,7 @@ internal class LaunchArgumentsBinder : BinderBase<LaunchArguments>
     private readonly Option<int> height;
 
     //General browser settings
+    private readonly Option<int> windowlessFrameRate;
     private readonly Option<bool> javaScript;
     private readonly Option<bool> webRtc;
     private readonly Option<bool> localStorage;
@@ -62,8 +63,9 @@ public LaunchArgumentsBinder(
         Option<string> initialUrl,
         Option<int> width,
         Option<int> height,
+        Option<int> windowlessFrameRate,
         Option<bool> javaScript,
-        Option<bool> webRtc, 
+        Option<bool> webRtc,
         Option<bool> localStorage,
         Option<int> remoteDebugging,
         Option<string[]> remoteDebuggingAllowedOrigins,
@@ -87,7 +89,8 @@ public LaunchArgumentsBinder(
         this.initialUrl = initialUrl;
         this.width = width;
         this.height = height;
-        
+
+        this.windowlessFrameRate = windowlessFrameRate;
         this.javaScript = javaScript;
         this.webRtc = webRtc;
         this.localStorage = localStorage;
@@ -126,6 +129,7 @@ protected override LaunchArguments GetBoundValue(BindingContext bindingContext)
             Width = bindingContext.ParseResult.GetValueForOption(width),
             Height = bindingContext.ParseResult.GetValueForOption(height),
 
+            WindowlessFrameRate = bindingContext.ParseResult.GetValueForOption(windowlessFrameRate),
             JavaScript = bindingContext.ParseResult.GetValueForOption(javaScript),
             WebRtc = bindingContext.ParseResult.GetValueForOption(webRtc),
             LocalStorage = bindingContext.ParseResult.GetValueForOption(localStorage),

src/VoltstroStudios.UnityWebBrowser.Engine.Shared/Core/LaunchArgumentsParser.cs

@@ -35,6 +35,9 @@ public LaunchArgumentsParser()
             "The height of the window");
 
         //General browser settings
+        Option<int> windowlessFrameRate = new("-windowless-frame-rate",
+            () => 30,
+            "Target framerate for windowless rendering (1-60). Default is 30.");
         Option<bool> javaScript = new("-javascript",
             () => true,
             "Enable or disable javascript");
@@ -117,6 +120,7 @@ public LaunchArgumentsParser()
             initialUrl,
             width,
             height,
+            windowlessFrameRate,
             javaScript,
             webRtc,
             localStorage,
@@ -147,6 +151,7 @@ public LaunchArgumentsParser()
             initialUrl,
             width,
             height,
+            windowlessFrameRate,
             javaScript,
             webRtc,
             localStorage,