Repository navigation
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
VrUaCom
marked this pull request as draft
October 2, 2026 19:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result
Adds HITS authoring and standalone Windows/Android preview applications in the Rengine repository. Previously HITS had native editing boundaries only; the new applications can open a loose HITS resource, display an untextured SCM overlay, pick surfaces/objects, change collision presets, import an SCM object and export rebuilt HITS.
Engine-owned components
hits::editor::Sessionfor geometry, stable IDs, raw flags, mesh groups, connected surfaces, merge, quads, rectangular boundaries, SCM mesh/object extraction, Undo/Redo and canonical spatial rebuild.hits::viewport::Controllerowns orthographic projection, camera, interpolated-depth picking, overlay and UI editing actions.DMCRengine::HitsEditorCoreis a portable CMake slice over the existing canonical ReaderCore, not another parser.ResourcePayloadboundary remain separate; GDS owns identity/evidence and PAC/NBZ reintegration.Platform preview
Validation
Portable preview compiles and passes on Linux. Four targeted tests pass against the full Rengine core: editor, viewport, frontend split and SCM import. Viewport regression covers binary SCM parsing/world transform, object picking/import, HITS reparse, nearest-depth picking, invalid-load preservation, canonical flag edits, Undo/Redo and bounds fallback. Address/undefined sanitizer test passes with leak detection disabled because the execution host uses ptrace. HITS Editor Preview run 37116413835 completed successfully on Ubuntu, Windows and Android; EXE and signed arm64 APK artifacts were produced. The general Rengine Build workflow is still running. Physical GUI/device tests have not been performed.
Limits and follow-up
This is a preview with an untextured orthographic CPU viewport, painter ordering and no BVH/z-buffer. It lacks PAC/NBZ UI, full gizmos, per-mesh SCM selection, raw-flags input and draw-quad UI. Move/boundary controls are Android-only. Export preserves the session's original baseline; process-death recovery is not implemented. Arbitrary authored geometry still needs original-game validation.
Native Reader's textured renderer, animation/effects and inspection modules have not all been migrated. The component ownership document records that reusable capabilities belong in Rengine; platform UX stays in standalone shells. PR remains draft pending physical Windows/Android tests.