Repository navigation
Conversation
…decisions (Zoo-Code-Org#1053) * fix(router-provider): fetch model metadata before context management decisions Router providers (zoo-gateway, kimi-code) that are auth-scoped skip the model cache entirely. On a fresh handler instance getModel() falls back to hardcoded defaults (e.g. 200k context window) because the real model list has not been fetched yet. Context management runs before createMessage() which is where fetchModel() normally happens, so condensing/truncation decisions use the wrong context window. Add ensureModelFetched() to RouterProvider that fetches once when the instance model map is empty. Call it in Task before context management so getModel() returns accurate metadata from the API. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(router-provider): single-flight ensureModelFetched and earlier call site Make ensureModelFetched single-flight so concurrent callers share a single in-flight fetch instead of firing duplicates. Move the call site before the cachedStreamingModel snapshot so the model info is accurate from the start of the streaming session, not just for context management. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(router-provider): address review feedback on fetch failures and double-fetch Make fetchModel single-flight and short-circuit once models are loaded so auth-scoped providers do not hit the models endpoint twice per request. Catch ensureModelFetched failures in Task via safeEnsureModelFetched so a metadata fetch error falls back to defaults instead of ending the task. Add reject-then-recover coverage and Task tests for the new call sites. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(test): spy private addToApiConversationHistory via TaskTestAccess vi.spyOn on the private method fails check-types; route it through the existing test access cast like the other private helpers. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
* chore: prepare v3.74.0 release * docs: announce Zoo Gateway in v3.74.0 README * docs: add Zoo Gateway announcement to localized v3.74.0 READMEs * fix: update Announcement spec to v3.74.0 and unindent README details close tag --------- Co-authored-by: Toray Altas <6816042+taltas@users.noreply.github.com> Co-authored-by: Roomote <roomote@roomote.dev>
* feat(webview): add OpenAI Codex speed selector * test(webview): add Codex speed selector visual coverage * test(webview): exclude visual fixture from unit coverage * test(webview): cover codex speed themes * test(webview): combine codex speed snapshots * fix(webview): label codex speed selector
…yService (Zoo-Code-Org#1070) * fix(telemetry): add circuit breaker and shutdown draining to TelemetryService * fix(telemetry): fix circuit breaker off-by-one, allSettled on shutdown * fix(telemetry): bound client.shutdown() phase, strengthen breaker test
Co-authored-by: Roomote <roomote@roomote.dev>
Co-authored-by: Roomote <roomote@roomote.dev>
Co-authored-by: Roomote <roomote@roomote.dev>
Co-authored-by: Roomote <roomote@roomote.dev>
…se telemetry (Zoo-Code-Org#1072) * fix(model-cache): dedupe concurrent fetches and throttle empty-response telemetry * fix(model-cache): preserve per-caller failure contract on shared in-flight fetch * refactor(model-cache): inline redundant refreshPromise IIFE in refreshModels * fix(model-cache): drop redundant telemetry gate, restore ordering comment, cover in-flight cleanup * test(model-cache): fix misleading auth-isolation comment, add same-token case
…ode-Org#1091) Co-authored-by: Roomote <roomote@roomote.dev>
…1092) Co-authored-by: Roomote <roomote@roomote.dev>
Co-authored-by: Roomote <roomote@roomote.dev>
…-Org#1094) * refactor: roll out stream helpers to anthropic vertex spec * refactor: remove unused anthropic vertex test import --------- Co-authored-by: Roomote <roomote@roomote.dev>
…e-Org#1095) * refactor: roll out stream helpers to lite llm and zai specs * refactor: address lite zai review findings --------- Co-authored-by: Roomote <roomote@roomote.dev>
…o-Code-Org#1102) Co-authored-by: Roomote <roomote@roomote.dev>
…oo-Code-Org#1103) Co-authored-by: Roomote <roomote@roomote.dev>
* fix: update Deepseek configurations * fix: restore the "disable" reasoning effort option * fix: remove deepseek-chat and deekseek-reasoner tests, or change them to deepseek-v4-flash or deepseek-v4-pro * fix: normalizeDeepSeekReasoningEffort * chore: add unit testing for normalizeDeepSeekReasoningEffort
…ecs (Zoo-Code-Org#1105) Co-authored-by: Roomote <roomote@roomote.dev>
…llments (Zoo-Code-Org#1071) * feat(telemetry): aggregate task completion telemetry with delta installments * fix(telemetry): prevent idle timer from breaking tests with fake timers * fix(telemetry): guard user message decrement and fix idle re-fire logic * fix(telemetry): cover all task launch paths for idle timer; fix pop guard * fix(telemetry): add startIdleTelemetryCheck stub to task-run-dispatch spec * fix(telemetry): advance baseline before emit to prevent double-reporting on throw * fix(telemetry): address PR 1071 review feedback
* refactor: extract managed binary installation infrastructure Refs Zoo-Code-Org#1055 * fix: address managed binary review feedback * fix: address managed binary review feedback * test: cover managed binary cleanup boundaries * fix: finalize managed binary download handling * test: mirror download stream close events --------- Co-authored-by: Naved Merchant <14171946+navedmerchant@users.noreply.github.com>
* refactor: extract managed binary installation infrastructure Refs Zoo-Code-Org#1055 * fix: address managed binary review feedback * feat: add destructive command guard binary service Refs Zoo-Code-Org#1056 * test: strengthen DCG binary service coverage * fix: address DCG service review feedback * fix: address managed binary review feedback * test: cover managed binary cleanup boundaries * fix: address DCG binary service feedback * fix: finalize managed binary download handling * test: mirror download stream close events --------- Co-authored-by: Naved Merchant <14171946+navedmerchant@users.noreply.github.com>
* refactor: extract managed binary installation infrastructure Refs Zoo-Code-Org#1055 * fix: address managed binary review feedback * feat: add destructive command guard binary service Refs Zoo-Code-Org#1056 * test: strengthen DCG binary service coverage * feat: add persisted destructive command guard setting Refs Zoo-Code-Org#1057 * fix: clarify DCG enablement errors * test: cover DCG global setting schema * test: raise DCG setting patch coverage * fix: address DCG service review feedback * fix: address managed binary review feedback * test: cover managed binary cleanup boundaries * fix: address DCG binary service feedback * fix: finalize managed binary download handling * test: mirror download stream close events --------- Co-authored-by: Naved Merchant <14171946+navedmerchant@users.noreply.github.com> Co-authored-by: edelauna <54631123+edelauna@users.noreply.github.com>
* refactor: extract managed binary installation infrastructure Refs Zoo-Code-Org#1055 * fix: address managed binary review feedback * feat: add destructive command guard binary service Refs Zoo-Code-Org#1056 * test: strengthen DCG binary service coverage * feat: add persisted destructive command guard setting Refs Zoo-Code-Org#1057 * fix: clarify DCG enablement errors * test: cover DCG global setting schema * feat: integrate destructive command guard with auto-approval Closes Zoo-Code-Org#1058 Completes Zoo-Code-Org#1049 * test: document DCG auto-approval precedence * test: raise DCG setting patch coverage * fix: address DCG service review feedback * fix: address managed binary review feedback * test: cover managed binary cleanup boundaries * fix: address DCG binary service feedback * fix: address DCG integration feedback * fix: finalize managed binary download handling * test: mirror download stream close events * test: mirror download stream close events --------- Co-authored-by: Naved Merchant <14171946+navedmerchant@users.noreply.github.com> Co-authored-by: edelauna <54631123+edelauna@users.noreply.github.com>
…oo-Code-Org#1005) * feat(webview): add batchNearby utility for smarter tool ask batching Replace batchConsecutive with batchNearby in ChatView.tsx to allow merging same-type tool asks even when separated by ignorable messages (api_req_started/finished, empty text rows, reasoning). Semantic boundaries (user_feedback, visible text, completion_result, checkpoint_saved, error) stop the merge, preserving correct ordering. This fixes UX where models like qwen insert API request rows between tool calls, causing UI to show multiple 'Zoo wants to read this file' instead of a single batched prompt. * fix: batchNearby restores dropped ignorable items when bridge fails When a single target is followed by ignorable messages and then a boundary (no second target found), the original code silently dropped those ignorable items — contradicting the documented contract that all items are preserved in-order. Fix: track skipped ignorable items in pendingIgnorable, flush them after the batch result so they're never lost. When bridge succeeds (second target found), pending items are consumed into the synthesized batch as expected. * fix(chat): keep nearby batching boundaries in sync * fix(chat): share tool batching predicates --------- Co-authored-by: T <taltas@users.noreply.github.com> Co-authored-by: Eason Liang <easonliang28@gmail.com>
…ode-Org#1145) * fix: wait for foreground terminal command completion * test: preserve terminal provider context in completion test --------- Co-authored-by: Naved Merchant <14171946+navedmerchant@users.noreply.github.com> Co-authored-by: Naved Merchant <naved.merchant@gmail.com>
…o-Code-Org#1085) * fix(task): isolate task configuration from focused provider state * fix(task): scope profile updates to the focused task * test(task): strengthen task configuration isolation coverage * fix(task): persist selected provider profile on task
…-Org#1087) * fix(provider): isolate profile mutations from focused tasks * test(e2e): restore provider profile after cross-profile subtasks * fix(provider): recover timed-out profile mutations * test(provider): target queued mode switches explicitly * fix(provider): preserve queued profile mutation ordering * fix(provider): abort timed-out profile mutations before state writes --------- Co-authored-by: Naved Merchant <naved.merchant@gmail.com>
Co-authored-by: Roomote <roomote@roomote.dev>
) * refactor(code-index): extract single-file preparation * refactor(code-index): use constructor-injected file preparation class * refactor(code-index): separate file preparation dependencies * test(code-index): cover platform-specific file preparation paths * refactor(code-index): inject preparation service objects * refactor(code-index): simplify file preparation stages * fix(code-index): decode prepared file bytes as UTF-8 * test(code-index): assert preparation receiver identity
…ode-Org#695) (Zoo-Code-Org#700) * fix: streaming tool-call argument loss in NativeToolCallParser (Zoo-Code-Org#695) * chore: remove agent-generated changeset file per policy * test: add direct coverage for finalizeRawChunks() in NativeToolCallParser * fix: address PR Zoo-Code-Org#700 review feedback for tool-call streaming reassembly - Guard finalize results with not.toBeNull() in parallel-index and single-chunk tests so a null result fails instead of passing silently - Add reverse-ordering test (name -> buffered args -> id) covering the start-gate id requirement - Use name !== undefined recording plus a nameSeen flag in the start-gate as a defensive guard against an empty tool name - Clear rawChunkTracker in processFinishReason so finalizeRawChunks is a safe no-op; add a regression test asserting no double tool_call_end - Remove unrelated ask_followup_question wording change from PR scope - Remove prs/fix-toolcall-dropped-leading-deltas.md from the diff * fix: handle provider-emitted tool_call_end chunks during streaming Task.ts had no stream-level case for tool_call_end, so end chunks emitted by providers on finish_reason: "tool_calls" were silently dropped; tool calls only finalized at stream end via finalizeRawChunks(). Add a tool_call_end case so tools finalize and present during streaming, and extract the triplicated finalize/present logic into a shared idempotent helper. Correct the NativeToolCallParser test drive helper to finalize via finalizeRawChunks() (matching production) instead of processFinishReason(). * test: cover Task.finalizeStreamingToolCallById streaming finalization Add a focused spec that invokes the real Task.prototype.finalizeStreamingToolCallById via .call() with mocked presentAssistantMessage and NativeToolCallParser, covering the success, null-finalize (malformed JSON), untracked-id no-op, and idempotent re-finalize paths. Closes the codecov/patch gap on the new helper. * test: adapt tool-call streaming coverage to scoped parser state * test: type finalizeStreamingToolCallById fixtures as FinalizeStub * fix(task): defer finalized tool execution until history persists * refactor(parser): cut PR Zoo-Code-Org#700 to parser-only streaming scope Restore Task.ts persistence coordination and stream-time tool_call_end finalization to main; retain only the Zoo-Code-Org#695 parser fixes with their focused tests. --------- Co-authored-by: Elliott de Launay <edelauna@gmail.com>
…ent (Zoo-Code-Org#1606) * fix(vscode-lm): trim oversized tool_results to fit the model context window Copilot's backend trims an over-window request without preserving tool_use/tool_result pairing, orphaning a tool_result and triggering a 400. Shrink oversized tool_result payloads middle-out on our side, and refuse a request that still cannot fit rather than send one we know is over-window. * fix(vscode-lm): restore em-dashes mangled during extraction * fix(vscode-lm): keep middleOutTruncate within maxChars for small limits * fix(vscode-lm): mark the over-budget refusal as a context-window error * fix(vscode-lm): remove unreachable truncation guard and strengthen tests Delete the target >= text.length guard, which cannot be reached. Move the middleOutTruncate JSDoc onto the function it documents. Make the fits-budget test actually assert no trimming, and assert the refusal error's reported character count so it fails if trimming is skipped. * refactor(vscode-lm): cache tool_result text, return remaining chars, share 400 constant F6: derive each tool_result's text once into a Map before sorting, removing the repeated filter+map+join in the comparator and the truncation loop. F7: return the running total as remainingChars so createMessage reuses it instead of re-scanning via estimateMessagesChars; a new test asserts the returned total matches an independent re-scan across eight paths. F8: export CONTEXT_WINDOW_EXCEEDED_STATUS from context-error-handling and use it on both the detector and the local over-budget refusal. * test(vscode-lm): widen raw-budget refusal margin to 1999 chars --------- Co-authored-by: Bertan Ari <bertanari@microsoft.com> Co-authored-by: edelauna <54631123+edelauna@users.noreply.github.com>
…e-Org#1778) Extract workspace enablement coordination and status publication, expose full workspace scopes, and replace direct manager access in webview handlers. Add toggle guard and default coverage, sync upstream main, and align the CodeRabbit test with upstream chat access policy. Refs Zoo-Code-Org#1594
* feat(openai): support GPT-6.1 Sol in native and Codex providers * fix(openai): use supported 872K Codex context for GPT-6.1 Sol * fix(build): rebuild dependents when dependency packages change --------- Co-authored-by: Elliott de Launay <edelauna@gmail.com>
…-Code-Org#1873) * feat: add community-approved advisory label for community code approvals (Zoo-Code-Org#1872) * test(workflow): cover community-approved label removal paths --------- Co-authored-by: @taltas <6816042+taltas@users.noreply.github.com> Co-authored-by: Elliott de Launay <edelauna@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…olution) (Zoo-Code-Org#1589) * fix(dev): use 127.0.0.1 instead of localhost for dev server to avoid IPv6 resolution issues * test(webview): assert HMR html targets the 127.0.0.1 dev server * test(webview): assert the dev-server probe targets the 127.0.0.1 health-check URL * test(webview): isolate the dev-server probe test from a stray .vite-port file and restore env in finally --------- Co-authored-by: hnbdr <hnbdr@users.noreply.github.com>
* fix(webview): batch repeated tool preambles Amp-Thread-ID: https://ampcode.com/threads/T-01a0aa02-b6de-7763-97b8-1650ea4b46da * fix(webview): preserve batching boundaries --------- Co-authored-by: Amp <amp@ampcode.com>
…ol-policy layer (Zoo-Code-Org#1724) * fix(mcp): validate native mcp_tool_use dispatch through the shared tool-policy layer The native mcp_tool_use arm now consults the shared validateToolUse layer (under the canonical use_mcp_tool name) before dispatching to the handler. A disabledTools or excludedTools entry naming use_mcp_tool is rejected at dispatch with a structured is_error tool_result and the server method is never invoked; the enabled path is unchanged. Issue: Zoo-Code-Org#1646 * test(mcp): cover native mcp validation guard branches; drop redundant optional chains Three tests pin the guard's deref-undefined fallback, the includedTools alias-map resolution, and the id-omitted rejection branch, taking patch coverage of the changed window from 78.9% to 100% and clearing codecov/patch. The modelInfo and toolError simplifications are behavior-preserving per the typed contracts (non-nullable getModel() return; toolError returns string). Mutation-diff survivor forms are eliminated: all 15 mutants in the regression map are killed. Issue: Zoo-Code-Org#1646
…oo-Code-Org#1852) `addToClineMessages` called `flushPostStateToWebviewThrottled()` for every message with `partial === true`. With lodash debounce configured `{ leading: true, trailing: true }`, a flush issued right after a leading-edge invocation has no pending trailing invocation to run, so it only cancels the trailing timer. The next call then hits the leading edge again and posts immediately, so the debounce never coalesced anything on the streaming path. Measured against lodash.debounce 4.0.8 with the provider's own settings (500ms wait, 1000ms maxWait), 20 messages arriving 100ms apart produced: with the interleaved flush: 20 full-state posts without it: 3 full-state posts Because `requiresImmediateState` matched every partial first chunk, throttling was effectively inert for tool-heavy tasks and the gray-screen OOM that Zoo-Code-Org#1078 set out to fix remained reproducible at high message counts. Drop `partial` from the condition. Partial `say` messages are safe on the throttled path: the trailing/maxWait post carries the message's current text, so a `messageUpdated` dropped for a `ts` the webview does not know yet is superseded rather than lost. Partial asks are unaffected — `Task#ask` adds them without `isAnswered`, so they keep flushing through the ask clause and retain the ordering guarantee unanswered asks depend on. The existing suite could not catch this: every Task-level test mocks the provider, so it asserted that flush was *called* rather than that state posts were actually coalesced. Retarget the partial-message test at the new contract and add a characterization test in ClineProvider.spec.ts that pins the debounce semantics against the real timer.
* chore(deps): update dependency mocha to v11.8.0 * fix(deps): override mocha diff to 8.0.4 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Elliott de Launay <edelauna@gmail.com>
* fix(opencode-go): add DeepSeek V4.1 Flash metadata Amp-Thread-ID: https://ampcode.com/threads/T-01a0aa02-b6de-7763-97b8-1650ea4b46da * fix(opencode-go): enable DeepSeek Flash vision * test(api): pin DeepSeek V4.1 metadata --------- Co-authored-by: Amp <amp@ampcode.com>
…#1726) * fix(lifecycle): stop rejected subtask replay loops * fix(lifecycle): preserve pending actions in model checks * fix(lifecycle): preserve replacement pending actions * fix(lifecycle): honor cross-host task deletion * fix(lifecycle): preserve completed task records * fix(lifecycle): prevent rejected subtask replay on restart and serialize task deletion with writes * fix(persistence): serialize task deletion with history writes * fix(lifecycle): scope branch to exact-action settlement and merge main Drop the broad deletion-serialization work: the shared task guard (taskIoGuard, taskPathSafety, fileLock), safeWriteJson refactors, storage path policy, and writer coordination across messages, tools, and webview handlers. Keep only the rejected create_subtask exact-action settlement: the LifecycleTransitionError reducer, the TaskHistoryStore.clearPendingActionIfMatching compare-and-clear, typed rejection handling in ClineProvider, pre-replay settlement in Task, and their focused tests, model witnesses, and architecture documentation. Merge local main to carry the Zoo-Code-Org#1678 repeated-cancel behavior. * fix(lifecycle): handle authoritative settlement results * test(lifecycle): cover settlement lock errors * fix(lifecycle): harden rejected action settlement * fix: narrow failed history cleanup * fix: preserve atomic rollback backup * fix: hold advisory lock during task history deletion TaskHistoryStore.delete and deleteMany unlinked history_item.json outside the per-file advisory lock. A delete that landed between the settlement read and commit let clearPendingActionIfMatching recreate the deleted record. Extract acquireFileLock and withFileLock into src/utils/fileLock.ts and route safeWriteJson through the same helper, so writes and deletes serialize on one lock implementation with no nested acquisition. Unlink now runs under withFileLock. Cache and mtime entries change only after the file is absent or deletion succeeds, so a failed delete keeps the cached record and skips the write-through callback. Add a real-filesystem test that pauses settlement after its disk read, starts a deletion from another store, and verifies serialization, no recreation of history_item.json, and fail-closed settlement. Add unit tests for unlink and lock failure cache semantics. * test: provide getStorageBasePath in provider storage mock TaskHistoryStore.deleteTaskFile resolves the task file path before the best-effort unlink block, so a storage mock without getStorageBasePath now fails the delete call instead of being swallowed. Add the export to the ClineProvider storage mock so the main-branch regression test runs the real delete semantics. * fix: flush write-through on partial deleteMany and reject on lock compromise - deleteMany now awaits the write-through callback with the current cache when a later deletion fails after an earlier success, so persisted globalState.taskHistory does not keep already-deleted tasks. The original deletion error stays the rejection, and a failed flush is logged without masking it. - acquireFileLock records a lock compromise instead of throwing from the proper-lockfile renewal timer. The release rejects with the recorded compromise error, and withFileLock and safeWriteJson reject a successful operation whose lock was compromised. Operation errors keep precedence. - Add regression tests for both behaviors. * test: assert partial-failure write-through call and release error details - The partial write-through failure test now asserts the flush call, its item payload, and the logged write-through error next to the original unlink rejection. - The unrelated release error test asserts the exact log arguments and error object. * fix(lifecycle): narrow PR to rejected-action settlement and dedupe Gemini call IDs Remove deletion coordination, the generic file-lock wrapper, atomicReplace backup machinery, lock-compromise propagation, and the partial deleteMany write-through. Issue Zoo-Code-Org#1714 requires none of them. Restore base safeWriteJson behavior and base store deletion semantics, and restore the pre-existing real-lock write-barrier tests. Reimplement clearPendingActionIfMatching on the base safeWriteJson merge callback. The merge callback reads the persisted record under the per-file lock, a throwing merge writes nothing, so a record deleted by another host still fails settlement closed without recreation. Add a request-unique component to synthesized Gemini tool-call IDs. The per-request counter restarts at zero, so the first new_task call of every request previously persisted the same pending-action ID. Exact-ID settlement matching is unchanged. Drop the tests that only covered removed behavior and add a focused test for request-unique Gemini call IDs. * test: require both partial chunks in the Gemini call-ID test The handler emits exactly one name partial and one arguments partial per synthesized call. Require both so the test fails when either chunk is missing. * fix: serialize history deletion with settlement and validate the locked record Address PR Zoo-Code-Org#1726 review findings with minimal changes scoped to the new settlement writer. Deletion versus settlement (Zoo-Code-Org#1726 finding 1) - src/utils/fileLock.ts exports acquireFileLock and withFileLock. They use the exact advisory lock protocol that safeWriteJson uses, so one implementation owns the per-file lock. safeWriteJson acquires through acquireFileLock and keeps its write, backup, and release behavior. - TaskHistoryStore.delete and deleteMany unlink each history_item.json inside withFileLock. Cache eviction and write-through semantics stay identical to base. Lock ordering stays store lock first, then one per-file lock, matching the write path, so no path nests the file lock. - The real-filesystem race test pauses settlement inside its locked disk read, starts deletion from a second store, verifies the deletion stays blocked, releases settlement, and verifies the file stays deleted without resurrection. Locked-record validation (Zoo-Code-Org#1726 finding 3) - The settlement merge callback now validates the disk record with the canonical historyItemSchema and requires parsed.data.id === taskId. - Malformed or mismatched records evict the stale cache entry and fail settlement closed without rewriting the record. Missing-record eviction and error behavior stay unchanged. Gemini partial assertions (Zoo-Code-Org#1726 finding 2) - The request-unique tool-call ID test now asserts exactly one partial with name new_task and no arguments and exactly one partial with serialized empty arguments and no name, then keeps the shared-ID and cross-request uniqueness assertions. The pre-commit hook was skipped because the full-workspace eslint in this environment was killed for memory (exit 137). Targeted eslint --prune-suppressions --max-warnings=0 passed on every edited file with no suppression count increase, and CI runs the full lint. Validation: focused Vitest suites pass, tsc --noEmit passes, all seven bounded lifecycle model checkers pass, and full pnpm test passes (13 tasks, 488 files, 9021 tests). * fix: fail task-history deletion closed and verify the disk outcome delete and deleteMany evicted the cache before the locked unlink and swallowed all lock and unlink errors. onWrite could persist a removal while the history file stayed on disk. Callers then removed the task directory. - delete removes the file under the per-file lock first. Only a locked unlink success or a confirmed ENOENT evicts the cache and runs the write-through. Lock and unlink errors propagate. - deleteMany stops at the first failed item. Failed and unattempted items keep their cache entries. Completed deletions get a write-through before the rejection. The caller receives TaskHistoryPartialDeleteError with the original deletion error as cause. A failure-path write-through error is logged only. - deleteTaskWithId aborts before checkpoint and task directory removal when history deletion fails. Tests cover lock acquisition failure, non-ENOENT unlink failure, confirmed ENOENT, partial deleteMany cache and write-through state, and caller fail-closed directory handling. * test: provide getStorageBasePath in the ClineProvider.spec storage mock TaskHistoryStore deletion now resolves the tasks directory before it removes a history file, so the storage mock must supply the getStorageBasePath passthrough. Without it, a deletion inside the file-backed history tests throws from the mock instead of exercising the real path. * fix: refresh task history before restart settlement and restore best-effort deletion settleInterruptedCreateSubtaskBeforeReplay forces a TaskHistoryStore reconcile, settles the refreshed create_subtask action through the compare-and-clear, and adopts the authoritative pending action. Refresh, lookup, and settlement failures convert to PendingActionSettlementError and stop replay. TaskHistoryStore delete and deleteMany restore base ordering and semantics: evict cache and mtime first, best-effort locked unlink, swallow lock and unlink failures, continue every batch item, and write through once after processing. The per-file lock stays, so deletion still serializes with settlement. Remove TaskHistoryPartialDeleteError, outcome verification helpers, first-failure batch behavior, partial write-through, and the fail-closed deleteTaskWithId comment. * fix: block pending action replay without a matching tool call --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…rget architecture (Zoo-Code-Org#1706) * docs(lifecycle): specify P1 persisted ownership and generation blocks (Zoo-Code-Org#1689) * lifecycl docs on main * docs(lifecycle): address taltas review: replay increment points, routed-field comparison, roll-forward test --------- Co-authored-by: Roomote <roomote@roomote.dev> Co-authored-by: Elliott de Launay <edelaunay@wealthsimple.com>
…it_file, and read_file (Zoo-Code-Org#1685) Co-authored-by: Zoo (VP) <zoo@emebala.dev>
…_diff (Zoo-Code-Org#641) * fix(prompts): prevent models from hallucinating line numbers in apply_diff * fix(prompts): correct line-number examples and add regression tests --------- Co-authored-by: Alex <alex@MacBook-Pro.local> Co-authored-by: Elliott de Launay <edelauna@gmail.com>
* chore: prepare v3.86.0 release * fix(i18n): correct Polish release announcement
…-Org#1760) * initial fix for issues Zoo-Code-Org#1240 and Zoo-Code-Org#505 * 1st round of fixes * fixed comments * increase test coverage * revert: remove Windows shell invocation from stryker-diff * fix: address CodeRabbit review on tool-policy prompt unification * fix(test): correct apiModelId in generateSystemPrompt state mock * drop use_mcp_tool from policy when no MCP tool is permitted * code hardening * initial implementation of blanket auto-deny commands * bound model fetch with timeout, typed provider state test doubles * cover preview model fetch timeout path with tests * pin completion-time history save ordering with unit tests * poll history length in restart e2e to tolerate atomic write window * share one model-info snapshot per request between prompt and tools * resolve provider state once before the MCP wait getSystemPrompt read provider state twice: once for the MCP gate and again after the hub wait. When the caller threaded no state, the two reads could observe different snapshots. Hoist the fallback resolution to the top of the call so the prompt and the tool guidance share one snapshot on the unthreaded path. Type the test harness getSystemPrompt signature with ProviderState and ModelInfo instead of unknown, and align the affected test title and comments with the single-read behavior. * cover the undefined provider state path in the system prompt tests The provider state read can resolve to nothing even while the provider reference stays alive. Add a test for that case so the system prompt call keeps receiving undefined disabledTools instead of failing. * reuse one model-info snapshot per request and honor cancellation Request construction re-read model metadata twice after the streaming turn's bounded fetch; thread the captured snapshot through attemptApiRequest so prompt assembly, context sizing, and tool arrays agree on a single view, resolving the fallback only when no snapshot was supplied. A cancellation that lands during a request's waits now stops the request before any tool array, abort controller, or provider call is issued for it. * pin the retry count the request seam receives The empty-response retry test now asserts that the retry iteration reaches attemptApiRequest with its own incremented attempt count (second call, retryAttempt 1), instead of only checking the resulting conversation history. * refactor(task): require callers to thread provider state into system prompt build getSystemPrompt no longer falls back to re-reading provider state; the provider-state snapshot parameter is now required. An explicit undefined declares that the caller's own read came back empty because the provider was already gone, and the prompt then resolves from defaults. The prompt and the request's runtime tool array now resolve from a single snapshot by construction rather than by caller convention. Behavior is unchanged on all reachable paths. Task.spec.ts grows from 128 to 129 tests to cover the required-parameter contract. * fix(api): cancel abandoned model-metadata waits via AbortSignal The bounded metadata waits in Task.safeEnsureModelFetched and the system prompt preview cleared their timer but left the handler-side promise waiting on the model-catalog fetch. The ApiHandler contract now threads an optional AbortSignal through ensureModelFetched(): RouterProvider settles the waiter with a rejection when the signal aborts, so an abandoned or cancelled caller detaches instead of parking a promise on the shared fetch (which keeps running for other waiters and still populates the cache, by design). The task aborts its waiter both when the 5s bound expires and when cancelCurrentRequest runs (cancel and dispose paths); the preview aborts at its bound and on completion. The task-lifecycle doc's table padding was also reconciled with the PR base: the remaining diff there is now only prettier's column re-padding, which the repo's own pre-commit formatter enforces. * test(api): cover abort-signal detach paths and thread request model snapshot Mutation-diff gate kills (PR Zoo-Code-Org#1505): - zoo-gateway: signal-aware ensureModelFetched tests for the fetch-wins and fetch-rejects branches (block/CallExpression NoCoverage), an addEventListener spy pinning the { once: true } options, and paired add/remove listener assertions pinning the abort event name on both detach sites (StringLiteral mutants). - Task: ownership-guard tests for metadataFetchAbortController (clear on own completion, leave a replaced controller in place). - generateSystemPrompt: signal-capture tests pinning the timeout-bound and finally-block controller.abort() detaches (CallExpression mutants). CodeRabbit: thread the request model-info snapshot into buildCleanConversationHistory so preserveReasoning resolves from the same per-request snapshot as the prompt and tool arrays, plus regression tests. No Stryker-disable directives were needed; all 14 mutants are killed behaviorally. * test(webview): pin alwaysDenyUnapprovedCommands persistence through updateSettings * chore: tighten blanket auto-deny comments and test names for accuracy * test: remove out-of-scope Task history-persistence spec Delete src/core/task/__tests__/Task.history-persistence.spec.ts (+407, branch-only) per the ratified removal set (ruling 2026-09-20b; cycle1-scope section 3 row 1; plan section 2.4 item #1). Pre-delete evidence (plans/1569/tmp/b2-removal-evidence.md): grep 'history-persistence' returns only the file's own header self-reference -- no importers; vitest collects the spec by glob. N_blocks = 12 grep-lines (7 it + 5 describe). T6 broad-suite delta vs merged head c1378c6: 94->93 files, 1533->1526 passed, 4 skipped -- exactly the deleted spec's contribution, zero collateral. warnProtocolToolOverrides grep-zero re-confirmed; eslint-suppressions byte-identical (no increase); cast baseline 3673->3670. * test(auto-deny): pin AutoApprovalContext forwarding seam and fix stale comments F1: rewrite the queue-shortcut comment in ask-auto-deny.spec.ts to a timeless statement (drop the unresolvable past-tense claim about a second bypass path). F2: fix the self-referential docblock on CommandDecisionDetail in auto-approval/commands.ts; the relation is now stated relative to getCommandDecision, matching the inverse docblock on getCommandDecisionDetailed. F3: pin the widened askApproval -> cline.ask -> checkAutoApproval forwarding chain that no test previously referenced: - presentAssistantMessage-auto-deny.spec.ts +2 positional-forwarding cases (tool_use and MCP askApproval closure copies) - ask-auto-deny.spec.ts +1 case pinning Task.ask's dcgDecision forwarding into the policy decision Each of the three forwarding sites is mutation-killed by these cases. Gates at fix head: G1 261/14, auto-deny spec 6/1, G2 82/1, G3 6, G4 26, G6 1529 passed / 4 skipped / 93 files, tsc 0, eslint touched files 0 warnings, suppressions byte-identical, test blocks +3 added / 0 deleted, casts 3670 -> 3672 (+2, both the file's established per-call mockTask-as-Task idiom in the two mandated new tests). * test(webview): visual snapshot for blanket auto-deny checkbox The blanket auto-deny setting makes command execution fail closed when command auto-approval is on: explicitly approved commands run, anything else is denied without prompting, and the denial reason goes back to the model. The settings row that controls it had no visual regression coverage. Add a Story Gallery snapshot test for the Auto-approve settings panel with the blanket auto-deny checkbox visible and checked, plus its story registration and baselines for the four supported themes (dark, light, high-contrast, high-contrast-light). The baselines were generated in the Playwright container image pinned by docker-compose.visual.yml and are committed so the surface is protected against future drift. The setting behavior itself landed in earlier commits of this branch; this commit only adds the visual coverage. * test(core): unit coverage for blanket auto-deny reasons and edge cases Add unit coverage closing this PR's patch coverage gap: per-kind denial reason strings with fallbacks and rule id suffix, rule_id payload pins, approval edge cases. Three defensive fallback branches are unreachable by proof and stay uncovered. No production changes. * test(core): align auto-deny test fixtures with policy emission shapes The auto-deny fixtures attached a DCG rule id to not_allowlisted and denylist denials, a shape checkAutoApproval never emits, so the rule forwarding assertions could pass without covering the DCG path. The fixtures now mirror the emitted shapes: non-DCG denials carry no rule id and assert none reaches the tool payload, while new dcg-denial tests pin rule forwarding in both askApproval copies. The mocked tool handlers also capture askApproval's return value and pin it to false on the deny path instead of discarding it. This addresses the automated review comments on the branch's test diff. * fix(core): deny verdictless DCG command asks with a retryable reason A verdictless command ask under an enabled Destructive Command Guard used to auto-approve. That state is a guard inconsistency, not a guard decision: it now denies with a guard_unavailable reason stating that the command did not run, that it was not denied by policy, and that the model may retry it. Shell-expansion denials now name the offending command and drop the approval cue that hands-free mode cannot honor. Guard-disabled and verdict-carrying flows are unchanged. * test(webview): cover blanket auto-deny toggle save round-trip Saving the settings view posts the blanket auto-deny toggle, and an unset toggle is coerced to false. The local settings buffer holds user edits until Save, so the tests assert both the buffered state and the persisted payload. Addresses automated-review feedback on missing round-trip coverage for the setting. * fix(task): re-check auto-approval policy when queued answers resume an ask An ask answered from the message queue applied the auto-approval decision frozen when the ask was created: the queued path skipped checkAutoApproval, so a settings change made while the ask was pending (blanket deny switched on, or auto-approval switched off) had no effect and the queued answer could act as approval for a command the new policy would deny. Both queued-answer consume sites in Task now re-read current settings and re-run checkAutoApproval before honoring the answer. When the re-check denies, the path matches the ask-time denial: same bail-out and reason, and the queued message's claim is released so the answer is not lost to the denied ask. The queue guard on that path changed too. It tested only whether the queue was non-empty, so a message still claimed by a previous ask, or left unclaimed after a denied-command ask, counted as an approval source for the next ask. The guard now uses a new hasUnclaimed() on MessageQueueService, and Task latches blanketDeniedCommandThisTurn so no later ask in the same turn can consume a leftover message as approval. A guard_unavailable auto-deny detail now surfaces as a retryable tool_error instead of the terminal toolAutoDenied result: the kind marks a guard-state inconsistency, not a policy decision, and the model should be able to retry rather than see the turn denied. Tests: flip-on regressions at both consume sites, bail-out and claim-release tests, hasUnclaimed coverage, and a spec pinning the auto-deny reason text in the tool-response prompts. * fix(tools): re-check command policy before an approved command runs An approved execute_command request ran on the policy snapshot taken before the ask: engaging blanket auto-deny while the approval prompt was open had no effect, and the command still reached the terminal. After approval the tool now re-reads settings and, with blanket auto-deny engaged, re-runs checkAutoApproval before the shell starts. A fresh deny is honored: a blanket cause returns the same auto-denied response as the ask-time denial and marks the turn, so a queued message left by the denial cannot answer a later ask; a guard-state inconsistency (guard_unavailable) or a deny without a reason returns a retryable tool_error instead, since neither is a policy decision. The blanket-deny derivation no longer lives in two places. ExecuteCommandTool calls isBlanketDenyEngaged and consults BLANKET_DENY_AUTO_DENY_KINDS, both now exported from Task and already used by the ask-time snapshot and the queued-answer re-checks, so the decision points cannot drift apart. The protected-prompt flag sent with the command ask is derived from the same snapshot instead of hardcoded, and is forwarded to the execute-time re-check so its decision is computed against the ask the user actually answered. Tests: blanket deny engaging during the approval dwell is denied at execute time; a guard flip during the dwell returns a retryable error without marking the turn; a user Deny landing while the queued-answer re-check awaits is not overwritten; a denial at the queue drain marks the turn and blocks the follow-up ask. * test(tools): cover blanket-deny kinds missing from the auto-deny spec The spec pinned only dcg and not_allowlisted. dangerous_substitution and malformed_command now have regression tests at the presentAssistantMessage layer: each denies without executing the command and without aborting the turn. * fix(task): arm ask status timers from all release paths An approved ask that gets handed back to the user - because a fresh command-policy read comes back denying, or because its claim release lands while other messages are queued - left the interactive, resumable, and idle status timers unarmed. The only arm site was gated on `isStatusMutable`, which is computed once before the queue claim and stays false while the ask waits on the user, so hands-free and API consumers saw no interaction signal for a prompt that was pending. The arming now lives in an idempotent helper that every release path calls; the timers re-check liveness at fire time and are torn down in the ask's finally block, so a late timer cannot emit for an answered, superseded, or aborted task. The post-approval command-policy read awaited `provider.getState()` with no abort channel, so an abort could leave `ask()` blocked on the pending read. The read now races a 100 ms abort watcher and settles within one tick of an abort. The auto-deny settings checkbox handler typed its event as `any`; it now narrows `Event | FormEvent<HTMLElement>` to an `HTMLInputElement`. Five new regression tests cover each release path, the single-emit idempotence, and the abort race; each was verified to fail against the pre-fix code. * fix(settings): read blanket auto-deny toggle from the checkbox target The blanket auto-deny checkbox handler only accepted a change event whose target is an HTMLInputElement. The toolkit checkbox is a shadow-DOM custom element, so its change events reach the wrapper retargeted to the host <vscode-checkbox> element, which exposes `checked` without being an input; the check swallowed those events and the toggle never updated the setting. Read the target structurally instead: a local type predicate accepts any target carrying a boolean `checked` and declines the rest. Both the host element and a directly rendered input now update the setting, and a target without `checked` is declined rather than writing `undefined` through. Two regression tests pin the behavior: one fires a change event retargeted to a non-input host element and asserts the setting write, one fires an event whose target carries no `checked` and asserts no write. The existing settings specs cover the toggle round-trip through Save unchanged. * fix(task): enforce blanket deny at queue claims and policy re-checks Follow-up fixes to the blanket command denial work, covering three behaviors around the message queue and the execute-time policy re-check. Claiming a queued message now respects the per-turn denial latch. A blanket denial leaves its queued message in place to be answered later; previously the next ask could still claim that message at the immediate site, and the claim forced a manual prompt even when the auto-approval policy would have answered the ask itself - a hands-free session could stall on a prompt no user needed to see. The claim is now gated by the same latch the drain path uses, so the policy decision stands and the message stays queued. The immediate execute-time policy re-check is now abort-safe. That re-check ends in an uncancellable provider read, so an abort landing while it was pending could leave ask() blocked and the queued message claimed. The wait now races an abort watcher, and one finally releases the claim on the abort, throw, and release outcomes alike - the shape the drain path already used. A command approved while its prompt was open can no longer execute past a blanket deny. The execute-time re-check now re-derives command protection from the fresh policy state instead of reusing the flag captured when the prompt was shown: if blanket denial was engaged in the meantime, the fresh derivation is unprotected, so the denial is evaluated. Any re-check result other than an explicit approval is also handled fail-closed - the command is not executed, and the tool returns a retryable error instead. Adds five regression tests: two for the queue-claim gate and the abort-safe re-check (ask-auto-deny.spec.ts), three for the execute-time re-check (executeCommandTool.spec.ts). * fix(auto-approval): cancel queued-command policy re-check on task abort * fix(ci): treat negative v8 branch deltas as uncovered when merging lcov * fix(ci): keep merge-lcov.mjs out of the mutation scope and pin its clamp boundaries fe30882 pushed the PR diff's extension-package executable line count to 503, tripping the mutation gate's MAX_CHANGED_LINES=500 hard failure (Stryker never ran). CI mutation testing is advisory for Survived/NoCoverage mutants, so the regression is the scope cap itself, not surviving mutants. - stryker-diff: exclude src/scripts/merge-lcov.mjs via the existing excludedPaths convention (CI build/coverage tooling, same class as src/esbuild.mjs; covered by src/scripts/__tests__/merge-lcov.spec.mjs), bringing the extension scope back to 497 lines; pin the exclusion in the packageForPath manifest test. - merge-lcov.spec: pin parseBranchCount boundaries (-1 clamps, 0 stays, positive passes through, union prefers the positive lane) and keep non-integer BRDA rejection pinned. * test(auto-approval): pin blanket re-check approve path actually executes the command --------- Co-authored-by: edelauna <54631123+edelauna@users.noreply.github.com>
…ode-Org#1860) Prevents other installed extensions from interfering while testing this one.
…tains a lone UTF-16 surrogate (Zoo-Code-Org#1831) * fix(api): sanitize lone UTF-16 surrogates in OpenAI-chat request bodies DeepSeek rejects the entire request body when any string contains a lone UTF-16 surrogate (e.g. after history text was sliced through an astral-plane character), permanently breaking the affected task. Apply the same sanitization pattern PR Zoo-Code-Org#1605 added for the VS Code LM provider to the shared OpenAI-chat transforms, covering the DeepSeek and OpenAI providers (and other providers on the same shared path): - Move sanitizeSurrogates/sanitizeIdentifierSurrogates/ sanitizeSurrogatesDeep into a shared transform module; vscode-lm-format re-exports them. - convertToOpenAiMessages/convertToR1Format: sanitize message text, tool_result content, tool_use ids (injective, composed with normalizeToolCallId so call/result pairing survives), tool names, nested tool argument strings, and reasoning_content. - OpenAiHandler: sanitize the system/developer prompt. - BaseProvider.convertToolsForOpenAI: sanitize tool definition name/description/parameters. completePrompt is intentionally out of scope, matching Zoo-Code-Org#1605. Fixes Zoo-Code-Org#461 * test(api): make lone-surrogate body assertions effective and close coverage gaps JSON.stringify escapes lone surrogates as \udXXX text, so the copied regex-over-serialized-body assertions could never fail. Replace them with a shared expectNoLoneSurrogates helper that walks raw values recursively and fails on any unpaired UTF-16 surrogate (ES2022-safe, no isWellFormed). Also close the coverage gaps from review: - OpenAiHandler: cache_control system block with prompt caching, non-streaming system prompt, and both o3 developer-message paths, with exact sanitized text. - convertToR1Format: assistant string sanitization, assistant string merge, and user string merge into the previous user message. - convertToOpenAiMessages: text merged into the last tool message after tool_result blocks, and reasoning_content on the array-content assistant path. - convertToolsForOpenAI: mcp__srv__tool name with a lone surrogate nested in parameters, still sanitized while strict stays false. - normalizeToolCallId composition tests now use a lowercase normalizer, so swapping the sanitize/normalize order makes them fail. Ref Zoo-Code-Org#461 * test(api): cover surrogate sanitization of reasoning block extraction --------- Co-authored-by: Roomote <roomote@roomote.dev> Co-authored-by: Elliott de Launay <edelauna@gmail.com>
…rg#1651) * feat(api): add abort-signal cancellation-scope helpers to the shared utils Extend src/api/providers/utils/abort-signal.ts with the abort-signal series helpers used by the gateway providers: - isRequestAborted(error, signal): wider abort detection - an aborted signal, a DOM AbortError, the OpenAI/Anthropic SDK APIUserAbortError (name check), or the exact SDK abort message "Request was aborted." - trusting name/message only on real Error instances so a plain object that merely looks like an abort propagates unchanged - createAbortError(providerName): fresh error satisfying the Task.ts abort contract (name "AbortError", message ending in "aborted") - rejectOnAbort(pending, signal, providerName): settle a signal-less async phase (model discovery) on the provider AbortError when the signal fires first; the abort listener detaches when pending settles - resolveModelWithAbort(fetchModel, signal, providerName): run model resolution inside a cancellation scope - entry fast-fail for a pre-aborted signal, the rejectOnAbort race while the lookup is pending, and normalization of abort-flavored lookup failures; any other resolution failure propagates unchanged Includes direct unit tests for the resolveModelWithAbort cancellation scope (pre-aborted fast-fail, no-signal pass-through, mid-resolution race, abort normalization, non-abort propagation), the isRequestAborted instanceof tightening tests, and the settle-guard test utility. Unit 1/3 of the Zoo-Code-Org#1295 split (content source: 62f596c). Part of the abort-signal series (round 1). Builds on Zoo-Code-Org#674, Zoo-Code-Org#901, Zoo-Code-Org#1008. Addresses Zoo-Code-Org#404. * fix: restore throwIfAborted export dropped by the util rewrite (+ tests) * fix(abort-r1): handle a rejecting pending promise in rejectOnAbort's pre-aborted branch * test(abort-r1): remove the process listener on every exit path * chore: trigger CodeRabbit re-review (findings already addressed) --------- Co-authored-by: Eason Liang <easonliang28@gmail.com> Co-authored-by: easonLiangWorldedtech <eason.liang@worldedtech.com>
…lers (Zoo-Code-Org#1686) * fix(providers): forward task abortSignal in openai and lm-studio handlers OpenAiHandler and LmStudioHandler accepted metadata carrying the task abortSignal but never passed it to the openai-node client, so stopping a task did not cancel the in-flight HTTP stream (llama.cpp and other OpenAI-compatible backends kept generating). Forward metadata.abortSignal as the client request signal, matching the existing openai-native/nanogpt precedent. * test(lm-studio): expect RequestOptions arg in native-tools assertions * test(openai): cover abortSignal forwarding in non-streaming O3 branch --------- Co-authored-by: Zoo (VP) <zoo@emebala.dev>
…de-Org#1879) * fix(code-index): make startup embedder validation non-blocking * test(code-index): update scope constructor expectations for readiness manager * test(code-index): include readiness dependency in search workspace assertion * test(code-index): cover stale validation rejections and strengthen service assertions * test(code-index): cover readiness validation fallback errors * fix(code-index): remove automatic embedder preflight validation * fix(code-index): report incremental scan errors without clearing existing index * fix(code-index): preserve existing index across failed retries * test(code-index): cover cleanup after partial full-scan progress * fix(code-index): exclude private error details from indexing telemetry
Owner
Author
|
Opened in this fork by mistake. Replaced by Zoo-Code-Org#2469. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Draft UI experiment for local installation and hands-on feedback. No linked issue by request. Not intended for merging as-is.
What to try
profile / modelwith an optional reasoning-effort badge.Selections update saved profiles immediately. Use disposable/test profiles if you want to preserve your usual model settings.
Local testing
experiment/model-picker-variantsand install dependencies withpnpm install --frozen-lockfile.Validation
Review scope
This PR is a runnable playground, not a production-ready feature proposal. Please focus feedback on the interaction and layout. Provider-specific edge cases and visual snapshot coverage can be finalized once the UX is settled.
No changesets, changelog edits or unrelated local launch configuration are included.