Fix PHP 8.6 compatibility: pass explicit $characters arg to trim()

Author: ajaydsouza

class-settings.php

@@ -1238,7 +1238,7 @@ public static function taxonomy_search_tom_select() {
 			$search_term = explode( ',', $search_term );
 			$search_term = $search_term[ count( $search_term ) - 1 ];
 		}
-		$search_term = trim( $search_term );
+		$search_term = trim( $search_term, " \t\n\r\0\x0B" );
 
 		if ( 'meta_keys' === $endpoint ) {
 			if ( ! current_user_can( 'manage_options' ) ) {

settings/class-settings-api.php

@@ -659,7 +659,7 @@ public function admin_init() {
 
 				// Tag header rows so the settings search can group fields under them.
 				if ( 'header' === $type ) {
-					$args['class'] = trim( ( $args['class'] ?? '' ) . ' wz-settings-header-row' );
+					$args['class'] = trim( ( $args['class'] ?? '' ) . ' wz-settings-header-row', " \t\n\r\0\x0B" );
 				}
 
 				add_settings_field(

settings/class-settings-form.php

@@ -105,7 +105,7 @@ protected function get_default_description( $args ) {
 		if ( is_array( $default ) ) {
 			$default = implode( ',', array_map( 'strval', $default ) );
 		}
-		$default = trim( (string) $default );
+		$default = trim( (string) $default, " \t\n\r\0\x0B" );
 
 		// Map option keys to their labels where the field has a choices list.
 		if ( ! empty( $args['options'] ) && is_array( $args['options'] ) ) {
@@ -123,7 +123,7 @@ protected function get_default_description( $args ) {
 			} elseif ( '' !== $default && 'multicheck' === $type ) {
 				$labels = array();
 				foreach ( explode( ',', $default ) as $key ) {
-					$key      = trim( $key );
+					$key      = trim( $key, " \t\n\r\0\x0B" );
 					$labels[] = isset( $args['options'][ $key ] ) && is_string( $args['options'][ $key ] ) ? $args['options'][ $key ] : $key;
 				}
 				$default = implode( ', ', $labels );
@@ -195,7 +195,7 @@ protected function is_field_modified( $args ) {
 			return $this->normalize_list_value( $value ) !== $this->normalize_list_value( $default );
 		}
 
-		return trim( (string) $value ) !== trim( (string) $default );
+		return trim( (string) $value, " \t\n\r\0\x0B" ) !== trim( (string) $default, " \t\n\r\0\x0B" );
 	}
 
 	/**
@@ -279,7 +279,7 @@ protected function get_field_class( $args, $default_class = '' ) {
 		if ( $default_class ) {
 			$class = $default_class . ' ' . $class;
 		}
-		return trim( $class );
+		return trim( $class, " \t\n\r\0\x0B" );
 	}
 
 	/**

util/class-hook-registry.php

@@ -40,7 +40,7 @@ public static function register( string $hook_type, string $hook_name, callable
 		if ( ! in_array( $hook_type, array( 'action', 'filter' ), true ) ) {
 			return false;
 		}
-		if ( empty( trim( $hook_name ) ) ) {
+		if ( empty( trim( $hook_name, " \t\n\r\0\x0B" ) ) ) {
 			return false;
 		}
 		if ( $priority < 0 ) {