Tests: Correct missing-URL coverage for the RSS widget.

Fix the misspelled `url` key so the missing-URL dataset actually removes the setting. Remove an unused branch from the successful-URL test and declare both data providers static.

Developed in: #14341

Props shailu25.
See #65819.


git-svn-id: https://develop.svn.wordpress.org/trunk@64419 602fd350-edb4-49c9-b593-d223f7449a82

Author: lancewillett

tests/phpunit/tests/widgets/wpWidgetRss.php

@@ -34,15 +34,15 @@ public function test_url_unhappy_path( $url ) {
 		);
 
 		if ( is_null( $url ) ) {
-			unset( $instance['ur'] );
+			unset( $instance['url'] );
 		}
 
 		$this->expectOutputString( '' );
 
 		$widget->widget( $args, $instance );
 	}
 
-	public function data_url_unhappy_path() {
+	public static function data_url_unhappy_path() {
 		return array(
 			'when unset'         => array(
 				'url' => null,
@@ -79,18 +79,14 @@ public function test_url_happy_path( $url, $expected ) {
 			'url'   => $url,
 		);
 
-		if ( is_null( $url ) ) {
-			unset( $instance['ur'] );
-		}
-
 		ob_start();
 		$widget->widget( $args, $instance );
 		$actual = ob_get_clean();
 
 		$this->assertStringContainsString( $expected, $actual );
 	}
 
-	public function data_url_happy_path() {
+	public static function data_url_happy_path() {
 		return array(
 			'when url is given' => array(
 				'url' => 'https://wordpress.org/news/feed/',