Skip to content

Update the sinon library. - #10499

Draft
desrosj wants to merge 3 commits into
WordPress:trunkfrom
desrosj:update/sinon
Draft

desrosj wants to merge 3 commits into
WordPress:trunkfrom
desrosj:update/sinon

Conversation

@desrosj

@desrosj desrosj commented Nov 10, 2025

Copy link
Copy Markdown
Member

Trac ticket:


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this Nov 10, 2025
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

desrosj and others added 2 commits November 5, 2026 06:55
# Conflicts:
#	package-lock.json
#	package.json
Sinon 22 includes `@sinonjs/fake-timers` 15, which fakes the global `Intl` object when a clock is installed. The faked object cannot be stubbed because `Intl.hasOwnProperty` is overwritten with a boolean, which breaks the `communityEvents.getTimeZone` tests that stub `Intl.DateTimeFormat.prototype.resolvedOptions()`. Since `sinon-test` installs fake timers for every QUnit test, `Intl` is now excluded from faking through `toNotFake`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant