Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
|
Hi @ekamran! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Added QUnit coverage for this patch, in While writing it I found the fix missed one case. Rows that do not map to a real object, such as Home and post type archives, get the negative That is a separate commit (e76e2f3) so it can be dropped if you would rather handle it in its own ticket. |
|
@audrasjb @joedolson @westonruter could one of you take a look? Menu item selections are lost when paginating a metabox before clicking "Add to Menu". The patch caches and restores them, and QUnit coverage is added. Still reproduces on 7.1, and @yusufhay independently verified the fix on the ticket. https://core.trac.wordpress.org/ticket/65348 |
Rows that do not map to a real object, such as Home and post type archives, are rendered with the negative $_nav_menu_placeholder as their object ID. That counter restarts on every request, so keying cached selections on it dropped those rows when the checklist reloaded. Identify them by URL and title instead, which stay the same between renders. Real pages, posts and terms keep using their object ID.
e76e2f3 to
1bbc530
Compare
Trac ticket: https://core.trac.wordpress.org/ticket/65348
Summary
This fixes an issue in the Menus screen where selected menu items are lost when moving between paginated meta box pages before clicking "Add to Menu".
The patch stores selected menu item data per meta box before AJAX pagination replaces the checklist markup, restores checked state when returning to a page, and clears stored selections when switching tabs or after adding items.
Testing
Tested locally:
npm run grunt -- jshint:core --file=src/js/_enqueues/lib/nav-menu.js.git diff --check.Also checked compatibility with the
6.9.4tag:6.9.4.jshint:corepasses on the patched6.9.4file.6.9.4nav-menu.js.