Skip to content

65653 functions wp get update php url - #12569

Open
pbearne wants to merge 13 commits into
WordPress:trunkfrom
pbearne:65653-functions-wp_get_update_php_url
Open

pbearne wants to merge 13 commits into
WordPress:trunkfrom
pbearne:65653-functions-wp_get_update_php_url

Conversation

@pbearne

@pbearne pbearne commented Jul 16, 2026

Copy link
Copy Markdown

This PR introduces dedicated unit tests for the wp_get_update_php_url() function in wp-includes/functions.php.
The tests verify:

•The default support URL return value.
•The ability to override the URL using the WP_UPDATE_PHP_URL environment variable.
•The ability to override the URL using the wp_update_php_url filter.
•The function's robustness in falling back to the default URL if a filter or environment variable provides an empty or invalid value.

Trac ticket: https://core.trac.wordpress.org/ticket/65653

AI Disclosure:
•AI assistance: Yes
•Tool(s): Junie (JetBrains)
•Model(s): gemini-3-flash-preview
•Used for: Code analysis, test implementation, and workflow management.

@github-actions

github-actions Bot commented Jul 16, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The tests do not isolate or restore WP_UPDATE_PHP_URL, causing failures when the runner inherits a value and altering the environment for later tests.

1 open issue
What changed in this PR

Adds dedicated PHPUnit coverage for wp_get_update_php_url(), which provides WordPress’s PHP upgrade support URL.

Changes:

  • Tests the default URL and overrides through the environment variable and filter.
  • Uses a data provider to test fallback behavior for empty-string, null, and false filter results.
  • Leaves production code unchanged.
File Description
tests/​phpunit/​tests/​wp-includes/​functions/​WpGetUpdatePhpUrlTest.php Adds tests for the default URL, overrides, and empty-value filter fallbacks.

Review effort: Balanced

Add setup and teardown methods to manage PHP update URL environment variable.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The tests omit the empty-environment-variable fallback case, so coverage is needed to verify that WP_UPDATE_PHP_URL= returns the default URL without a filter.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Low severity Test the default URL when the environment variable is empty

tests/​phpunit/​tests/​wp-includes/​functions/​WpGetUpdatePhpUrlTest.php:69

The environment-variable test only exercises a non-empty URL, while every fallback dataset below supplies its value through the filter. This leaves the environment-variable fallback described in the PR untested. Add a case that sets WP_UPDATE_PHP_URL= without registering a filter and asserts that the default URL is returned.

1 resolved since last review

Review effort: Balanced

@pbearne
pbearne requested a review from lancewillett November 5, 2026 00:21

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make data_wp_get_update_php_url_empty_fallbacks() public static when relocating this class. PHPUnit 11 rejects non-static providers. The saved environment value in tear_down() is worth keeping because a developer may set a custom URL. The extra putenv() after the override call and the manual filter removal can go: teardown restores the environment and the base class restores hooks. I ran the cases with both removed. The environment override is the clearest new behavior beyond the existing annotation tests.

AI review · gpt-6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

4 participants