Repository navigation
Conversation
The `@double-great/stylelint-a11y` package is a fork of the original `stylelint-a11y` which has not been updated for over 7 years.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The front end underlines Button and File block buttons on both `:hover` and `:focus`, but the block editor styles only applied the underline on `:hover`. In the editor, these elements are `RichText` fields (`contenteditable`) and do receive focus, so this adds the matching `:focus` selectors. This also resolves the `a11y/selector-pseudo-class-focus` linting violation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Y86gx8u886tnkeJXZCUR1
This updates the theme's `.nvmrc` file and the `engines` field in `package.json` to require Node.js `24.18.0` and npm `11.16.0`, and adds a matching `devEngines` field. This brings Twenty Twenty in line with Core and the other default themes. Follow-up to [63539]. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Y86gx8u886tnkeJXZCUR1
…rsion. Version `3.4.15` was previously used because `3.5.0` dropped support for Node.js 20.x. Now that the theme requires Node.js 24.x, the latest version (`3.8.3`) can be used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Y86gx8u886tnkeJXZCUR1
|
@sabernhardt I think this is ready to go. Do you mind giving it a review? |
|
I was wrong about the
I also ran the following commands to check for any changes: On a side note, the vendor prefix build process does not work, and I would prefer to remove those dependencies instead of trying to fix them. |
In the block editor, the Button and File block buttons are editable text fields. With the `:focus` selectors, the button text was underlined the entire time it was being edited, which is new and unnecessary in that context. This removes the `:focus` selectors and instead disables the `a11y/selector-pseudo-class-focus` rule for that rule set, with a comment explaining why. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

The
@double-great/stylelint-a11ypackage is a seemingly well maintained fork of the originalstylelint-a11y, which has not been updated for over 7 years and is incompatible with newer versions of Stylelint and Node.js.This PR:
stylelint-a11ywith the latest version of@double-great/stylelint-a11y(^3.8.3).stylelint-config-wordpresswith@wordpress/stylelint-configin.stylelintrc.json.a11y/selector-pseudo-class-focusrule for the editor's Button and File block hover styles, which is the only violation of that rule. In the editor, these elements areRichText(contenteditable) fields, so a:focusunderline would show the entire time the text is being edited, which is unnecessary in that context..nvmrc,engines, anddevEngines), bringing it in line with Core and the other default themes. This was the last remaining item for Core-65451.The theme's build output is unchanged on Node.js 24.x.
npm run lint:cssnow runs again, but it reports existing violations of other rules from the newer@wordpress/stylelint-config(mostlyselector-class-patternfor block class names). These can be addressed in a follow-up.Trac ticket: Core-66004.
See Core-65451.
Use of AI Tools
Cursor with Composer 2.5 was used to analyze the situation for possible ways to fix this issue. Claude Code (Claude Opus 5.5) was used to verify the editor focus behavior, update the editor styles and linting exclusion, upgrade the theme to Node.js 24.x, and update the dependency.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code
https://claude.ai/code/session_011Y86gx8u886tnkeJXZCUR1