From 60136bb70765e78dd98f011b03c79bb377327dd1 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com> Date: Mon, 31 Aug 2026 11:59:05 -0400 Subject: [PATCH 1/7] Replace the abandoned `stylelint-a11y` dependency. The `@double-great/stylelint-a11y` package is a fork of the original `stylelint-a11y` which has not been updated for over 7 years. --- .../themes/twentytwenty/.stylelintrc.json | 2 +- .../themes/twentytwenty/package-lock.json | 75 ++++++++++--------- .../themes/twentytwenty/package.json | 4 +- 3 files changed, 44 insertions(+), 37 deletions(-) diff --git a/src/wp-content/themes/twentytwenty/.stylelintrc.json b/src/wp-content/themes/twentytwenty/.stylelintrc.json index f88810795c0da..c5df705cd16aa 100644 --- a/src/wp-content/themes/twentytwenty/.stylelintrc.json +++ b/src/wp-content/themes/twentytwenty/.stylelintrc.json @@ -2,7 +2,7 @@ "extends": [ "stylelint-config-wordpress" ], - "plugins": ["stylelint-a11y"], + "plugins": ["@double-great/stylelint-a11y"], "rules": { "font-family-no-missing-generic-family-keyword": null, "no-descending-specificity": null, diff --git a/src/wp-content/themes/twentytwenty/package-lock.json b/src/wp-content/themes/twentytwenty/package-lock.json index d2c2419e0df51..c71d393d43ade 100644 --- a/src/wp-content/themes/twentytwenty/package-lock.json +++ b/src/wp-content/themes/twentytwenty/package-lock.json @@ -9,14 +9,14 @@ "version": "3.2.0", "license": "GPL-2.0-or-later", "devDependencies": { + "@double-great/stylelint-a11y": "^3.5.2", "@wordpress/browserslist-config": "^6.34.0", "@wordpress/scripts": "^30.27.0", "autoprefixer": "^10.4.22", "concurrently": "^9.2.1", "postcss": "^8.5.6", "postcss-cli": "^11.0.1", - "rtlcss": "^4.3.0", - "stylelint-a11y": "^1.2.3" + "rtlcss": "^4.3.0" }, "engines": { "node": ">=16", @@ -2049,6 +2049,22 @@ "node": ">=10.0.0" } }, + "node_modules/@double-great/stylelint-a11y": { + "version": "3.5.2", + "resolved": "https://registry.npmjs.org/@double-great/stylelint-a11y/-/stylelint-a11y-3.5.2.tgz", + "integrity": "sha512-tzCK6ItlIiUJwGnATxO54ELtSaQwiMtghhIy6G5umOsp6wTPyMfTUKXt9g/TIGO2+APG1NM4V/V3aiG5W6R8Rw==", + "dev": true, + "license": "MIT", + "dependencies": { + "postcss": "^8.5.26" + }, + "engines": { + "node": ">=22.0.0" + }, + "peerDependencies": { + "stylelint": ">=16.0.0" + } + }, "node_modules/@dual-bundle/import-meta-resolve": { "version": "4.1.0", "resolved": "https://registry.npmjs.org/@dual-bundle/import-meta-resolve/-/import-meta-resolve-4.1.0.tgz", @@ -14044,9 +14060,9 @@ } }, "node_modules/nanoid": { - "version": "3.3.11", - "resolved": "https://registry.npmjs.org/nanoid/-/nanoid-3.3.11.tgz", - "integrity": "sha512-N8SpfPUnUp1bK+PMYW8qSWdl9U+wwNWI4QKxOYDy9JAro3WMX7p2OeVRF9v+347pnakNevPmiHhNmZ2HbFA76w==", + "version": "3.3.18", + "resolved": "https://registry.npmjs.org/nanoid/-/nanoid-3.3.18.tgz", + "integrity": "sha512-DTg4MJbGMWkfi6VZFdNt2/caMbQy4Ou+Op/hJQvGEWcnVfoA1QA+xzRKAzw9jD6+GVOOeYr/mIcuDSdug6F6+w==", "dev": true, "funding": [ { @@ -15040,9 +15056,9 @@ } }, "node_modules/postcss": { - "version": "8.5.6", - "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.6.tgz", - "integrity": "sha512-3Ybi1tAuwAP9s0r1UQ2J4n5Y0G05bJkpUIO0/bI9MhwmD70S5aTWbXGBwxHrelT+XM1k6dM0pk+SwNkpTRN7Pg==", + "version": "8.5.26", + "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.26.tgz", + "integrity": "sha512-u82N74LFzG8ca+dD8puPnplTXoGH4fTPpVGuIbt36G3qvNlkvfD0lEAZSxaly3KX8TS/L1A1gsCEmvKmBcVbkQ==", "dev": true, "funding": [ { @@ -15060,7 +15076,7 @@ ], "license": "MIT", "dependencies": { - "nanoid": "^3.3.11", + "nanoid": "^3.3.17", "picocolors": "^1.1.1", "source-map-js": "^1.2.1" }, @@ -18045,18 +18061,6 @@ "node": ">=18.12.0" } }, - "node_modules/stylelint-a11y": { - "version": "1.2.3", - "resolved": "https://registry.npmjs.org/stylelint-a11y/-/stylelint-a11y-1.2.3.tgz", - "integrity": "sha512-S/iiKFUsYBfa4suxP0pYQqoPB9R1+SnvxVuzHHlz9al0IWxLZzXlnZEqEez0zNOhVh5iO3rATUmDnbZE5wm/pQ==", - "dev": true, - "engines": { - "node": ">=8.7.0" - }, - "peerDependencies": { - "stylelint": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0" - } - }, "node_modules/stylelint-config-recommended": { "version": "14.0.1", "resolved": "https://registry.npmjs.org/stylelint-config-recommended/-/stylelint-config-recommended-14.0.1.tgz", @@ -21572,6 +21576,15 @@ "integrity": "sha512-dBVuXR082gk3jsFp7Rd/JI4kytwGHecnCoTtXFb7DB6CNHp4rg5k1bhg0nWdLGLnOV71lmDzGQaLMy8iPLY0pw==", "dev": true }, + "@double-great/stylelint-a11y": { + "version": "3.5.2", + "resolved": "https://registry.npmjs.org/@double-great/stylelint-a11y/-/stylelint-a11y-3.5.2.tgz", + "integrity": "sha512-tzCK6ItlIiUJwGnATxO54ELtSaQwiMtghhIy6G5umOsp6wTPyMfTUKXt9g/TIGO2+APG1NM4V/V3aiG5W6R8Rw==", + "dev": true, + "requires": { + "postcss": "^8.5.26" + } + }, "@dual-bundle/import-meta-resolve": { "version": "4.1.0", "resolved": "https://registry.npmjs.org/@dual-bundle/import-meta-resolve/-/import-meta-resolve-4.1.0.tgz", @@ -30013,9 +30026,9 @@ } }, "nanoid": { - "version": "3.3.11", - "resolved": "https://registry.npmjs.org/nanoid/-/nanoid-3.3.11.tgz", - "integrity": "sha512-N8SpfPUnUp1bK+PMYW8qSWdl9U+wwNWI4QKxOYDy9JAro3WMX7p2OeVRF9v+347pnakNevPmiHhNmZ2HbFA76w==", + "version": "3.3.18", + "resolved": "https://registry.npmjs.org/nanoid/-/nanoid-3.3.18.tgz", + "integrity": "sha512-DTg4MJbGMWkfi6VZFdNt2/caMbQy4Ou+Op/hJQvGEWcnVfoA1QA+xzRKAzw9jD6+GVOOeYr/mIcuDSdug6F6+w==", "dev": true }, "natural-compare": { @@ -30730,12 +30743,12 @@ "dev": true }, "postcss": { - "version": "8.5.6", - "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.6.tgz", - "integrity": "sha512-3Ybi1tAuwAP9s0r1UQ2J4n5Y0G05bJkpUIO0/bI9MhwmD70S5aTWbXGBwxHrelT+XM1k6dM0pk+SwNkpTRN7Pg==", + "version": "8.5.26", + "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.26.tgz", + "integrity": "sha512-u82N74LFzG8ca+dD8puPnplTXoGH4fTPpVGuIbt36G3qvNlkvfD0lEAZSxaly3KX8TS/L1A1gsCEmvKmBcVbkQ==", "dev": true, "requires": { - "nanoid": "^3.3.11", + "nanoid": "^3.3.17", "picocolors": "^1.1.1", "source-map-js": "^1.2.1" } @@ -32935,12 +32948,6 @@ } } }, - "stylelint-a11y": { - "version": "1.2.3", - "resolved": "https://registry.npmjs.org/stylelint-a11y/-/stylelint-a11y-1.2.3.tgz", - "integrity": "sha512-S/iiKFUsYBfa4suxP0pYQqoPB9R1+SnvxVuzHHlz9al0IWxLZzXlnZEqEez0zNOhVh5iO3rATUmDnbZE5wm/pQ==", - "dev": true - }, "stylelint-config-recommended": { "version": "14.0.1", "resolved": "https://registry.npmjs.org/stylelint-config-recommended/-/stylelint-config-recommended-14.0.1.tgz", diff --git a/src/wp-content/themes/twentytwenty/package.json b/src/wp-content/themes/twentytwenty/package.json index d88b74a8e0f04..9edeece3de599 100644 --- a/src/wp-content/themes/twentytwenty/package.json +++ b/src/wp-content/themes/twentytwenty/package.json @@ -22,14 +22,14 @@ "npm": ">=9.8.1" }, "devDependencies": { + "@double-great/stylelint-a11y": "^3.5.2", "@wordpress/browserslist-config": "^6.34.0", "@wordpress/scripts": "^30.27.0", "autoprefixer": "^10.4.22", "concurrently": "^9.2.1", "postcss": "^8.5.6", "postcss-cli": "^11.0.1", - "rtlcss": "^4.3.0", - "stylelint-a11y": "^1.2.3" + "rtlcss": "^4.3.0" }, "browserslist": [ "extends @wordpress/browserslist-config" From 0b0d22675e62241b228e5ae42ce74f80cefa1dc9 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com> Date: Mon, 31 Aug 2026 12:48:10 -0400 Subject: [PATCH 2/7] Fix configuration name. --- src/wp-content/themes/twentytwenty/.stylelintrc.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-content/themes/twentytwenty/.stylelintrc.json b/src/wp-content/themes/twentytwenty/.stylelintrc.json index c5df705cd16aa..ec8790beab955 100644 --- a/src/wp-content/themes/twentytwenty/.stylelintrc.json +++ b/src/wp-content/themes/twentytwenty/.stylelintrc.json @@ -1,6 +1,6 @@ { "extends": [ - "stylelint-config-wordpress" + "@wordpress/stylelint-config" ], "plugins": ["@double-great/stylelint-a11y"], "rules": { From f59d206c9bfccc479717a6e978f6ad7137c3c2de Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com> Date: Mon, 31 Aug 2026 12:48:23 -0400 Subject: [PATCH 3/7] Downgrade package to support Node.js 20.x. --- .../themes/twentytwenty/package-lock.json | 20 +++++++++---------- .../themes/twentytwenty/package.json | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/wp-content/themes/twentytwenty/package-lock.json b/src/wp-content/themes/twentytwenty/package-lock.json index c71d393d43ade..f5f069f423abf 100644 --- a/src/wp-content/themes/twentytwenty/package-lock.json +++ b/src/wp-content/themes/twentytwenty/package-lock.json @@ -9,7 +9,7 @@ "version": "3.2.0", "license": "GPL-2.0-or-later", "devDependencies": { - "@double-great/stylelint-a11y": "^3.5.2", + "@double-great/stylelint-a11y": "~3.4.15", "@wordpress/browserslist-config": "^6.34.0", "@wordpress/scripts": "^30.27.0", "autoprefixer": "^10.4.22", @@ -2050,16 +2050,16 @@ } }, "node_modules/@double-great/stylelint-a11y": { - "version": "3.5.2", - "resolved": "https://registry.npmjs.org/@double-great/stylelint-a11y/-/stylelint-a11y-3.5.2.tgz", - "integrity": "sha512-tzCK6ItlIiUJwGnATxO54ELtSaQwiMtghhIy6G5umOsp6wTPyMfTUKXt9g/TIGO2+APG1NM4V/V3aiG5W6R8Rw==", + "version": "3.4.15", + "resolved": "https://registry.npmjs.org/@double-great/stylelint-a11y/-/stylelint-a11y-3.4.15.tgz", + "integrity": "sha512-yMpE5UpdXt4ezKv7fxf69k61ycOrJ7xa+Wt6p1XuV8r1y2PKWyVGp1qxFcc4BMEpptOA0XhWPhKHrpbP3+tmuw==", "dev": true, "license": "MIT", "dependencies": { - "postcss": "^8.5.26" + "postcss": "^8.5.15" }, "engines": { - "node": ">=22.0.0" + "node": ">=18.12.0" }, "peerDependencies": { "stylelint": ">=16.0.0" @@ -21577,12 +21577,12 @@ "dev": true }, "@double-great/stylelint-a11y": { - "version": "3.5.2", - "resolved": "https://registry.npmjs.org/@double-great/stylelint-a11y/-/stylelint-a11y-3.5.2.tgz", - "integrity": "sha512-tzCK6ItlIiUJwGnATxO54ELtSaQwiMtghhIy6G5umOsp6wTPyMfTUKXt9g/TIGO2+APG1NM4V/V3aiG5W6R8Rw==", + "version": "3.4.15", + "resolved": "https://registry.npmjs.org/@double-great/stylelint-a11y/-/stylelint-a11y-3.4.15.tgz", + "integrity": "sha512-yMpE5UpdXt4ezKv7fxf69k61ycOrJ7xa+Wt6p1XuV8r1y2PKWyVGp1qxFcc4BMEpptOA0XhWPhKHrpbP3+tmuw==", "dev": true, "requires": { - "postcss": "^8.5.26" + "postcss": "^8.5.15" } }, "@dual-bundle/import-meta-resolve": { diff --git a/src/wp-content/themes/twentytwenty/package.json b/src/wp-content/themes/twentytwenty/package.json index 9edeece3de599..858a4d6004403 100644 --- a/src/wp-content/themes/twentytwenty/package.json +++ b/src/wp-content/themes/twentytwenty/package.json @@ -22,7 +22,7 @@ "npm": ">=9.8.1" }, "devDependencies": { - "@double-great/stylelint-a11y": "^3.5.2", + "@double-great/stylelint-a11y": "~3.4.15", "@wordpress/browserslist-config": "^6.34.0", "@wordpress/scripts": "^30.27.0", "autoprefixer": "^10.4.22", From 208b596bf1c3d9923b8f7e5ff1cf2ecaba5f68c9 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com> Date: Thu, 5 Nov 2026 12:48:49 -0500 Subject: [PATCH 4/7] Twenty Twenty: Match editor button focus styles to the front end. The front end underlines Button and File block buttons on both `:hover` and `:focus`, but the block editor styles only applied the underline on `:hover`. In the editor, these elements are `RichText` fields (`contenteditable`) and do receive focus, so this adds the matching `:focus` selectors. This also resolves the `a11y/selector-pseudo-class-focus` linting violation. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_011Y86gx8u886tnkeJXZCUR1 --- .../themes/twentytwenty/assets/css/editor-style-block-rtl.css | 2 ++ .../themes/twentytwenty/assets/css/editor-style-block.css | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/wp-content/themes/twentytwenty/assets/css/editor-style-block-rtl.css b/src/wp-content/themes/twentytwenty/assets/css/editor-style-block-rtl.css index 8b685f03e308d..b5f7d0ab9380f 100644 --- a/src/wp-content/themes/twentytwenty/assets/css/editor-style-block-rtl.css +++ b/src/wp-content/themes/twentytwenty/assets/css/editor-style-block-rtl.css @@ -957,7 +957,9 @@ hr.wp-block-separator.is-style-dots::before { line-height: 1.1; } +.editor-styles-wrapper .wp-block-button__link:focus, .editor-styles-wrapper .wp-block-button__link:hover, +.editor-styles-wrapper .wp-block-file__button:focus, .editor-styles-wrapper .wp-block-file__button:hover { text-decoration: underline; } diff --git a/src/wp-content/themes/twentytwenty/assets/css/editor-style-block.css b/src/wp-content/themes/twentytwenty/assets/css/editor-style-block.css index 9fbac5b956dc7..a65614ec5ea4f 100644 --- a/src/wp-content/themes/twentytwenty/assets/css/editor-style-block.css +++ b/src/wp-content/themes/twentytwenty/assets/css/editor-style-block.css @@ -961,7 +961,9 @@ hr.wp-block-separator.is-style-dots::before { line-height: 1.1; } +.editor-styles-wrapper .wp-block-button__link:focus, .editor-styles-wrapper .wp-block-button__link:hover, +.editor-styles-wrapper .wp-block-file__button:focus, .editor-styles-wrapper .wp-block-file__button:hover { text-decoration: underline; } From aba18416672da407f1d2c7394fcbae678a467bbe Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com> Date: Thu, 5 Nov 2026 12:50:14 -0500 Subject: [PATCH 5/7] Twenty Twenty: Update to Node.js 24.x. This updates the theme's `.nvmrc` file and the `engines` field in `package.json` to require Node.js `24.18.0` and npm `11.16.0`, and adds a matching `devEngines` field. This brings Twenty Twenty in line with Core and the other default themes. Follow-up to [63539]. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_011Y86gx8u886tnkeJXZCUR1 --- src/wp-content/themes/twentytwenty/.nvmrc | 2 +- .../themes/twentytwenty/package-lock.json | 4 ++-- src/wp-content/themes/twentytwenty/package.json | 15 +++++++++++++-- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/wp-content/themes/twentytwenty/.nvmrc b/src/wp-content/themes/twentytwenty/.nvmrc index b6a7d89c68e0c..82d5d714347ef 100644 --- a/src/wp-content/themes/twentytwenty/.nvmrc +++ b/src/wp-content/themes/twentytwenty/.nvmrc @@ -1 +1 @@ -16 +24.18 diff --git a/src/wp-content/themes/twentytwenty/package-lock.json b/src/wp-content/themes/twentytwenty/package-lock.json index 53e9ed1793148..7b5fc839b189d 100644 --- a/src/wp-content/themes/twentytwenty/package-lock.json +++ b/src/wp-content/themes/twentytwenty/package-lock.json @@ -19,8 +19,8 @@ "rtlcss": "^4.3.0" }, "engines": { - "node": ">=16", - "npm": ">=9.8.1" + "node": ">=24.18.0", + "npm": ">=11.16.0" } }, "node_modules/@ampproject/remapping": { diff --git a/src/wp-content/themes/twentytwenty/package.json b/src/wp-content/themes/twentytwenty/package.json index b4217c6cef910..4861b61db7471 100644 --- a/src/wp-content/themes/twentytwenty/package.json +++ b/src/wp-content/themes/twentytwenty/package.json @@ -18,8 +18,19 @@ "url": "https://core.trac.wordpress.org/" }, "engines": { - "node": ">=16", - "npm": ">=9.8.1" + "node": ">=24.18.0", + "npm": ">=11.16.0" + }, + "devEngines": { + "runtime": { + "name": "node", + "version": ">=24.18.0" + }, + "packageManager": { + "name": "npm", + "version": ">=11.16.0", + "onFail": "error" + } }, "devDependencies": { "@double-great/stylelint-a11y": "~3.4.15", From 49fe7c7fa388e228c59cb4c83ceea2135bf86ca8 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com> Date: Thu, 5 Nov 2026 12:51:54 -0500 Subject: [PATCH 6/7] Twenty Twenty: Update `@double-great/stylelint-a11y` to the latest version. Version `3.4.15` was previously used because `3.5.0` dropped support for Node.js 20.x. Now that the theme requires Node.js 24.x, the latest version (`3.8.3`) can be used. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_011Y86gx8u886tnkeJXZCUR1 --- .../themes/twentytwenty/package-lock.json | 94 ++++++++++++------- .../themes/twentytwenty/package.json | 2 +- 2 files changed, 62 insertions(+), 34 deletions(-) diff --git a/src/wp-content/themes/twentytwenty/package-lock.json b/src/wp-content/themes/twentytwenty/package-lock.json index 7b5fc839b189d..e230cf63fb940 100644 --- a/src/wp-content/themes/twentytwenty/package-lock.json +++ b/src/wp-content/themes/twentytwenty/package-lock.json @@ -9,7 +9,7 @@ "version": "3.3.0", "license": "GPL-2.0-or-later", "devDependencies": { - "@double-great/stylelint-a11y": "~3.4.15", + "@double-great/stylelint-a11y": "^3.8.3", "@wordpress/browserslist-config": "^6.34.0", "@wordpress/scripts": "^30.27.0", "autoprefixer": "^10.4.22", @@ -2050,19 +2050,34 @@ } }, "node_modules/@double-great/stylelint-a11y": { - "version": "3.4.15", - "resolved": "https://registry.npmjs.org/@double-great/stylelint-a11y/-/stylelint-a11y-3.4.15.tgz", - "integrity": "sha512-yMpE5UpdXt4ezKv7fxf69k61ycOrJ7xa+Wt6p1XuV8r1y2PKWyVGp1qxFcc4BMEpptOA0XhWPhKHrpbP3+tmuw==", + "version": "3.8.3", + "resolved": "https://registry.npmjs.org/@double-great/stylelint-a11y/-/stylelint-a11y-3.8.3.tgz", + "integrity": "sha512-mSRv32ygqKXLJSvJd8xjol2q9TBwWA7D3Cukk2xrpCME+BZ/oIv5lSA+MWn1yqZ7QP9/puiORLX/E02QVBZd+w==", "dev": true, "license": "MIT", "dependencies": { - "postcss": "^8.5.15" + "postcss": "^8.5.29", + "postcss-selector-parser": "^7.1.0" }, "engines": { - "node": ">=18.12.0" + "node": ">=22.0.0" }, "peerDependencies": { - "stylelint": ">=16.0.0" + "stylelint": ">=16.7.0" + } + }, + "node_modules/@double-great/stylelint-a11y/node_modules/postcss-selector-parser": { + "version": "7.1.7", + "resolved": "https://registry.npmjs.org/postcss-selector-parser/-/postcss-selector-parser-7.1.7.tgz", + "integrity": "sha512-wWBro/7hJ40ye6TPiXkUQoXKCw23xSsjriUvqd7Uls9Sso3oLiON1flc18cCdnjgCRXw4fBVqUJJeOdDTh3P3g==", + "dev": true, + "license": "MIT", + "dependencies": { + "cssesc": "^3.0.0", + "util-deprecate": "^1.0.2" + }, + "engines": { + "node": ">=4" } }, "node_modules/@dual-bundle/import-meta-resolve": { @@ -14060,9 +14075,9 @@ } }, "node_modules/nanoid": { - "version": "3.3.18", - "resolved": "https://registry.npmjs.org/nanoid/-/nanoid-3.3.18.tgz", - "integrity": "sha512-DTg4MJbGMWkfi6VZFdNt2/caMbQy4Ou+Op/hJQvGEWcnVfoA1QA+xzRKAzw9jD6+GVOOeYr/mIcuDSdug6F6+w==", + "version": "3.3.20", + "resolved": "https://registry.npmjs.org/nanoid/-/nanoid-3.3.20.tgz", + "integrity": "sha512-uKdg2G3GNCKQn9byYOpxbGqrT2fGO5KRt5J/8b3pok8rT6qxGWF6hxMyJiEYtAf+FVyYuD9hRaDqX5uPFYJ4ZQ==", "dev": true, "funding": [ { @@ -15056,9 +15071,9 @@ } }, "node_modules/postcss": { - "version": "8.5.26", - "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.26.tgz", - "integrity": "sha512-u82N74LFzG8ca+dD8puPnplTXoGH4fTPpVGuIbt36G3qvNlkvfD0lEAZSxaly3KX8TS/L1A1gsCEmvKmBcVbkQ==", + "version": "8.5.32", + "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.32.tgz", + "integrity": "sha512-LJlKCCAUFKOuZxipUdYw1NzIITEsPcgyOG9LkvRJvuKj/bRzbuRY0ARXvL0pWGpsZvn8jku+LMep2eU0seHp8g==", "dev": true, "funding": [ { @@ -15076,9 +15091,9 @@ ], "license": "MIT", "dependencies": { - "nanoid": "^3.3.17", + "nanoid": "^3.3.20", "picocolors": "^1.1.1", - "source-map-js": "^1.2.1" + "source-map-js": "^1.2.2" }, "engines": { "node": "^10 || ^12 || >=14" @@ -17519,9 +17534,9 @@ } }, "node_modules/source-map-js": { - "version": "1.2.1", - "resolved": "https://registry.npmjs.org/source-map-js/-/source-map-js-1.2.1.tgz", - "integrity": "sha512-UXWMKhLOwVKb728IUtQPXxfYU+usdybtUrK/8uGE8CQMvrhOpwvzDBwj0QhSL7MQc7vIsISBG8VQ8+IDQxpfQA==", + "version": "1.2.2", + "resolved": "https://registry.npmjs.org/source-map-js/-/source-map-js-1.2.2.tgz", + "integrity": "sha512-KGj/8Y43x35aZVDtt+J4mK1hoLGHULMYfSkODJNQjNDC3oW1PqPoxMwo0pLUsWM/UEGzON/NxeHywEfNXNP3Vw==", "dev": true, "license": "BSD-3-Clause", "engines": { @@ -21577,12 +21592,25 @@ "dev": true }, "@double-great/stylelint-a11y": { - "version": "3.4.15", - "resolved": "https://registry.npmjs.org/@double-great/stylelint-a11y/-/stylelint-a11y-3.4.15.tgz", - "integrity": "sha512-yMpE5UpdXt4ezKv7fxf69k61ycOrJ7xa+Wt6p1XuV8r1y2PKWyVGp1qxFcc4BMEpptOA0XhWPhKHrpbP3+tmuw==", + "version": "3.8.3", + "resolved": "https://registry.npmjs.org/@double-great/stylelint-a11y/-/stylelint-a11y-3.8.3.tgz", + "integrity": "sha512-mSRv32ygqKXLJSvJd8xjol2q9TBwWA7D3Cukk2xrpCME+BZ/oIv5lSA+MWn1yqZ7QP9/puiORLX/E02QVBZd+w==", "dev": true, "requires": { - "postcss": "^8.5.15" + "postcss": "^8.5.29", + "postcss-selector-parser": "^7.1.0" + }, + "dependencies": { + "postcss-selector-parser": { + "version": "7.1.7", + "resolved": "https://registry.npmjs.org/postcss-selector-parser/-/postcss-selector-parser-7.1.7.tgz", + "integrity": "sha512-wWBro/7hJ40ye6TPiXkUQoXKCw23xSsjriUvqd7Uls9Sso3oLiON1flc18cCdnjgCRXw4fBVqUJJeOdDTh3P3g==", + "dev": true, + "requires": { + "cssesc": "^3.0.0", + "util-deprecate": "^1.0.2" + } + } } }, "@dual-bundle/import-meta-resolve": { @@ -30026,9 +30054,9 @@ } }, "nanoid": { - "version": "3.3.18", - "resolved": "https://registry.npmjs.org/nanoid/-/nanoid-3.3.18.tgz", - "integrity": "sha512-DTg4MJbGMWkfi6VZFdNt2/caMbQy4Ou+Op/hJQvGEWcnVfoA1QA+xzRKAzw9jD6+GVOOeYr/mIcuDSdug6F6+w==", + "version": "3.3.20", + "resolved": "https://registry.npmjs.org/nanoid/-/nanoid-3.3.20.tgz", + "integrity": "sha512-uKdg2G3GNCKQn9byYOpxbGqrT2fGO5KRt5J/8b3pok8rT6qxGWF6hxMyJiEYtAf+FVyYuD9hRaDqX5uPFYJ4ZQ==", "dev": true }, "natural-compare": { @@ -30743,14 +30771,14 @@ "dev": true }, "postcss": { - "version": "8.5.26", - "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.26.tgz", - "integrity": "sha512-u82N74LFzG8ca+dD8puPnplTXoGH4fTPpVGuIbt36G3qvNlkvfD0lEAZSxaly3KX8TS/L1A1gsCEmvKmBcVbkQ==", + "version": "8.5.32", + "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.32.tgz", + "integrity": "sha512-LJlKCCAUFKOuZxipUdYw1NzIITEsPcgyOG9LkvRJvuKj/bRzbuRY0ARXvL0pWGpsZvn8jku+LMep2eU0seHp8g==", "dev": true, "requires": { - "nanoid": "^3.3.17", + "nanoid": "^3.3.20", "picocolors": "^1.1.1", - "source-map-js": "^1.2.1" + "source-map-js": "^1.2.2" } }, "postcss-calc": { @@ -32387,9 +32415,9 @@ "dev": true }, "source-map-js": { - "version": "1.2.1", - "resolved": "https://registry.npmjs.org/source-map-js/-/source-map-js-1.2.1.tgz", - "integrity": "sha512-UXWMKhLOwVKb728IUtQPXxfYU+usdybtUrK/8uGE8CQMvrhOpwvzDBwj0QhSL7MQc7vIsISBG8VQ8+IDQxpfQA==", + "version": "1.2.2", + "resolved": "https://registry.npmjs.org/source-map-js/-/source-map-js-1.2.2.tgz", + "integrity": "sha512-KGj/8Y43x35aZVDtt+J4mK1hoLGHULMYfSkODJNQjNDC3oW1PqPoxMwo0pLUsWM/UEGzON/NxeHywEfNXNP3Vw==", "dev": true }, "source-map-loader": { diff --git a/src/wp-content/themes/twentytwenty/package.json b/src/wp-content/themes/twentytwenty/package.json index 4861b61db7471..8405868722fef 100644 --- a/src/wp-content/themes/twentytwenty/package.json +++ b/src/wp-content/themes/twentytwenty/package.json @@ -33,7 +33,7 @@ } }, "devDependencies": { - "@double-great/stylelint-a11y": "~3.4.15", + "@double-great/stylelint-a11y": "^3.8.3", "@wordpress/browserslist-config": "^6.34.0", "@wordpress/scripts": "^30.27.0", "autoprefixer": "^10.4.22", From ba1b2edb1a0542111b2cd0753e8bbd82de714884 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com> Date: Mon, 9 Nov 2026 14:48:29 -0500 Subject: [PATCH 7/7] Twenty Twenty: Remove the editor button `:focus` underline styles. In the block editor, the Button and File block buttons are editable text fields. With the `:focus` selectors, the button text was underlined the entire time it was being edited, which is new and unnecessary in that context. This removes the `:focus` selectors and instead disables the `a11y/selector-pseudo-class-focus` rule for that rule set, with a comment explaining why. Co-Authored-By: Claude Opus 5.5 --- .../twentytwenty/assets/css/editor-style-block-rtl.css | 7 +++++-- .../themes/twentytwenty/assets/css/editor-style-block.css | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/wp-content/themes/twentytwenty/assets/css/editor-style-block-rtl.css b/src/wp-content/themes/twentytwenty/assets/css/editor-style-block-rtl.css index b5f7d0ab9380f..8c6eef23a6e04 100644 --- a/src/wp-content/themes/twentytwenty/assets/css/editor-style-block-rtl.css +++ b/src/wp-content/themes/twentytwenty/assets/css/editor-style-block-rtl.css @@ -957,9 +957,12 @@ hr.wp-block-separator.is-style-dots::before { line-height: 1.1; } -.editor-styles-wrapper .wp-block-button__link:focus, +/* + * In the editor, these elements are editable text fields. A focus underline + * would only appear while typing, so it is intentionally omitted here. + */ +/* stylelint-disable-next-line a11y/selector-pseudo-class-focus */ .editor-styles-wrapper .wp-block-button__link:hover, -.editor-styles-wrapper .wp-block-file__button:focus, .editor-styles-wrapper .wp-block-file__button:hover { text-decoration: underline; } diff --git a/src/wp-content/themes/twentytwenty/assets/css/editor-style-block.css b/src/wp-content/themes/twentytwenty/assets/css/editor-style-block.css index a65614ec5ea4f..b9ffc7c261744 100644 --- a/src/wp-content/themes/twentytwenty/assets/css/editor-style-block.css +++ b/src/wp-content/themes/twentytwenty/assets/css/editor-style-block.css @@ -961,9 +961,12 @@ hr.wp-block-separator.is-style-dots::before { line-height: 1.1; } -.editor-styles-wrapper .wp-block-button__link:focus, +/* + * In the editor, these elements are editable text fields. A focus underline + * would only appear while typing, so it is intentionally omitted here. + */ +/* stylelint-disable-next-line a11y/selector-pseudo-class-focus */ .editor-styles-wrapper .wp-block-button__link:hover, -.editor-styles-wrapper .wp-block-file__button:focus, .editor-styles-wrapper .wp-block-file__button:hover { text-decoration: underline; }