Repository navigation
Build/Test Tools: Preserve grouped tests on older PHPUnit versions - #13641
Closed
lancewillett wants to merge 1 commit into
Closed
lancewillett wants to merge 1 commit into
lancewillett wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
adimoldovan
approved these changes
Sep 21, 2026
wporg-sync
pushed a commit
that referenced
this pull request
Sep 21, 2026
Only pass --fail-on-empty-test-suite on PHP 7.3 and newer, where the supported PHPUnit versions recognize it. Preserve group selection on older versions so release branches using the shared workflow can run their tests. Keep empty-suite protection for the Core assets job and other grouped runs on supported PHPUnit versions. Developed in: #13641 Props lancewillett, adrianmoldovanwp. See #65889. git-svn-id: https://develop.svn.wordpress.org/trunk@63786 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Sep 21, 2026
Only pass --fail-on-empty-test-suite on PHP 7.3 and newer, where the supported PHPUnit versions recognize it. Preserve group selection on older versions so release branches using the shared workflow can run their tests. Keep empty-suite protection for the Core assets job and other grouped runs on supported PHPUnit versions. Developed in: WordPress/wordpress-develop#13641 Props lancewillett, adrianmoldovanwp. See #65889. Built from https://develop.svn.wordpress.org/trunk@63786 git-svn-id: http://core.svn.wordpress.org/trunk@62958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/65889
Follow-up to r63778 / #13523, found while preparing the release-branch workflow changes for Trac #66069.
Grouped PHPUnit runs on PHP 7.2 use PHPUnit 8.5, which rejects the newly added
--fail-on-empty-test-suiteoption before running any tests. Older release branches call this shared workflow from trunk, so they are affected even though trunk's PHP versions support the option.Keep
--groupon all grouped runs, and add the empty-suite flag only on PHP 7.3 and newer, where the current dependencies resolve to PHPUnit 9.6. This follows the PHP-version conditions already used by the v1 and v2 reusable workflows. The Core assets job retains its empty-suite protection; older PHPUnit versions keep their previous empty-suite behavior.Validation
unrecognized option --fail-on-empty-test-suitewith PHPUnit 8.5.54 on PHP 7.2.git diff --checkpassed.Use of AI tools
AI assistance: Yes.
Tool: Codex.
Model: GPT-6.
Used for: Diagnosis, implementation, and container-based validation. Reviewed by me.