Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @Jawad0501. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Thank you @Jawad0501. Could you please also work on the second suggestion from @joedolson ? That would be needed to get this PR ready to be shipped :) |
The erasure check runs against an email address, which may not belong to a user account. See #47491.
|
|
||
| if ( false === hasRemoved ) { | ||
| if ( false === hasRetained ) { | ||
| <<<<<<< Updated upstream |
There was a problem hiding this comment.
@Jawad0501 can you please check and remove those conflict markers?
| <<<<<<< Updated upstream | ||
| summaryMessage = __( 'No personal data was found for this user.' ); | ||
| classes = 'notice-info'; | ||
| ======= |
| requestEmail | ||
| ); | ||
| } | ||
| >>>>>>> Stashed changes |
Trac ticket: https://core.trac.wordpress.org/ticket/47491
Problem
On Tools > Erase Personal Data, erasing a user who has no personal data shows "No personal data was found for this user." as a green success notice. As raised in https://core.trac.wordpress.org/ticket/44135#comment:16, nothing was changed in this case, so the notice should be informational (blue) rather than a success.
The other colour issues raised in that comment are already resolved in trunk:
Change
In
privacy-tools.js, usenotice-infoinstead ofnotice-successfor the "No personal data was found for this user." erasure result. Erasures that removed data keepnotice-success, and partial or retained results keepnotice-warning.Testing
Use of AI tools
The analysis of the ticket against current trunk and this description were drafted with AI assistance (Cursor). I made the code change and reviewed the diff.