Skip to content

Themes: Prevent previewing incompatible themes from the theme installer cards. - #14052

Open
R1shabh-Gupta wants to merge 3 commits into
WordPress:trunkfrom
R1shabh-Gupta:fix/66256-theme-installer-incompatible-preview
Open

R1shabh-Gupta wants to merge 3 commits into
WordPress:trunkfrom
R1shabh-Gupta:fix/66256-theme-installer-incompatible-preview

Conversation

@R1shabh-Gupta

@R1shabh-Gupta R1shabh-Gupta commented Oct 6, 2026 •

Copy link
Copy Markdown

In the theme installer (wp-admin/theme-install.php), themes that are incompatible with the current WordPress or PHP version have their action buttons disabled, but clicking anywhere else on the theme card still opened the theme preview.

This PR:

  • Bails early in the card's preview handler when the theme is incompatible, so clicking, tapping, or pressing Enter on the card no longer opens the preview.
  • Removes the "Details & Preview" hover label, pointer cursor, and hover dimming from incompatible cards, so they no longer look clickable.
  • Makes the Next/Previous arrows (and Alt + arrow keys) in the preview overlay skip incompatible themes.
  • Bails early in the preview route handler when the requested theme can't be previewed or isn't in the current collection, so the browser's Back/Forward buttons can't leave the overlay unresponsive.

As a side effect, the links in the card's compatibility notice (e.g. "Please update WordPress") now work. Previously the preview handler prevented their default action.

Trac ticket: https://core.trac.wordpress.org/ticket/66256

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Code Review


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@R1shabh-Gupta
R1shabh-Gupta marked this pull request as ready for review October 7, 2026 12:51
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rishabhwp.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant