From 998b5e385a24ea9b2479dbb0d6af0fd3bbae1447 Mon Sep 17 00:00:00 2001 From: Jon Surrell Date: Wed, 7 Oct 2026 09:56:46 +0400 Subject: [PATCH 1/3] Administration: Avoid parsing tab and hash values as HTML in admin scripts. Several admin scripts pass a link `href` or the URL hash to `$()`, which parses strings that look like HTML as markup. Select through `$( document ).find()` where the value is the whole selector, and escape the value with `$.escapeSelector()` where it is part of a larger selector, so each value is only ever treated as a selector. This follows the same change made to the contextual help tabs in common.js in [64133]. --- src/js/_enqueues/admin/link.js | 2 +- src/js/_enqueues/admin/plugin-install.js | 2 +- src/js/_enqueues/admin/post.js | 2 +- src/js/_enqueues/admin/site-health.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/js/_enqueues/admin/link.js b/src/js/_enqueues/admin/link.js index ed4bd5e3efb94..b916021327160 100644 --- a/src/js/_enqueues/admin/link.js +++ b/src/js/_enqueues/admin/link.js @@ -30,7 +30,7 @@ jQuery( function($) { $(this).attr( 'aria-selected', 'true' ).removeAttr( 'tabindex' ); $(this).parent().addClass('tabs').siblings('li').removeClass('tabs'); $('.tabs-panel').hide(); - $(t).show(); + $( document ).find( t ).show(); if ( '#categories-all' == t ) { deleteUserSetting('cats'); } else { diff --git a/src/js/_enqueues/admin/plugin-install.js b/src/js/_enqueues/admin/plugin-install.js index b79931a7e7791..54df88fa15ebf 100644 --- a/src/js/_enqueues/admin/plugin-install.js +++ b/src/js/_enqueues/admin/plugin-install.js @@ -218,7 +218,7 @@ jQuery( function( $ ) { // Flip the content. $( '#section-holder div.section' ).hide(); // Hide 'em all. - $( '#section-' + tab ).show(); + $( '#section-' + $.escapeSelector( tab ) ).show(); }); /* diff --git a/src/js/_enqueues/admin/post.js b/src/js/_enqueues/admin/post.js index 462523636c9ab..1c166a82cb32a 100644 --- a/src/js/_enqueues/admin/post.js +++ b/src/js/_enqueues/admin/post.js @@ -586,7 +586,7 @@ jQuery( function($) { $(this).attr( 'aria-selected', 'true' ).removeAttr( 'tabindex' ); $(this).parent().addClass('tabs').siblings('li').removeClass('tabs'); $('#' + taxonomy + '-tabs').siblings('.tabs-panel').hide(); - $(t).show(); + $( document ).find( t ).show(); if ( '#' + taxonomy + '-all' == t ) { deleteUserSetting( settingName ); } else { diff --git a/src/js/_enqueues/admin/site-health.js b/src/js/_enqueues/admin/site-health.js index 0a1b052e56f3b..8d8c40c70c3e9 100644 --- a/src/js/_enqueues/admin/site-health.js +++ b/src/js/_enqueues/admin/site-health.js @@ -66,7 +66,7 @@ jQuery( function( $ ) { var hash = window.location.hash; if ( hash ) { - var requestedPanel = $( hash ); + var requestedPanel = $( document ).find( hash ); if ( requestedPanel.is( '.health-check-accordion-trigger' ) ) { requestedPanel.trigger( 'click' ); From 2034440e0f05d35b05ab0092648022f56e128807 Mon Sep 17 00:00:00 2001 From: Jon Surrell Date: Wed, 7 Oct 2026 13:28:45 +0400 Subject: [PATCH 2/3] Media, Updates: Avoid parsing selector values as HTML in admin scripts. `wp.updates.addAdminNotice()`, `wp.media.transition()` and the attachment details frame's `focusNavButton()` pass a caller-supplied selector to `$()`, which parses a value that looks like HTML as markup. Select through `$( document ).find()` so the value is only ever treated as a selector. This follows [64133] and the admin script changes in the same series. --- src/js/_enqueues/wp/media/views.js | 2 +- src/js/_enqueues/wp/updates.js | 2 +- src/js/media/views/frame/edit-attachments.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/js/_enqueues/wp/media/views.js b/src/js/_enqueues/wp/media/views.js index 1eec769227e12..59237c5bc18c5 100644 --- a/src/js/_enqueues/wp/media/views.js +++ b/src/js/_enqueues/wp/media/views.js @@ -58,7 +58,7 @@ media.transition = function( selector, sensitivity ) { if ( $.support.transition ) { if ( ! (selector instanceof $) ) { - selector = $( selector ); + selector = $( document ).find( selector ); } // Resolve the deferred when the first element finishes animating. diff --git a/src/js/_enqueues/wp/updates.js b/src/js/_enqueues/wp/updates.js index 59d0ef2e6b1cb..127ab017e9d01 100644 --- a/src/js/_enqueues/wp/updates.js +++ b/src/js/_enqueues/wp/updates.js @@ -253,7 +253,7 @@ * */ wp.updates.addAdminNotice = function( data ) { - var $notice = $( data.selector ), + var $notice = $( document ).find( data.selector ), $headerEnd = $( '.wp-header-end' ), $adminNotice; diff --git a/src/js/media/views/frame/edit-attachments.js b/src/js/media/views/frame/edit-attachments.js index e3bc0d09e643b..43327af27b716 100644 --- a/src/js/media/views/frame/edit-attachments.js +++ b/src/js/media/views/frame/edit-attachments.js @@ -268,7 +268,7 @@ EditAttachments = MediaFrame.extend(/** @lends wp.media.view.MediaFrame.EditAtta * @param {string} which A CSS selector to target the button to focus. */ focusNavButton: function( which ) { - $( which ).trigger( 'focus' ); + $( document ).find( which ).trigger( 'focus' ); }, getCurrentIndex: function() { From 6c9ebccfebe2c267f8e709e29e1b55eacefe71be Mon Sep 17 00:00:00 2001 From: Jon Surrell Date: Thu, 15 Oct 2026 10:43:39 +0200 Subject: [PATCH 3/3] Apply suggestion from @westonruter Co-authored-by: Weston Ruter --- src/js/_enqueues/admin/plugin-install.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/_enqueues/admin/plugin-install.js b/src/js/_enqueues/admin/plugin-install.js index 54df88fa15ebf..61e6a2e1ed60b 100644 --- a/src/js/_enqueues/admin/plugin-install.js +++ b/src/js/_enqueues/admin/plugin-install.js @@ -218,7 +218,7 @@ jQuery( function( $ ) { // Flip the content. $( '#section-holder div.section' ).hide(); // Hide 'em all. - $( '#section-' + $.escapeSelector( tab ) ).show(); + $( '#section-' + CSS.escape( tab ) ).show(); }); /*