Repository navigation
Media: Fix DOM and visual order mismatch in the media dialogs - #14196
i-am-chitti wants to merge 3 commits into
Conversation
… fix/66270-media-dialog-dom-order
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| title: this.options.title | ||
| controller: this, | ||
| title: this.options.title, | ||
| hasCloseButton: false |
There was a problem hiding this comment.
Regarding:
Back-compat: a plugin that overrides tmpl-media-frame would no longer get a Close button in the modal.
Is there any way to mitigate this risk? To my understanding:
- If the frame
modaloption is true, it will now use the button in the correct order - If the frame
modaloption is false (is this the case when the frame may be overridden by plugins?) then let the button in the wrong order be used. It will be wrong order, but at least there is no backward compatibility breakage.
I may be missing something though.
Moves the Close and navigation buttons after the dialog heading in the DOM, so screen readers read them in the same order they appear on screen.
Back-compat: a plugin that overrides
tmpl-media-framewould no longer get a Close button in the modal.Trac ticket: https://core.trac.wordpress.org/ticket/66270
Screenshots
Numbers show DOM order.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Investigation, implementation.