Skip to content

Media: Fix DOM and visual order mismatch in the media dialogs - #14196

Open
i-am-chitti wants to merge 3 commits into
WordPress:trunkfrom
i-am-chitti:fix/66270-media-dialog-dom-order
Open

i-am-chitti wants to merge 3 commits into
WordPress:trunkfrom
i-am-chitti:fix/66270-media-dialog-dom-order

Conversation

@i-am-chitti

Copy link
Copy Markdown

Moves the Close and navigation buttons after the dialog heading in the DOM, so screen readers read them in the same order they appear on screen.

Back-compat: a plugin that overrides tmpl-media-frame would no longer get a Close button in the modal.

Trac ticket: https://core.trac.wordpress.org/ticket/66270

Screenshots

Numbers show DOM order.

Before After
Media modal 66270-media-modal-before 66270-media-modal-after
Attachment details 66270-attachment-details-before 66270-attachment-details-after

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Investigation, implementation.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props iamchitti.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

title: this.options.title
controller: this,
title: this.options.title,
hasCloseButton: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding:

Back-compat: a plugin that overrides tmpl-media-frame would no longer get a Close button in the modal.

Is there any way to mitigate this risk? To my understanding:

  • If the frame modal option is true, it will now use the button in the correct order
  • If the frame modal option is false (is this the case when the frame may be overridden by plugins?) then let the button in the wrong order be used. It will be wrong order, but at least there is no backward compatibility breakage.

I may be missing something though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants