Repository navigation
Themes: Avoid a missing screenshot request in Theme Details - #14221
lancewillett wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Reviewed at 66d5c80. No open findings. The change returns early from Checked in a browser against a local build of this branch:
For the first case I blanked a bundled theme's screenshot in the page's theme data, instead of installing a theme without one. CI is green on this head, all 51 checks. One E2E test was retried in one job: AI review · |
Return early from `screenshotCheck()` when the theme has no screenshot image. This prevents assigning an undefined source to a new `Image` and requesting `/wp-admin/undefined`. Preserve the screenshot sizing check for themes with an image. Developed in: #14221 Props afercia, anupkankale. Fixes #66295. git-svn-id: https://develop.svn.wordpress.org/trunk@64329 602fd350-edb4-49c9-b593-d223f7449a82
Return early from `screenshotCheck()` when the theme has no screenshot image. This prevents assigning an undefined source to a new `Image` and requesting `/wp-admin/undefined`. Preserve the screenshot sizing check for themes with an image. Developed in: WordPress/wordpress-develop#14221 Props afercia, anupkankale. Fixes #66295. Built from https://develop.svn.wordpress.org/trunk@64329 git-svn-id: http://core.svn.wordpress.org/trunk@63479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Opening Theme Details for a theme without a screenshot requests
/wp-admin/undefinedand returns a 404. The template has no screenshot image, but the sizing check assigns its missing source to a newImage.Return before creating that image when no screenshot element exists. Themes with screenshots keep their existing sizing behavior.
Trac ticket: https://core.trac.wordpress.org/ticket/66295
Testing
The temporary browser probe and theme were removed; this PR changes only the sizing guard.
Use of AI Tools
Implemented and browser-tested with Codex (GPT-6), including a separate scoped review. Human review is pending.