Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Summary
wp.ajax.send()readsdeferred.jqXHRinside the.done()callback to get theX-WP-Totalheader forquery-attachmentsrequests. If the request completes synchronously (for examplejQuery.ajaxSetup( { async: false } ), a custom transport, or a plugin that mocks or caches$.ajax), jQuery runs the callback before$.ajax()returns, sodeferred.jqXHRis stillundefinedand the guard throws aTypeError. In the media grid this also leaves every matching attachment duplicated.This uses the
jqXHRjQuery passes as the third argument to.done(), which is always defined. Async behaviour is unchanged.Testing
Added a QUnit test that stubs
$.ajaxto resolve synchronously and assertstotalAttachmentsis read from theX-WP-Totalheader. It fails on trunk with theTypeErrorand passes with the fix. Run withnpx grunt qunit.Trac ticket: https://core.trac.wordpress.org/ticket/54205
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Implementation, tests, and PR description. Reviewed by Igor Rozum.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code