Skip to content

Media: Fix wp.ajax.send() error when an attachments query completes synchronously - #14249

Open
irozum wants to merge 2 commits into
WordPress:trunkfrom
irozum:fix/54205-wp-ajax-send-sync-jqxhr
Open

irozum wants to merge 2 commits into
WordPress:trunkfrom
irozum:fix/54205-wp-ajax-send-sync-jqxhr

Conversation

@irozum

@irozum irozum commented Oct 13, 2026

Copy link
Copy Markdown

Summary

wp.ajax.send() reads deferred.jqXHR inside the .done() callback to get the X-WP-Total header for query-attachments requests. If the request completes synchronously (for example jQuery.ajaxSetup( { async: false } ), a custom transport, or a plugin that mocks or caches $.ajax), jQuery runs the callback before $.ajax() returns, so deferred.jqXHR is still undefined and the guard throws a TypeError. In the media grid this also leaves every matching attachment duplicated.

This uses the jqXHR jQuery passes as the third argument to .done(), which is always defined. Async behaviour is unchanged.

Testing

Added a QUnit test that stubs $.ajax to resolve synchronously and asserts totalAttachments is read from the X-WP-Total header. It fails on trunk with the TypeError and passes with the fix. Run with npx grunt qunit.

Trac ticket: https://core.trac.wordpress.org/ticket/54205

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Implementation, tests, and PR description. Reviewed by Igor Rozum.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props irozum.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant