Skip to content

Quick/Bulk Edit: Use literal curly quotes in translatable string instead of HTML entities - #14336

Open
robelsust wants to merge 1 commit into
WordPress:trunkfrom
robelsust:fix/66314-remove-html-entities-inline-edit-post
Open

robelsust wants to merge 1 commit into
WordPress:trunkfrom
robelsust:fix/66314-remove-html-entities-inline-edit-post

Conversation

@robelsust

Copy link
Copy Markdown

Description

Trac ticket: https://core.trac.wordpress.org/ticket/66314

In src/js/_enqueues/admin/inline-edit-post.js, line 224:

buttonVisuallyHiddenText = wp.i18n.sprintf(
    /* translators: %s: Post title. */
    wp.i18n.__( 'Remove “%s” from Bulk Edit' ),
    theTitle
);

HTML entities like “ and ” should not be present in JavaScript translatable strings:

  1. In GlotPress (translate.wordpress.org), translators for languages with different quotation rules (such as German „...“ or French «...») are forced to deal with raw numeric HTML character references rather than standard typographical punctuation.
  2. In client-side JavaScript, translatable strings are intended as literal text. Replacing “ and ” with Unicode curly quotes “ and ” adheres to WordPress internationalization best practices and ensures consistent rendering across both assistive technology and localization tooling.

Testing Instructions

  1. Navigate to Posts > All Posts in the WordPress admin.
  2. Select multiple posts by checking their checkboxes in the table.
  3. In the Bulk Actions dropdown, select Edit and click Apply.
  4. Inspect the Bulk Edit area showing the list of selected posts.
  5. Inspect the remove button markup for each post (.ntdelbutton .screen-reader-text):
    • Before: Contains Remove “...” from Bulk Edit (raw entity string).
    • After: Contains Remove “...” from Bulk Edit (clean curly quotes).
  6. Verify clicking the remove button continues to remove the item from the bulk edit list as expected.

…ead of HTML entities.

In JavaScript translatable strings, literal curly quotes should be used instead of HTML entities so translators do not have to handle raw numeric entities in GlotPress, and the string is not displayed as raw entity markup when processed outside of HTML contexts.

Props robelsust.
Fixes #66314.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props therssoftware.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant