Repository navigation
Conversation
The menu item quick search announced its result count with `__( '%d Search Results Found' )`, which reads "1 Search Results Found" for a single result and gives translators no plural forms. Use `_n()` with a translators comment and the existing "%d result found." pair. Adds a QUnit test for the announced text. See #66341.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The menu item quick search on Appearance > Menus announced its result count with
__( '%d Search Results Found' ). The English string is always plural, so one result was announced as "1 Search Results Found", and translators had no plural forms and no translators comment.This uses
_n( '%d result found.', '%d results found.', count )with a translators comment, astags-suggest.jsdoes. The pair already exists inwordpress.potfor the block editor.nav-menu.jsalready gets "No results found." from that catalog, and the Hindi language pack's JSON file fornav-menu.jsincludes it, so existing translations of the pair should reach the Menus screen once language packs are rebuilt with the new reference. It also matches that "No results found." message, which the same function announces when nothing matches.Adds a QUnit test that runs
wpNavMenu.processQuickSearchQueryResponse()with one and two results and checks the announced text. It fails on trunk and passes with the change.Tested in a browser on WordPress 7.1.3, whose quick search handler is identical to trunk: searching posts for a term with one match now announces "1 result found.", two matches announce "2 results found.", and a search with no match still announces "No results found.".
Trac ticket: https://core.trac.wordpress.org/ticket/66341
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code and Codex
Used for: Investigation, implementation, QUnit test, browser verification, and PR wording. I reviewed the reasoning and test results, and I take responsibility for the contribution.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.