Skip to content

Administration: Brighten the icon color of the Fresh admin color scheme - #15143

Closed
fushar wants to merge 3 commits into
WordPress:trunkfrom
fushar:fresh-icon-color
Closed

fushar wants to merge 3 commits into
WordPress:trunkfrom
fushar:fresh-icon-color

Conversation

@fushar

@fushar fushar commented Oct 29, 2026 •

Copy link
Copy Markdown

Proposed changes

Trac ticket: https://core.trac.wordpress.org/ticket/66411

In 7.2, the admin menu and toolbar icons are being switched from Dashicons to SVG icons. Most of the new icons are outline icons with a thin (1.5px) stroke, while the previous Dashicons are solid icons. Somehow, Fresh is the only scheme that dims the icon color with opacity (rgba(240, 246, 252, 0.6)), while other dark schemes use near-white icon color. In my opinion, this makes the icons look too dimmed and visually imbalanced with the text color.

ALL logged-in frontend screens are affected, because the Fresh color scheme will be used for the admin bar.

So, this PR proposes to raise the icon color opacity from 0.6 to 0.85 for the Fresh admin color scheme, in the admin menu and the toolbar, as suggested by @fcoveram on #12270 (comment).

EDIT: updated to 0.77 as per https://core.trac.wordpress.org/ticket/66411?replyto=3#comment:3.

Screenshots

7.1

7 1-frontend-admin-bar-left

7.2 (current, 0.6)

7 2-frontend-admin-bar-left



7.2 (this PR, 0.77 / #c3c4c7)

7 2-proposed-frontend-admin-bar-left



image

Testing instructions

  1. Use the Fresh admin color scheme.
  2. Compare the admin menu and admin bar icons (wp-admin and frontend) with and without this PR.
  3. Confirm hover, focus, and current menu item colors are unchanged.
  4. Switch to another color scheme and confirm the icon colors are unchanged.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Investigating the color rules, trying values locally, generating screenshots, and drafting this description, with my supervision.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@fushar
fushar force-pushed the fresh-icon-color branch 2 times, most recently from c3c63a2 to 0b2e16d Compare October 29, 2026 07:54
@fushar
fushar marked this pull request as ready for review October 29, 2026 07:55
@fushar
fushar requested a review from Mamaduka October 29, 2026 07:55
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props fushar, wildworks, ramonopoly, fcoveram, sadmansakibnadvi, rollybueno.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I'm in favor of this change, but I think we should also update at least the following place at the same time. Otherwise, there will be a slight color mismatch.

In the other color schemes, the collapse button uses $menu-collapse-text, which defaults to $menu-icon (see src/wp-admin/css/colors/_admin.scss). That means it matches the menu icon color.

@fcoveram

Copy link
Copy Markdown

This looks good to me ✨

@fushar

fushar commented Oct 29, 2026

Copy link
Copy Markdown
Author

I think we should also update at least the following place at the same time. Otherwise, there will be a slight color mismatch.

@t-hamano: I missed that, thanks. Updated 👍


(In the Trac ticket)

#64934 reported that the icons were too bright compared to the text in Modern and other color schemes.

I would suggest increasing the contrast by only one shade to Gray 10 #c3c4c7, which is close to the RGBA color at 0.77 opacity. Also, removing the semi-transparent color would simplify the ruleset and might still fix #39261.

@sabernhardt: I think that makes sense, thanks. I updated the color to #c3c4c7. It's still better that the existing color 👍

@sadmansakibnadvi

Copy link
Copy Markdown

Tested on 7.2-beta3-64990 with computed colors in Chrome. In Fresh, menu icons, toolbar icons (admin and front end), the collapse button and svg-painter tinted plugin icons all land on #c3c4c7. Hover, focus and current colors are unchanged, and Modern and Midnight are identical before and after. Contrast against #1d2327 goes from 6.16:1 to 9.11:1.

Details on the ticket: https://core.trac.wordpress.org/ticket/66411

@rollybueno

Copy link
Copy Markdown
Member

Before
2

After
3

I see no color difference but may it's just me 😓

The patch is applied though. On Fresh, the resting Dashboard icon and the toolbar icon compute to #c3c4c7 (rgb(195, 196, 199)). The current item stays white, which is probably why the two shots look the same. Hover and focus are unchanged.

The admin menu and toolbar icons are now mostly outline SVG icons with a thin stroke, which look washed out at the Fresh scheme's `0.6` opacity, and unbalanced next to the opaque menu and toolbar text. Raise the opacity to `0.85` for both Dashicons and SVG icons, so they keep the same color.

Also update the base icon color of the scheme to match, which is used to paint menu icons given as base64-encoded SVG.
Comment thread src/wp-admin/includes/misc.php Resolved

@ramonjd ramonjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the tests.

All passing locally for me.

Looks like we have consensus to commit this.

wporg-sync pushed a commit that referenced this pull request Nov 3, 2026
In 7.2, the admin menu and toolbar icons are being switched from Dashicons to SVG icons.

This commits updates the colors to brighten / increase the opacity of icons (both dashicons and SVG icons) in the Fresh scheme

Developed in: #15143

Follow-up to [65089].

Props fushar, wildworks, ramonopoly, fcoveram, sadmansakibnadvi, rollybueno.

Fixes #66411.



git-svn-id: https://develop.svn.wordpress.org/trunk@65219 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 65219
GitHub commit: 40ad775

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Nov 3, 2026
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Nov 3, 2026
In 7.2, the admin menu and toolbar icons are being switched from Dashicons to SVG icons.

This commits updates the colors to brighten / increase the opacity of icons (both dashicons and SVG icons) in the Fresh scheme

Developed in: WordPress/wordpress-develop#15143

Follow-up to [65089].

Props fushar, wildworks, ramonopoly, fcoveram, sadmansakibnadvi, rollybueno.

Fixes #66411.


Built from https://develop.svn.wordpress.org/trunk@65219


git-svn-id: http://core.svn.wordpress.org/trunk@64368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants