Repository navigation
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
c3c63a2 to
0b2e16d
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR. I'm in favor of this change, but I think we should also update at least the following place at the same time. Otherwise, there will be a slight color mismatch.
In the other color schemes, the collapse button uses $menu-collapse-text, which defaults to $menu-icon (see src/wp-admin/css/colors/_admin.scss). That means it matches the menu icon color.
|
This looks good to me ✨ |
@t-hamano: I missed that, thanks. Updated 👍 (In the Trac ticket)
@sabernhardt: I think that makes sense, thanks. I updated the color to |
|
Tested on 7.2-beta3-64990 with computed colors in Chrome. In Fresh, menu icons, toolbar icons (admin and front end), the collapse button and svg-painter tinted plugin icons all land on #c3c4c7. Hover, focus and current colors are unchanged, and Modern and Midnight are identical before and after. Contrast against #1d2327 goes from 6.16:1 to 9.11:1. Details on the ticket: https://core.trac.wordpress.org/ticket/66411 |
|
I see no color difference but may it's just me 😓 The patch is applied though. On Fresh, the resting Dashboard icon and the toolbar icon compute to #c3c4c7 (rgb(195, 196, 199)). The current item stays white, which is probably why the two shots look the same. Hover and focus are unchanged. |
The admin menu and toolbar icons are now mostly outline SVG icons with a thin stroke, which look washed out at the Fresh scheme's `0.6` opacity, and unbalanced next to the opaque menu and toolbar text. Raise the opacity to `0.85` for both Dashicons and SVG icons, so they keep the same color. Also update the base icon color of the scheme to match, which is used to paint menu icons given as base64-encoded SVG.
d0ebe4c to
e03e5a9
Compare
ramonjd
left a comment
There was a problem hiding this comment.
Thanks for updating the tests.
All passing locally for me.
Looks like we have consensus to commit this.
In 7.2, the admin menu and toolbar icons are being switched from Dashicons to SVG icons. This commits updates the colors to brighten / increase the opacity of icons (both dashicons and SVG icons) in the Fresh scheme Developed in: #15143 Follow-up to [65089]. Props fushar, wildworks, ramonopoly, fcoveram, sadmansakibnadvi, rollybueno. Fixes #66411. git-svn-id: https://develop.svn.wordpress.org/trunk@65219 602fd350-edb4-49c9-b593-d223f7449a82
In 7.2, the admin menu and toolbar icons are being switched from Dashicons to SVG icons. This commits updates the colors to brighten / increase the opacity of icons (both dashicons and SVG icons) in the Fresh scheme Developed in: WordPress/wordpress-develop#15143 Follow-up to [65089]. Props fushar, wildworks, ramonopoly, fcoveram, sadmansakibnadvi, rollybueno. Fixes #66411. Built from https://develop.svn.wordpress.org/trunk@65219 git-svn-id: http://core.svn.wordpress.org/trunk@64368 1a063a9b-81f0-0310-95a4-ce76da25c4cd


Proposed changes
Trac ticket: https://core.trac.wordpress.org/ticket/66411
In 7.2, the admin menu and toolbar icons are being switched from Dashicons to SVG icons. Most of the new icons are outline icons with a thin (1.5px) stroke, while the previous Dashicons are solid icons. Somehow, Fresh is the only scheme that dims the icon color with opacity (
rgba(240, 246, 252, 0.6)), while other dark schemes use near-white icon color. In my opinion, this makes the icons look too dimmed and visually imbalanced with the text color.ALL logged-in frontend screens are affected, because the Fresh color scheme will be used for the admin bar.
So, this PR proposes to raise the icon color opacity from0.6to0.85for the Fresh admin color scheme, in the admin menu and the toolbar, as suggested by @fcoveram on #12270 (comment).EDIT: updated to
0.77as per https://core.trac.wordpress.org/ticket/66411?replyto=3#comment:3.Screenshots
7.1
7.2 (current,
0.6)7.2 (this PR,
0.77/#c3c4c7)Testing instructions
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Investigating the color rules, trying values locally, generating screenshots, and drafting this description, with my supervision.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.